[checkmk-commits] Check_MK Git: check_mk: Really fix visibility of Optional ValueSpec

Module: check_mk Branch: master Commit: 3b34919e808a494a6f09b8797a80cdd52715ae5a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3b34919e808a49… Author: Mathias Kettner &lt;mk(a)mathias-kettner.de&gt; Date: Thu Mar 22 17:41:04 2012 +0100 Really fix visibility of Optional ValueSpec --- web/htdocs/valuespec.py | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 9ffd5ed..951fa10 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -1210,7 +1210,10 @@ class Optional(ValueSpec): div_id = "option_" + varprefix checked = html.get_checkbox(varprefix + "_use") if checked == None: - checked = (value != None) + if self._negate: + checked = value == None + else: + checked = value != None html.write("<span>") @@ -1233,8 +1236,12 @@ class Optional(ValueSpec): else: html.write("<br><br>") html.write("</span>") - html.write('<span id="%s" display: %s">' % ( - div_id, checked == self._negate and "none" or "")) + if checked == self._negate: + display = "none" + else: + display = "" + + html.write('<span id="%s" style="display: %s">' % (div_id, display)) if value == None: value = self._valuespec.default_value() if self._valuespec.title():