[checkmk-commits] [tribe29/checkmk] f7aaa3: Decouple Renderers and the concrete Columns

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f7aaa3264a996565c682c6b528f90e6e179aae0d https://github.com/tribe29/checkmk/commit/f7aaa3264a996565c682c6b528f90e6e1… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-05-31 (Mon, 31 May 2021) Changed paths: M livestatus/src/CommentColumn.cc M livestatus/src/CommentColumn.h M livestatus/src/DowntimeColumn.cc M livestatus/src/DowntimeColumn.h M livestatus/src/ServiceGroupMembersColumn.cc M livestatus/src/ServiceGroupMembersColumn.h M livestatus/src/ServiceListColumn.cc M livestatus/src/ServiceListColumn.h Log Message: ----------- Decouple Renderers and the concrete Columns This is the same trick that we used for the filters and the aggregators. The loser coupling lets us templatize and modify the columns without touching the renderers. For this, we need to move the two `Entry` classes out of the columns. CMK-7076 Change-Id: I57faddeb89994bf1e82558d8bb4135afebbbc564 Commit: c879f18d0ea5846727bc43e643402ee83a6ab4dd https://github.com/tribe29/checkmk/commit/c879f18d0ea5846727bc43e643402ee83… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-05-31 (Mon, 31 May 2021) Changed paths: M livestatus/src/CommentColumn.cc M livestatus/src/CommentColumn.h M livestatus/src/TableHosts.cc M livestatus/src/TableServices.cc Log Message: ----------- Lambda-ify CommentColumn In contrast with the other lambda-columns, we need two template parameters here because the values is first obtained from T -> U and the serialization from U -> string happens in a second step. CMK-7076 Change-Id: I78aff67d684ddc6feb9f7ffab99e963e9e9ed6c3 Commit: d8eaf818526a2e066ce93c5ef154790e86b44255 https://github.com/tribe29/checkmk/commit/d8eaf818526a2e066ce93c5ef154790e8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-05-31 (Mon, 31 May 2021) Changed paths: M livestatus/src/CommentColumn.h Log Message: ----------- Let the serialization depend on the type As already noted, the `getValue()` function of * CommentColumn * DowntimeColumn * ServiceGroupMembersColumn * ServiceListColumn only differs on the serialization function. This, in turns (obviously) depends on the type of the data. We let the code do exactly that. CMK-7076 Change-Id: I066b43d19329f417ab528e7c97708d0126d3a384 Compare: https://github.com/tribe29/checkmk/compare/f1d1c265a2a1...d8eaf818526a