Module: check_mk
Branch: master
Commit: 50af1598239a443361d5cfe2aa6b16bde46059b3
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=50af1598239a44…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Fri Oct 27 09:56:24 2017 +0200
Improved const-correctness.
Change-Id: I5705ef69ace562e8df644a7684630c37a97be600
---
livestatus/src/Query.cc | 2 +-
livestatus/src/Query.h | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/livestatus/src/Query.cc b/livestatus/src/Query.cc
index 74e42c0..29361e7 100644
--- a/livestatus/src/Query.cc
+++ b/livestatus/src/Query.cc
@@ -193,7 +193,7 @@ void Query::invalidRequest(const std::string &message) const {
_output.setError(OutputBuffer::ResponseCode::invalid_request, message);
}
-std::unique_ptr<Filter> Query::createFilter(Column &column,
+std::unique_ptr<Filter> Query::createFilter(const Column &column,
RelationalOperator relOp,
const std::string &value) {
try {
diff --git a/livestatus/src/Query.h b/livestatus/src/Query.h
index 91cff49..b7d663b 100644
--- a/livestatus/src/Query.h
+++ b/livestatus/src/Query.h
@@ -112,9 +112,7 @@ private:
bool doStats() const;
void doWait();
- // TODO(sp) The column parameter should actually be a const reference, but
- // Column::createFilter is not const-correct yet...
- std::unique_ptr<Filter> createFilter(Column &column,
+ std::unique_ptr<Filter> createFilter(const Column &column,
RelationalOperator relOp,
const std::string &value);
void parseFilterLine(char *line, VariadicFilter &filter);