[checkmk-commits] Fixed left over comma after refactoring

Module: check_mk Branch: master Commit: 645e8380847d7ef458def58c1da7f63a3908c9bf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=645e8380847d7e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 18 19:48:15 2019 +0100 Fixed left over comma after refactoring Change-Id: If4ccfcd6b4562a9bf1c80277ecab457b623702c9 --- cmk/gui/plugins/views/mkeventd.py | 2 +- tests/unit/cmk/gui/test_gui_config.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/cmk/gui/plugins/views/mkeventd.py b/cmk/gui/plugins/views/mkeventd.py index b74b343..7c45230 100644 --- a/cmk/gui/plugins/views/mkeventd.py +++ b/cmk/gui/plugins/views/mkeventd.py @@ -639,7 +639,7 @@ class PermissionECUpdateEvent(Permission): @property def description(self): - return _("Needed for acknowledging and changing the comment and contact of an event"), + return _("Needed for acknowledging and changing the comment and contact of an event") @property def defaults(self): diff --git a/tests/unit/cmk/gui/test_gui_config.py b/tests/unit/cmk/gui/test_gui_config.py index c591d5c..0fdd340 100644 --- a/tests/unit/cmk/gui/test_gui_config.py +++ b/tests/unit/cmk/gui/test_gui_config.py @@ -1,3 +1,4 @@ +import six import pytest from pathlib2 import Path @@ -488,6 +489,12 @@ def test_registered_permissions(): assert sorted(expected_permissions) == sorted(permission_registry.keys()) + for perm_class in permission_registry.values(): + perm = perm_class() + assert isinstance(perm.description, six.string_types) + assert isinstance(perm.title, six.string_types) + assert isinstance(perm.defaults, list) + def test_declare_permission_section(monkeypatch): monkeypatch.setattr(permissions, "permission_section_registry",