[checkmk-commits] [tribe29/checkmk] a4aa58: Rename make_sources -> make_non_cluster_sources

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a4aa58324f141a0ea1538c0921e55c57f3c47aa9 https://github.com/tribe29/checkmk/commit/a4aa58324f141a0ea1538c0921e55c57f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-03-22 (Tue, 22 Mar 2022) Changed paths: M cmk/base/agent_based/data_provider.py M cmk/base/automations/check_mk.py M cmk/base/core_nagios.py M cmk/base/dump_host.py M cmk/base/modes/check_mk.py M cmk/base/sources/_checkers.py M cmk/base/sources/fetcher_configuration.py M tests/unit/cmk/base/sources/test_data_sources.py Log Message: ----------- Rename make_sources -> make_non_cluster_sources We had make_sources and make_cluster_sources--this somewhat clarifies the difference. CMK-10076 Change-Id: I2407df6583cd4696a15bdf479685960e12e11499 Commit: 19f4baf85b67fd034c7a7bbc38c8772604b2cec4 https://github.com/tribe29/checkmk/commit/19f4baf85b67fd034c7a7bbc38c877260… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-03-22 (Tue, 22 Mar 2022) Changed paths: M cmk/base/agent_based/checking/__init__.py M cmk/base/agent_based/data_provider.py M cmk/base/agent_based/discovery/__init__.py M cmk/base/agent_based/inventory/__init__.py M cmk/base/sources/_checkers.py Log Message: ----------- Extract make_sources We have make_non_cluster_sources and make_cluster_sources, make_sources is the generic version of these. It uses either the cluster version or the non-cluster version based on the configuration. This lets us reduce the number of arguments to make_broker and somewhat clarifies its API. More importantly, the goal is to make sure that the sources correspond to the fetcher messages in any case and this should best be realized ASAP in the call stack. So, a function may take the sources and fetch the data from them but taking the messages and guessing their origin is always risky. CMK-10076 Change-Id: Iace76fb82d9d1babd6890320147d98f8c46bdbe7 Commit: 483de08299e7c7231bdeb6168a5436bb1c221ae7 https://github.com/tribe29/checkmk/commit/483de08299e7c7231bdeb6168a5436bb1… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-03-22 (Tue, 22 Mar 2022) Changed paths: M cmk/base/agent_based/data_provider.py M cmk/base/agent_based/discovery/__init__.py M cmk/base/agent_based/inventory/__init__.py M cmk/base/sources/_checkers.py Log Message: ----------- Move fetch_all to caller Having the fetcher messages *before* the sources can only result in guessing from which source the message originated. Passing a dummy value to make_broker and letting it fetch the messages from the sources *in some cases* is also confusing. Let us clarify the algorithm here: 1. Create the sources 2. Fetch 3. call make_broker CMK-10076 Change-Id: I16c9f23a0cab385d61c343debf69391c42d2422b Compare: https://github.com/tribe29/checkmk/compare/f1e8c4248905...483de08299e7