[checkmk-commits] Check_MK Git: check_mk: FIX: netapp_vfiler: fix inventory function ( thanks to Falk Krentzlin)

Module: check_mk Branch: master Commit: 28bfd31c8159931948016ce0fb9e5e12767e3670 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=28bfd31c815993… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Oct 16 16:46:22 2012 +0200 FIX: netapp_vfiler: fix inventory function (thanks to Falk Krentzlin) Conflicts: ChangeLog --- ChangeLog | 7 +++++++ checks/netapp_vfiler | 10 ++++------ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6254cb8..fbb7fa1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -93,6 +93,13 @@ * FIX: Linux mk_logwatch: iregex Parameter was never used * FIX: Windows agent: quote '%' in plugin output correctly * FIX: multipath check now handles '-' in "user friendly names" + * New check mssql_counters.locks: Monitors locking related information of + MSSQL tablespaces + * FIX: mssql_counters checks now really only inventorize percentage based + counters if a base value is set + * windows_updates agent plugin: Fetching data in background mode, caching + update information for 30 minutes + * FIX: netapp_vfiler: fix inventory function (thanks to Falk Krentzlin) 1.2.1i1: Core: diff --git a/checks/netapp_vfiler b/checks/netapp_vfiler index 3c6809d..5282d44 100644 --- a/checks/netapp_vfiler +++ b/checks/netapp_vfiler @@ -34,25 +34,23 @@ def inventory_netapp_vfiler(info): - inventory = [] for line in info: # If we find an entry consisting of name and status, add it to inventory. - # otherwise we dont inventorize anything. - if len(info) == 2: - inventory.append([line[0], None]) + # otherwise we don't inventorize anything. + if len(line) == 2: + inventory.append((line[0], None)) return inventory def check_netapp_vfiler(item, _no_params, info): - for vfEntry in info: vfName, vfState = vfEntry if vfName == item: if vfState == "2": return (0, "OK - vFiler is running") elif vfState == "1": - return (2, "CRIT - vFiler is stopped!!") + return (2, "CRIT - vFiler is stopped") else: return (3, "UNKOWN - vFiler status unknown") return (3, "UNKNOWN - vFiler not found in SNMP output")