[checkmk-commits] Check_MK Git: check_mk: #1170 Added buttons to move rules to top/ bottom of the list to ruleset edit dialog

Module: check_mk Branch: master Commit: bf5a5144d0ddf0cba86e53bb8f2d0c6d9d4b1f24 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bf5a5144d0ddf0… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Nov 4 09:08:43 2014 +0100 #1170 Added buttons to move rules to top/bottom of the list to ruleset edit dialog --- .werks/1170 | 9 +++++++++ ChangeLog | 1 + web/htdocs/wato.py | 14 +++++++++++--- 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/.werks/1170 b/.werks/1170 new file mode 100644 index 0000000..eaca018 --- /dev/null +++ b/.werks/1170 @@ -0,0 +1,9 @@ +Title: Added buttons to move rules to top/bottom of the list to ruleset edit dialog +Level: 1 +Component: wato +Compatible: compat +Version: 1.2.5i7 +Date: 1415088495 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index b11f4cf..6ca13d8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -20,6 +20,7 @@ * 1482 FIX: Fix exception when editing a visual of type single host group... WATO: + * 1170 Added buttons to move rules to top/bottom of the list to ruleset edit dialog * 1165 FIX: Fixed exception in service discovery of logwatch event console forwarding checks... Notifications: diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 38f809e..ede84b6 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -13688,8 +13688,12 @@ def mode_edit_ruleset(phase): del rules[rulenr] if action == "up": rules[rulenr-1:rulenr-1] = [ rule ] - else: + elif action == "down": rules[rulenr+1:rulenr+1] = [ rule ] + elif action == "top": + rules.insert(0, rule) + else: + rules.append(rule) save_rulesets(rule_folder, rulesets) mark_affected_sites_dirty(rule_folder) log_pending(AFFECTED, None, "edit-ruleset", @@ -13810,13 +13814,17 @@ def mode_edit_ruleset(phase): # Actions table.cell(_("Order"), css="buttons rulebuttons") if not first_in_group: - rule_button("up", _("Move this rule one position up"), folder, rel_rulenr) + rule_button("top", _("Move this rule to the top of the list"), folder, rel_rulenr) + rule_button("up", _("Move this rule one position up"), folder, rel_rulenr) else: rule_button(None) + rule_button(None) if not last_in_group: - rule_button("down", _("Move this rule one position down"), folder, rel_rulenr) + rule_button("down", _("Move this rule one position down"), folder, rel_rulenr) + rule_button("bottom", _("Move this rule to the bottom of the list"), folder, rel_rulenr) else: rule_button(None) + rule_button(None) table.cell(_("Actions"), css="buttons rulebuttons") edit_url = make_link([