[checkmk-commits] [tribe29/checkmk] 10be31: SAML: introduce log level setting and consistent w...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 10be312fbf9c367b8499f69a6cf5c5abff3edf1c https://github.com/tribe29/checkmk/commit/10be312fbf9c367b8499f69a6cf5c5abf… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M cmk/gui/config.py M cmk/gui/login.py M cmk/gui/plugins/config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/userdb/saml2/connector.py M cmk/gui/userdb/saml2/interface.py M cmk/gui/userdb/saml2/pages.py M tests/testlib/site.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: introduce log level setting and consistent way of logging errors The following strategy for logging is implemented: * Let Exceptions raise through to the last instance (GUI pages) * Let GUI pages handle the errors, i.e. 'transform' them to MKUserError * Messages from MKUserError may be shown to the user, other error messages may not (because they can contain sensitive information) * Use 'raise from' such that the original Exception and traceback will be shown in the logs Note: * There does not need to be a great level of detail in the error messages facing the user, because any issues need to be fixed by the Checkmk administrator anyway * Any failed logins are handled by the Identity Provider directly, not by Checkmk This simplifies the workflow for backend functions, error handling is done in just one place and we're less likely to lose useful information. CMK-11846 Change-Id: Ia989c1b8338610ed9139f4741ee72fa1644d69fa Commit: 45494f380b7e53c4cdd9692f927a7d3e978a01f3 https://github.com/tribe29/checkmk/commit/45494f380b7e53c4cdd9692f927a7d3e9… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/pages.py Log Message: ----------- SAML pages: move common functionality to helper functions Change-Id: Icfbb42791679e4603ffbb844f2a56d430febbe81 Commit: bc36c5da8ca349ed58ed50826352d8470b6b839d https://github.com/tribe29/checkmk/commit/bc36c5da8ca349ed58ed50826352d8470… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M cmk/gui/wato/pages/saml2.py Log Message: ----------- SAML2 config page: amend incorrect help text Change-Id: Ic8d6ebf2c538a8cae51d5a9b6e049227a078dd1a Commit: d4ef0f367bff135dc1944bfe7c7e8aa7f5b9b01e https://github.com/tribe29/checkmk/commit/d4ef0f367bff135dc1944bfe7c7e8aa7f… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M packages/livestatus/run-ci Log Message: ----------- Nit-picking: Make RUN_BUILD_UNIT_TESTS readonly, too. Change-Id: I2df3a24333fd41cf9d0be1dfe87a94b3c3b5eb95 Compare: https://github.com/tribe29/checkmk/compare/57932088507f...d4ef0f367bff