2 Nov
2020
2 Nov
'20
9:22 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 15685beef253c252fa46b2dd9d0eeab3695d167b
https://github.com/tribe29/checkmk/commit/15685beef253c252fa46b2dd9d0eeab36…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/login.py
M tests/unit/cmk/gui/conftest.py
Log Message:
-----------
Simplify logged in user context handling
Centralizing the registration and cleanup of the logged
in user in the new UserContext context manager.
Change-Id: I5e1425f27bd4a3e9c0239073df72fc719eb08479
Commit: 80420be88599ddf42847822c139434106d24e89b
https://github.com/tribe29/checkmk/commit/80420be88599ddf42847822c139434106…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/globals.py
M cmk/gui/login.py
M cmk/gui/userdb.py
A cmk/gui/utils/flashed_messages.py
M tests/unit/cmk/gui/test_userdb.py
A tests/unit/cmk/gui/utils/test_flashed_messages.py
Log Message:
-----------
Session info can now be extended; Stored messages between requests
* The SessionInfo structure can now be extended during the request
with additional information.
* The session info update, that was done at the beginning of the
request (by _refresh_session()) is now done on end of request
(to only have a single session write operation per request)
* Introduce a message flashing mechanism, similar to flask
(https://flask.palletsprojects.com/en/1.1.x/patterns/flashing/),
but very basic. The persistence between requests is done using
the just introduced SessionInfo store.
This message flashing will be used to replace the existing action
handler with the POST/redirect/GET pattern on our WATO pages. This is
done to prevent issues on page reloads.
Change-Id: Iafcd3fffb5c8c863abaa826fe40cd3c5452651dd
Commit: 9e812c10d5d467c3e9b649c4efeb91e3b485a45f
https://github.com/tribe29/checkmk/commit/9e812c10d5d467c3e9b649c4efeb91e3b…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/wato/page_handler.py
Log Message:
-----------
Rewrite WATO page handler to PRG pattern
Instead of "in page redirect" to another mode, we now use the
POST/redirect/GET pattern. This prevents problems with page
reloads.
This change will break several pages in WATO. We'll fix this
in the next commits where we simplify the ActionResult type
by extracting the different features from it until we end up
with an Optional[FinalizeRequest] type.
Change-Id: Ifda23e09e382604ff2c6ee95d7090e966a496632
Commit: 03bd17d40eaa137f161f400a89d5ec5f5a4a1e8c
https://github.com/tribe29/checkmk/commit/03bd17d40eaa137f161f400a89d5ec5f5…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/plugins/wato/utils/base_modes.py
Log Message:
-----------
Move mode registry to base_modes to prevent import loop in next step
Change-Id: I2640a021c0b85f78b52c05e7bd04d18131b4984c
Commit: ef2c0c588e3a8a735355eb795cef865c7a18ee10
https://github.com/tribe29/checkmk/commit/ef2c0c588e3a8a735355eb795cef865c7…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/exceptions.py
M cmk/gui/plugins/wato/__init__.py
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/plugins/wato/utils/base_modes.py
M cmk/gui/plugins/wato/utils/simple_modes.py
M cmk/gui/wato/pages/rulesets.py
Log Message:
-----------
Add helper for cleaning up ActionResult types
* Add mode_url helper to build an URL to the given WATO mode
* Add redirect helper to build a redirection object
Along the way:
* HTTPRedirect: It's now possible to customize the status code.
* Use the new helpers in two places to proove it works out
Change-Id: Icec8d469beb9ef79fccba0275cd62119373cf50e
Commit: 659c8a3b23dcf55f8c641c73e2460879c963bd25
https://github.com/tribe29/checkmk/commit/659c8a3b23dcf55f8c641c73e2460879c…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/utils/flashed_messages.py
M tests/unit/cmk/gui/utils/test_flashed_messages.py
Log Message:
-----------
Make flashed message able to handle HTML and str messages
Change-Id: Ie65f7d7f299eb63bbaf02943670c5007e6adf8fa
Commit: 000bcbfd1d607d81dc84c8619f5cac813387f3c6
https://github.com/tribe29/checkmk/commit/000bcbfd1d607d81dc84c8619f5cac813…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-11-02 (Mon, 02 Nov 2020)
Changed paths:
M cmk/gui/backup.py
M cmk/gui/key_mgmt.py
M cmk/gui/plugins/wato/background_job.py
M cmk/gui/plugins/wato/bi_config.py
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/plugins/wato/utils/base_modes.py
M cmk/gui/plugins/wato/utils/simple_modes.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/wato/page_handler.py
M cmk/gui/wato/pages/audit_log.py
M cmk/gui/wato/pages/bulk_edit.py
M cmk/gui/wato/pages/bulk_import.py
M cmk/gui/wato/pages/check_catalog.py
M cmk/gui/wato/pages/custom_attributes.py
M cmk/gui/wato/pages/diagnostics.py
M cmk/gui/wato/pages/folders.py
M cmk/gui/wato/pages/global_settings.py
M cmk/gui/wato/pages/groups.py
M cmk/gui/wato/pages/host_diagnose.py
M cmk/gui/wato/pages/host_rename.py
M cmk/gui/wato/pages/hosts.py
M cmk/gui/wato/pages/icons.py
M cmk/gui/wato/pages/ldap.py
M cmk/gui/wato/pages/notifications.py
M cmk/gui/wato/pages/random_hosts.py
M cmk/gui/wato/pages/read_only.py
M cmk/gui/wato/pages/roles.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/search.py
M cmk/gui/wato/pages/sites.py
M cmk/gui/wato/pages/tags.py
M cmk/gui/wato/pages/timeperiods.py
M cmk/gui/wato/pages/users.py
Log Message:
-----------
Cleanup ActionResult
Change ActionResult Optional[FinalizeRequest] and refactor all call
sites to match the new API.
Change-Id: I42d964a257c24eefcec306db60ee1d54180ba24a
Compare: https://github.com/tribe29/checkmk/compare/fbfc1df8b179...000bcbfd1d60