[checkmk-commits] [Checkmk/checkmk] 2d904e: Rework check_traceroute unit tests

Branch: refs/heads/2.1.0 Home: https://github.com/Checkmk/checkmk Commit: 2d904e1fbbf7a9283934ff047137722ad106f9d7 https://github.com/Checkmk/checkmk/commit/2d904e1fbbf7a9283934ff047137722ad… Author: Joerg Herbel &lt;joerg.herbel(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M tests/unit/active_checks/test_ac_check_traceroute.py Log Message: ----------- Rework check_traceroute unit tests CMK-12029 Change-Id: I0176f34c6afd2c8820181b9fb0fe7809fa05d230 Commit: 8201ba3c5ab81fd62d7989ff5d5e81ecc7d60fdb https://github.com/Checkmk/checkmk/commit/8201ba3c5ab81fd62d7989ff5d5e81ecc… Author: Joerg Herbel &lt;joerg.herbel(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M active_checks/check_traceroute M tests/unit/active_checks/test_ac_check_traceroute.py Log Message: ----------- check_traceroute: extract buggy code into separate function CMK-12029 Change-Id: I7a7eab11d6601ab4ea4bf5b49d962c817b3b9fb6 Commit: cc2e855e870a6d13ea1c37bb0fa048f4adfb8880 https://github.com/Checkmk/checkmk/commit/cc2e855e870a6d13ea1c37bb0fa048f4a… Author: Joerg Herbel &lt;joerg.herbel(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A .werks/15735 M active_checks/check_traceroute M tests/unit/active_checks/test_ac_check_traceroute.py Log Message: ----------- 15735 FIX <tt>check_traceroute</tt>: Fix checking of routers specified by domain name CMK-12029 Change-Id: I4bbf96b36dcccabef168973f0777e1aa8c84f690 Commit: bb2c700ec81af2e614d76e6da2eb53eab866c226 https://github.com/Checkmk/checkmk/commit/bb2c700ec81af2e614d76e6da2eb53eab… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- impi: clean up utils Change-Id: Ibfa13b58ec7d8dc0e07849c9f7f43a1d89dc7f50 Commit: ef30476e4dc01e0a6a2e0f280ef91119961ec815 https://github.com/Checkmk/checkmk/commit/ef30476e4dc01e0a6a2e0f280ef911199… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- ipmi: consolidate ambient temperature Change-Id: I82fcc86cfa6a26e28d17a756c503d66725801da7 Commit: 3f16a5615c525ab44aff4cb18db9093451ad4bd1 https://github.com/Checkmk/checkmk/commit/3f16a5615c525ab44aff4cb18db909345… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- ipmi: compile user defined level in advance Change-Id: I15ccb5f622ca50dcc3fafafa5eb1b09791dd8b45 Commit: 51c734a98079c2dd72ac56a97d333597d4e38382 https://github.com/Checkmk/checkmk/commit/51c734a98079c2dd72ac56a97d333597d… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- ipmi: split up large function Change-Id: I91b7b2f51d5a317891db787dc4453d21fe6d21e0 Commit: fb37c059f61884febe43d4dc24388813b1b65a56 https://github.com/Checkmk/checkmk/commit/fb37c059f61884febe43d4dc24388813b… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py M tests/unit/cmk/base/plugins/agent_based/test_ipmi.py M tests/unit/cmk/base/plugins/agent_based/utils/test_ipmi_utils.py Log Message: ----------- ipmi: simplify output structure Also delete some redundant tests. Change-Id: Iac1d1f16170a26266fcf4adadf4da907fc6bbede Commit: 8cd9addf2f3ade0cdcef26ba7e1fbc96d6daa160 https://github.com/Checkmk/checkmk/commit/8cd9addf2f3ade0cdcef26ba7e1fbc96d… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A .werks/15535 M cmk/base/plugins/agent_based/ipmi.py M cmk/base/plugins/agent_based/ipmi_sensors.py M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- 15535 IPMI sensors: Do not discover single absent sensors Change-Id: I651bd84ec2ea99b6be7cabc4c61b1ef89c106b50 Commit: 84ff3e9dfa21b97c194a1777a0f3706940deb884 https://github.com/Checkmk/checkmk/commit/84ff3e9dfa21b97c194a1777a0f370694… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py M tests/unit/cmk/base/plugins/agent_based/test_ipmi.py M tests/unit/cmk/base/plugins/agent_based/test_ipmi_sensors.py M tests/unit/cmk/base/plugins/agent_based/utils/test_ipmi_utils.py Log Message: ----------- ipmi: consolidate status evaluation Disable tests to fix them at once later. Change-Id: I2cf348f338e6f9920c02b7f03a5daa5c7ca83baf Commit: b9c4666d6367a577a4b636b3b13c0d47cd62180e https://github.com/Checkmk/checkmk/commit/b9c4666d6367a577a4b636b3b13c0d47c… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- ipmi: keep details of all subresults Change-Id: Idf7e378ff6d5ed728b1b9f80dca082761412f236 Commit: 8738f2399cdabf65e1346b0d5a0ad54e91044309 https://github.com/Checkmk/checkmk/commit/8738f2399cdabf65e1346b0d5a0ad54e9… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A .werks/15536 M cmk/base/plugins/agent_based/ipmi.py M cmk/base/plugins/agent_based/ipmi_sensors.py M cmk/base/plugins/agent_based/utils/ipmi.py M tests/unit/cmk/base/plugins/agent_based/test_ipmi.py M tests/unit/cmk/base/plugins/agent_based/test_ipmi_sensors.py M tests/unit/cmk/base/plugins/agent_based/utils/test_ipmi_utils.py Log Message: ----------- 15536 IPMI sensors: consider sensor state as reported by freeipmi Change-Id: If31e66a102f47631e1ecaddee301f3a1be2d95cf Commit: ea275a9eeb5aa4d473f3ed3020c7e9890bd63342 https://github.com/Checkmk/checkmk/commit/ea275a9eeb5aa4d473f3ed3020c7e9890… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A .werks/15264 M cmk/base/plugins/agent_based/logwatch.py M cmk/base/plugins/agent_based/logwatch_ec.py M cmk/base/plugins/agent_based/utils/logwatch.py M cmk/gui/plugins/wato/check_parameters/logwatch_ec.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch_ec.py Log Message: ----------- 15264 FIX Check plugins logwatch, logwatch_ec: Notify about unreadable log file In the Logwatch and Logwatch Event Console Forwarding Check unreadable log files (e.g. due to insufficient permssions) were previously treated the same as missing log files. With this werk, the checks will check specifically for log files that could not be read and will become {CRIT} if any are present. To configure the state for the Event Console Forwarding service when unreadable files are detected, use the option "State if a logfile cannot be read" in the rule <i>Logwatch Event Console Forwarding</i>. SUP-12770 Change-Id: I4d0186b76235396b864ceadcdecf032e45fd7e3d Commit: 2fbdc198460b62b51a00838f3c8b06c511137a5a https://github.com/Checkmk/checkmk/commit/2fbdc198460b62b51a00838f3c8b06c51… Author: Rebekka Seltmann &lt;rebekka.seltmann(a)tribe29.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A .werks/15266 M cmk/base/plugins/agent_based/logwatch_ec.py M tests/unit/cmk/base/plugins/agent_based/test_logwatch_ec.py Log Message: ----------- 15266 FIX Check plugin logwatch_ec: Improve detection of missing log files Previously the Logwatch Event Console Forwarding service would not report log files as missing that are marked as such in the agent output: F+: <<<logwatch>>> [[[logfile:missing]]] F-: This affected logfiles that were explicitly configured to be monitored, as opposed to configurations that capture multiple logfiles at once. With this werk this has been fixed. SUP-12770 Change-Id: Idfc972fce51c0bdeaaf7f73d56d38d15e59cdb34 Compare: https://github.com/Checkmk/checkmk/compare/0948de26f148...2fbdc198460b