[checkmk-commits] [Checkmk/checkmk] 83de80: Remove dependency on UserSyncBackgroundJob from cm...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 83de80e73d1932f16d8a16eb96b9569cc9a6dcc1 https://github.com/Checkmk/checkmk/commit/83de80e73d1932f16d8a16eb96b9569cc… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/userdb/__init__.py R cmk/gui/userdb/_user_sync.py A cmk/gui/userdb/_user_sync_config.py M cmk/gui/userdb/ldap_connector.py M cmk/gui/userdb/registration.py A cmk/gui/userdb/user_sync_job.py M cmk/gui/wato/pages/users.py Log Message: ----------- Remove dependency on UserSyncBackgroundJob from cmk.gui.userdb This prevents one cycle which would break the following change. Change-Id: I210e96cc294beaebda647d9c268153be49a0678f Commit: 5fb6f636ca5844aeab889299b2b6ed38811e660c https://github.com/Checkmk/checkmk/commit/5fb6f636ca5844aeab889299b2b6ed388… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/background_job/__init__.py A cmk/gui/background_job/_app.py Log Message: ----------- Introduce flask app for background jobs The most straight forward way would be to use our make_wsgi_app helper to construct a CheckmkApp as we do for regular requests. However, this is not possible because of import cycles. However, having worked a bit in that direction, it now looks like the Checkmk specific app is not really needed. Instead we now build a minimalistic job specific app, which seem to fit the needs we have in the jobs. Change-Id: If217f8701defc4442ac88deb2e140176e78ae2d7 Commit: 422cb28bb24daf9a74da1ae2688e5fbedbc2acee https://github.com/Checkmk/checkmk/commit/422cb28bb24daf9a74da1ae2688e5fbed… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/background_job/__init__.py M cmk/gui/background_job/_base.py A cmk/gui/background_job/_interface.py M cmk/gui/background_job/_process.py Log Message: ----------- Resolve cmk.gui dependency on background_job._process The `_process` module needs to call `main_modules.load_plugins` which would introduce circular dependencies with `cmk.gui`. The `_process.run_process` function is the main entry point for the subprocesses and as such not needed to be imported into `cmk.gui`. Getting rid of all dependencies on `_process` of `cmk.gui` breaks the cycle. Change-Id: Iecb9f87adb71295c217c902e5575057afa3f8c4a Compare: https://github.com/Checkmk/checkmk/compare/b5773fdebfa3...422cb28bb24d To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications