[checkmk-commits] Check_MK Git: check_mk: #2357 FIX livestatus_status: no not alarm switched off host freshness nor event handlers on CMC <= 1.2.6

Module: check_mk Branch: master Commit: fa40880161ca8615e3fd07bbeb4f66c828de33c7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fa40880161ca86… Author: Mathias Kettner &lt;mk(a)mathias-kettner.de&gt; Date: Tue Jun 23 13:35:45 2015 +0200 #2357 FIX livestatus_status: no not alarm switched off host freshness nor event handlers on CMC <= 1.2.6 CMC version 1.2.6 did not have event handlers. So they are always switched off. The check will no longer warn about this. Host freshness checking is turned off per default in OMD based installations for the Nagios core. Per default alerting this also has been disabled. --- .werks/2357 | 12 ++++++++++++ ChangeLog | 1 + checks/livestatus_status | 9 +++++++-- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/.werks/2357 b/.werks/2357 new file mode 100644 index 0000000..7dca19e --- /dev/null +++ b/.werks/2357 @@ -0,0 +1,12 @@ +Title: livestatus_status: no not alarm switched off host freshness nor event handlers on CMC <= 1.2.6 +Level: 2 +Component: checks +Compatible: compat +Version: 1.2.7i2 +Date: 1435059274 +Class: fix + +CMC version 1.2.6 did not have event handlers. So they are always switched +off. The check will no longer warn about this. Host freshness checking is +turned off per default in OMD based installations for the Nagios core. Per +default alerting this also has been disabled. diff --git a/ChangeLog b/ChangeLog index c68a070..041dc6a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -35,6 +35,7 @@ * 2221 FIX: cisco_temperature: Fixed order of device levels for some devices... * 2329 FIX: windows_intel_bonding: Fix exception in case of no existing bonding device * 2355 FIX: docsis_channels_upstream: Fix graph definitions + * 2357 FIX: livestatus_status: no not alarm switched off host freshness nor event handlers on CMC <= 1.2.6... Multisite: * 2260 Improved load time of Check_MK GUI... diff --git a/checks/livestatus_status b/checks/livestatus_status index 50d5d5f..624e41c 100644 --- a/checks/livestatus_status +++ b/checks/livestatus_status @@ -37,8 +37,8 @@ factory_settings["livestatus_status_default_levels"] = { "execute_service_checks" : 2, "accept_passive_host_checks" : 2, "accept_passive_service_checks" : 2, - "check_host_freshness" : 2, - "check_service_freshness" : 2, + "check_host_freshness" : 0, # Was in OMD the default up to now, better not warn + "check_service_freshness" : 1, "enable_event_handlers" : 1, "enable_flap_detection" : 1, "enable_notifications" : 2, @@ -100,6 +100,11 @@ def check_livestatus_status(item, params, parsed): yield 0, "Core version: %s" % status["program_version"] yield 0, "Livestatus version: %s" % status["livestatus_version"] + # In CMC <= 1.2.6 event handlers cannot be enabled. So never + # warn. + if status["program_version"].startswith("Check_MK 1.2.6"): + params["enable_event_handlers"] = 0 + settings = [ ("execute_host_checks", "Active host checks are disabled"), ("execute_service_checks", "Active service checks are disabled"),