[checkmk-commits] [Checkmk/checkmk] dbd3f4: smart_stats: Look up ATA attribute names by their ID

Branch: refs/heads/2.1.0 Home: https://github.com/Checkmk/checkmk Commit: dbd3f4632837847db7978d4dd5c37f6a759a1d24 https://github.com/Checkmk/checkmk/commit/dbd3f4632837847db7978d4dd5c37f6a7… Author: Andreas Umbreit &lt;andreas.umbreit(a)checkmk.com&gt; Date: 2023-06-02 (Fri, 02 Jun 2023) Changed paths: M cmk/base/plugins/agent_based/smart.py M tests/unit/cmk/base/plugins/agent_based/test_smart.py Log Message: ----------- smart_stats: Look up ATA attribute names by their ID The attribute names for ATA disks reported by smartutils turned out to be either not clearly defined (multiple names for the same attribute), or even plainly wrong. To avoid missing some attributes or to even report wrong data, we now look up the names of all actually used attributes by their attribute ID. Change-Id: Id0a196ce1a7663f1a236f28eaf4aeba14f4723dc Commit: bad292975682708da3fe24452be40dc40f83966e https://github.com/Checkmk/checkmk/commit/bad292975682708da3fe24452be40dc40… Author: Andreas Umbreit &lt;andreas.umbreit(a)checkmk.com&gt; Date: 2023-06-02 (Fri, 02 Jun 2023) Changed paths: M cmk/base/plugins/agent_based/smart.py M tests/unit/cmk/base/plugins/agent_based/test_smart.py Log Message: ----------- smart_stats: Distinguish "UDMA CRC Errors" from "CRC Errors" They come on the same attribute ID, but are labelled differently. Since we distinguish them with two different metrics, we should also apply this nomenclature to the check result. Change-Id: I7c9ec51d2fed9ac63105d71247c2ba1a9eb81eac Commit: 44a40d6b1c5dddc920e6a1f94ce71c726119bab6 https://github.com/Checkmk/checkmk/commit/44a40d6b1c5dddc920e6a1f94ce71c726… Author: Andreas Umbreit &lt;andreas.umbreit(a)checkmk.com&gt; Date: 2023-06-02 (Fri, 02 Jun 2023) Changed paths: A .werks/15700 Log Message: ----------- 15700 FIX smart_stats: Prevent reporting mismatched temperature value In previous versions, the smart_stats check may have reported wrong temperature values for ATA disks.<br> This lead to false-positive CRIT states in "SMART ... Stats" services. Technical background: The attribute names for ATA disks reported by smartutils turned out to be either not clearly defined (multiple names for the same attribute), or even plainly wrong. To avoid missing some attributes or to even report wrong data, we now look up the names of all actually used attributes by their attribute ID. Change-Id: Iaec5c9d32a71cdbe161ce565c26984beffd10d58 Compare: https://github.com/Checkmk/checkmk/compare/214f851271b4...44a40d6b1c5d