[checkmk-commits] 5924 Windows: Use WMI for process monitoring by default

Module: check_mk Branch: master Commit: 1e6329ceb36f0205e80597bfd020744230af85a3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1e6329ceb36f02… Author: Jukka Aro &lt;ja(a)mathias-kettner.de&gt; Date: Tue May 8 15:08:04 2018 +0200 5924 Windows: Use WMI for process monitoring by default The option use_wmi has been available as an 'experimental' feature for the section ps of the Windows agent since release 1.2.7i3. The default setting has still been to use the 'native' WinAPI for obtaining process information. As the native way seems to fail to obtain information about all desired processes at times and the WMI option seems to be working without significant problems, the default value of the option is now changed to 'yes'. --- .werks/5924 | 18 ++++++++++++++++++ agents/windows/build_version | 2 +- agents/windows/sections/SectionPS.cc | 2 +- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/.werks/5924 b/.werks/5924 new file mode 100644 index 0000000..e2705e6 --- /dev/null +++ b/.werks/5924 @@ -0,0 +1,18 @@ +Title: Windows: Use WMI for process monitoring by default +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1525784407 +Class: feature + +The option use_wmi has been available as an 'experimental' feature +for the section ps of the Windows agent since release 1.2.7i3. The +default setting has still been to use the 'native' WinAPI for obtaining +process information. As the native way seems to fail to obtain +information about all desired processes at times and the WMI option +seems to be working without significant problems, the default value of +the option is now changed to 'yes'. + + diff --git a/agents/windows/build_version b/agents/windows/build_version index 0080ae0..b912429 100644 --- a/agents/windows/build_version +++ b/agents/windows/build_version @@ -1 +1 @@ -3252 +3254 diff --git a/agents/windows/sections/SectionPS.cc b/agents/windows/sections/SectionPS.cc index 352aacb..2b07008 100644 --- a/agents/windows/sections/SectionPS.cc +++ b/agents/windows/sections/SectionPS.cc @@ -51,7 +51,7 @@ SectionPS::SectionPS(Configuration &config, Logger *logger, : Section( "ps", config.getEnvironment(), logger, winapi, std::make_unique<SectionHeader<'\t', SectionBrackets>>("ps", logger)) - , _use_wmi(config, "ps", "use_wmi", false, winapi) + , _use_wmi(config, "ps", "use_wmi", true, winapi) , _full_commandline(config, "ps", "full_path", false, winapi) {} SectionPS::process_entry_t SectionPS::getProcessPerfdata() {