[checkmk-commits] [Checkmk/checkmk] 51dfdb: Rework check_traceroute unit tests

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 51dfdbd0b04c85feff702944341f75fc73fbf203 https://github.com/Checkmk/checkmk/commit/51dfdbd0b04c85feff702944341f75fc7… Author: Joerg Herbel &lt;joerg.herbel(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M tests/unit/active_checks/test_ac_check_traceroute.py Log Message: ----------- Rework check_traceroute unit tests CMK-12029 Change-Id: I0176f34c6afd2c8820181b9fb0fe7809fa05d230 Commit: 119737acd2354c22ac89386464ddf18a4f7cd2e6 https://github.com/Checkmk/checkmk/commit/119737acd2354c22ac89386464ddf18a4… Author: Joerg Herbel &lt;joerg.herbel(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M active_checks/check_traceroute M tests/unit/active_checks/test_ac_check_traceroute.py Log Message: ----------- check_traceroute: extract buggy code into separate function CMK-12029 Change-Id: I7a7eab11d6601ab4ea4bf5b49d962c817b3b9fb6 Commit: 5ea17535402a491ae99a4b6b0a7d8de6f5cf8c68 https://github.com/Checkmk/checkmk/commit/5ea17535402a491ae99a4b6b0a7d8de6f… Author: Joerg Herbel &lt;joerg.herbel(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: A .werks/15735 M active_checks/check_traceroute M tests/unit/active_checks/test_ac_check_traceroute.py Log Message: ----------- 15735 FIX <tt>check_traceroute</tt>: Fix checking of routers specified by domain name CMK-12029 Change-Id: I4bbf96b36dcccabef168973f0777e1aa8c84f690 Commit: 5240b1229af45cbae6ba4cda66084c56782719be https://github.com/Checkmk/checkmk/commit/5240b1229af45cbae6ba4cda66084c567… Author: Benedikt Seidl &lt;benedikt.seidl(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/valuespecs/test_vs_metricname.py Log Message: ----------- Don't allow empty values for MetricName This was introduced with Change-Id: Ibb64ac3f37aa51c530ebbb76745a70ee660ec8da AjaxDropdownChoice does not validate the value with the regex if the value is an empty string. CMK-13161 Change-Id: I66c4abbeab0497648d3f258edff7852e8e438f85 Commit: 66ea4476dd478941f70567800600bc16405f667a https://github.com/Checkmk/checkmk/commit/66ea4476dd478941f70567800600bc164… Author: René Slowenski &lt;rene.slowenski(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M tests/gui_e2e/test_signature_keys_for_signing_agents.py Log Message: ----------- xfailed flaky "test_bake_and_sign_disabled" xfailed for investigation to make the test more reliable Change-Id: I113109fae494aca0511c15be3d529e68eda4bf48 Commit: 5d87a2e408ccbba42e1f7ff96b85d53d30121a55 https://github.com/Checkmk/checkmk/commit/5d87a2e408ccbba42e1f7ff96b85d53d3… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/plugins/agent_based/utils/ipmi.py Log Message: ----------- add docstring Change-Id: I298b34205da5b55d90f5843a90cdc01163cfc768 Commit: fade158c969f9e0b088264a2e365ea071340ce6f https://github.com/Checkmk/checkmk/commit/fade158c969f9e0b088264a2e365ea071… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/_host_labels.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/agent_based/discovery/utils.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py Log Message: ----------- discovery: move computation of kept elements Change-Id: Ia74f43ed01ddef37b48723e149d23efd772d0107 Commit: 857538cf130c6df8c62fb26fdac01e4782cadec1 https://github.com/Checkmk/checkmk/commit/857538cf130c6df8c62fb26fdac01e478… Author: Moritz Kiemer &lt;moritz.kiemer(a)checkmk.com&gt; Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M cmk/base/agent_based/discovery/_discovered_services.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/_host_labels.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/agent_based/discovery/utils.py M cmk/checkers/discovery/_autochecks.py M cmk/utils/labels.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py M tests/unit/cmk/base/agent_based/discovery/test_discovery_utils.py Log Message: ----------- discovery: towards correct classification Change the passed key function into a required method. It will ease the change when we finally correctly deal with changed elements. Note that the change in one test is necessary, because it was passing the wrong function. Change-Id: I2f7dcc31a8a4cbf646bd974fa80ed04ec2c92e5f Compare: https://github.com/Checkmk/checkmk/compare/82a64d315ac5...857538cf130c