[checkmk-commits] [tribe29/checkmk] ba9c88: IPMI data source: remove dead code

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ba9c88f793a3d0736790d6ef9a5c77fab1ec41c2 https://github.com/tribe29/checkmk/commit/ba9c88f793a3d0736790d6ef9a5c77fab… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py Log Message: ----------- IPMI data source: remove dead code CMK-4143 Change-Id: Ie38efc41083ee8fdad854536eb7b1e57fe13faac Commit: f9f6c76b6c0f8ac1a105313c336d342221172368 https://github.com/tribe29/checkmk/commit/f9f6c76b6c0f8ac1a105313c336d34222… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py M tests-py3/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py Log Message: ----------- Extract IPMIDataFetcher class CMK-4143 Change-Id: Iae79bf0be1be7ec0581cae3298f4c56ca9fb005b Commit: 62cd3e1cf491e0fc3b5eb6b11d59c15bc68c5948 https://github.com/tribe29/checkmk/commit/62cd3e1cf491e0fc3b5eb6b11d59c15bc… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py M tests-py3/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py Log Message: ----------- Free IPMI sensor reading parser The function already is independent from the class as it does not use any of its fields. So we take it out of the way. CMK-4143 Change-Id: I3af77547264cc1bb297b944ea934b583a9650265 Commit: b49f005faf9d5994e20accdce529f5ccfeb23d6f https://github.com/tribe29/checkmk/commit/b49f005faf9d5994e20accdce529f5ccf… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py Log Message: ----------- Make IPMIDataFetch a class again Create a few useful fields and remove the "staticmethod" decorators. Also, the tighter focus of the class allows us to shorten the name of the methods. For example, a class called IPMI*Fetcher does not need to prefix its methods with `fetch_ipmi`, etc. We are getting somewhere. The only thing missing is a context manager that allows us to simplifies and disentangle IPMIDataFetcher.data() Also: Do not build strings before passing them to the logger. CMK-4143 Change-Id: Ia6e4b69a5b557a8e8b4ae4907715f982bf4a9365 Commit: 024529d84a7b19d74e3b92ad17d7d9486d704364 https://github.com/tribe29/checkmk/commit/024529d84a7b19d74e3b92ad17d7d9486… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-02 (Thu, 02 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py Log Message: ----------- Make IPMIDataFetcher a context manager This allows us to split the three responsibilities of the `data()` method: - connection handling - actually obtaining the data from the connection - error handling into three distinct methods. This further localizes and simplifies the error handling. CMK-4143 Change-Id: Ic051d9097053cd7b1f29a6d59a8d3912bb9e94c9 Compare: https://github.com/tribe29/checkmk/compare/9c84cc3429f0...024529d84a7b