[checkmk-commits] [Checkmk/checkmk] 8b8d74: Some typing improvements

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 8b8d74de10bd786cd41e7a756400f76440b83523 https://github.com/Checkmk/checkmk/commit/8b8d74de10bd786cd41e7a756400f7644… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/timeseries.py M cmk/utils/prediction.py M tests/unit/cmk/utils/test_prediction_commons.py Log Message: ----------- Some typing improvements CMK-13561 Change-Id: I8a7757cfc9008c45f495b58c65302563550ee917 Commit: 8856aa8c4e41ada08277a96fea50fc03cf0a819d https://github.com/Checkmk/checkmk/commit/8856aa8c4e41ada08277a96fea50fc03c… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/views/data_source/livestatus.py M cmk/gui/views/painter/v0/base.py Log Message: ----------- Add common base class for historic and forecast painters for metrics This allows for typing the shared functionality. CMK-13561 Change-Id: I504f3def08d6abbc98a73d310eaf3a6916d410a0 Commit: 3ae74c2299b90b4f464253cfd2b40932de7a53f7 https://github.com/Checkmk/checkmk/commit/3ae74c2299b90b4f464253cfd2b40932d… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Re-work functionality for handling rrd data relevant for a single metric The current implementation is conceptually wrong: Currently, we scale the rrd data right when fetching it via livestatus. This is wrong because we can only know if we should apply any scalings in the context of a service (since our metric translations are check-plugin specific). Example: Let's say we want historic values for the metric mem_total. Outside the service context, we cannot know whether or not we should scale this metric by 1024**2 (Windows: yes, Linux: no). This issue affects certain painters and the single-metric dashlets. (though most of the latter, namely the ones where the host and service are fixed, could be re-implemented to completely avoid this issue, which is however outside the scope of this change). Note that eg. service graphs are not affected, because we are in the context of a service when rendering them. This change leads to some duplicated code, however, this simplifies the review. In the following commit, we will switch from the old to the new functionality and then remove the old code. CMK-13561 Change-Id: I0e177242d58c4d39e268db37c4c42df37bfec9a9 Commit: c818478b2af179130cba19f1a182aab04d09efc7 https://github.com/Checkmk/checkmk/commit/c818478b2af179130cba19f1a182aab04… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A .werks/15854 Log Message: ----------- 15854 FIX Fix metric scaling issues in views and dashboards CMK-13555 CMK-13561 Change-Id: I12e04ceec103b6d2c3b06c447ec0a5cffdae7be9 Commit: 33feb1a9ed28d6140f15014f2a5f18188b16872b https://github.com/Checkmk/checkmk/commit/33feb1a9ed28d6140f15014f2a5f18188… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M cmk/gui/plugins/metrics/rrd_fetch.py M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py M tests/unit/cmk/gui/plugins/metrics/test_rrd_fetch.py Log Message: ----------- Remove now unused code Change-Id: Id9670ca97b3408ee137eeda94398b63f17e5b2e1 Commit: 1b0e154df96ebc3ca7d4875db4c2ac8afcb57484 https://github.com/Checkmk/checkmk/commit/1b0e154df96ebc3ca7d4875db4c2ac8af… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: R cmk/utils/memoize.py M tests/code_quality/test_werks.py R tests/unit/cmk/utils/test_memoize.py Log Message: ----------- Replace cmk.utils.memoize.MemoizeCache -> functools.lru_cache Also remove the former. Change-Id: I4251983aa1aff23659d2e4051999723c1cf67815 Compare: https://github.com/Checkmk/checkmk/compare/1629face7e6c...1b0e154df96e