[checkmk-commits] [Checkmk/checkmk] f0f142: Handover CIPARAM_OVERRIDE_BUILD_NODE to upstream b...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: f0f14288d0a965c447bef05f06fb0a456f72f030 https://github.com/Checkmk/checkmk/commit/f0f14288d0a965c447bef05f06fb0a456… Author: Jonas Scharpf <jonas.scharpf(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M buildscripts/scripts/test-integration-single-f12less.groovy Log Message: ----------- Handover CIPARAM_OVERRIDE_BUILD_NODE to upstream build ... in test-integration-single-f12less See 2024-08-22 Post Mortem: red composition tests due to linker errors Change-Id: I2eb8694e0d1c4e644f73eb1592f942cb9d20198f Commit: ac9dbba0df18382623699dd52fdb5cb13eebc092 https://github.com/Checkmk/checkmk/commit/ac9dbba0df18382623699dd52fdb5cb13… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/gui_e2e/test_services.py M tests/testlib/playwright/helpers.py M tests/testlib/playwright/pom/change_password.py M tests/testlib/playwright/pom/dashboard.py M tests/testlib/playwright/pom/login.py M tests/testlib/playwright/pom/monitor/host_search.py M tests/testlib/playwright/pom/monitor/host_status.py M tests/testlib/playwright/pom/monitor/service_search.py M tests/testlib/playwright/pom/page.py M tests/testlib/playwright/pom/setup/add_rule_periodic_discovery.py M tests/testlib/playwright/pom/setup/global_settings.py M tests/testlib/playwright/pom/setup/host_effective_parameters.py M tests/testlib/playwright/pom/setup/hosts.py M tests/testlib/playwright/pom/setup/ruleset.py M tests/testlib/playwright/pom/werks.py Log Message: ----------- gui-e2e: use method `click_dropdown_menu_item` like a Checkmk UI user. New `abtractmethod` added within `CmkPage`. Method `click_dropdown_menu_item` had `menu_id` as input arguemnt. `menu_id` cannot be perceived by the UI user. Thus, added a level of code abstraction using + `CmkPage::__init__`, + `CmkPage::_dropdown_menu_name_to_id` (abstractmethod) + `MainArea::__init__` to keep the usage of framework code as similar as possible to UI interactions on Site. Minor changes + removed redundant code + rename `click_dropdown_menu_item` > `click_item_in_dropdown_list` Following UX terminology in naming methods. Change-Id: Idc969e4dfc35de2df9e3cc0b1a3f2902a7398de9 Commit: 84f23bf75765f7047a6854078f3b6afc156ddf18 https://github.com/Checkmk/checkmk/commit/84f23bf75765f7047a6854078f3b6afc1… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/conftest.py M tests/integration/checks/test_checks_sanity.py M tests/scripts/agent_controller_daemon.py M tests/testlib/agent.py Log Message: ----------- Fix system tests when run as testuser Basic changes to prepare the user mode execution of the system test suites. Most importantly, the agent controller is refactored to allow the execution as an external process via sudo. Change-Id: I68b9937b02887f70dd88b87896f80b9246820930 Commit: b892d3cb6fb8133c50d178ade72155dc7aa33fa5 https://github.com/Checkmk/checkmk/commit/b892d3cb6fb8133c50d178ade72155dc7… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/agents/test_cmk_agent_ctl.py M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py M tests/scripts/agent_controller_daemon.py M tests/testlib/agent.py M tests/testlib/containers.py M tests/testlib/site.py Log Message: ----------- testlib.containers: Run tests as testuser The dockerized tests have been run as user root so far, which caused some trouble like raising several MKGeneralException errors when running the unit tests and is generally not recommended for any integration and system tests. This change fixes that by running the tests as testuser and making the necessary adaptions to make this work. Change-Id: I28be44ec305693e7c2e2e3e9a521d17f5c29348d Commit: dbdd2d4f51bdb393c2d83e405cbbb62f53d9f6e8 https://github.com/Checkmk/checkmk/commit/dbdd2d4f51bdb393c2d83e405cbbb62f5… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/testlib/containers.py Log Message: ----------- testlib.containers: Enter debug mode as user Change-Id: Ic9005b29bf612e0d09634c2c57ff3967b4271568 Commit: b1a634e9e2392f1ca18bbdb1204dd85cab85de3e https://github.com/Checkmk/checkmk/commit/b1a634e9e2392f1ca18bbdb1204dd85ca… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py M tests/composition/controller_site_interactions/test_register_workflow.py M tests/composition/test_automatic_host_removal.py M tests/composition/utils.py Log Message: ----------- composition test: Fix logger definition "logger" is not a constant, so it should be lowercased. Also we should not do relative imports. Change-Id: Ia65331c51296e2d91bba67c5798656a06e1b3db0 Commit: 4f247b685e953e1ad889e571a5b48266a587564f https://github.com/Checkmk/checkmk/commit/4f247b685e953e1ad889e571a5b48266a… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/test_automatic_host_removal.py Log Message: ----------- composition test: Fix test_automatic_host_removal assertion The assertion in the automatic_host_removal test was not very specific and technically even wrong, because it assumed that no hosts have to exist for the test to pass, while only two specific unresolvable test hosts should be removed (any other hosts are irrelevant). This change adds a more specific assertion to check only for the removal of the unresolvable test hosts. Change-Id: Ieb20d3d5de8b48953f00c9ebba3d05d2f5179839 Commit: 764975ff75e3e2e9689a8d309919d8caac857878 https://github.com/Checkmk/checkmk/commit/764975ff75e3e2e9689a8d309919d8caa… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/conftest.py Log Message: ----------- composition test: Rescoped site fixtures Change-Id: I23d0b5c92215cb8c3d6561f2f294f5913d56e9fe Commit: 5fdd0da7514e57c7d396195f1712d4097f57ffa0 https://github.com/Checkmk/checkmk/commit/5fdd0da7514e57c7d396195f1712d4097… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/testlib/utils.py Log Message: ----------- testlib.utils.run: Allow passing **kwargs For more advanced operations (like passing input) we need to be able to pass on kwargs to subprocess.run(). This change allows that and also makes sure that stdin is not defined if "input" is given. Change-Id: Ia95dfd1c6cb2dffa546d25196d927d6cdea48427 Commit: 08d0f3c5efe17e0f59264ddc38f876f752840344 https://github.com/Checkmk/checkmk/commit/08d0f3c5efe17e0f59264ddc38f876f75… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/testlib/agent.py Log Message: ----------- testlib.agent: Improve debug ouput in wait_until_host_receives_data() Change-Id: I7dafb027784677a6dabef1b4f4af14c67c2f5e6f Commit: b2b4e6ee8cfc5ff08e2260cf5ba56fc423605b2e https://github.com/Checkmk/checkmk/commit/b2b4e6ee8cfc5ff08e2260cf5ba56fc42… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/testlib/agent.py Log Message: ----------- testlib.agent: Add controller_connection_json() Add helper to get specific site connection details from provided controller_status. Change-Id: Ia19730bd2ecef678e40b05dc880bfc38f0946e95 Commit: acce25e9fcf776c0056b300342375dd9f550a1bf https://github.com/Checkmk/checkmk/commit/acce25e9fcf776c0056b300342375dd9f… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/testlib/agent.py Log Message: ----------- testlib.agent: Clean up in initially in register_controller() Change-Id: I759f0435cfa2194953ec0353c3e2a552620e17e1 Commit: e961ea7504fe90f57a5419dd72c3b3333ebdf386 https://github.com/Checkmk/checkmk/commit/e961ea7504fe90f57a5419dd72c3b3333… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py M tests/composition/controller_site_interactions/test_register_workflow.py M tests/composition/controller_site_interactions/test_rename_preserves_registration.py M tests/composition/controller_site_interactions/test_status.py M tests/composition/test_automatic_host_removal.py M tests/testlib/agent.py Log Message: ----------- composition test: Cleanup for user mode+single site execution The user mode execution and the single site execution revealed additional design flaws in the composition test logic, including unspecific assertions. This change should fix those flaws. Change-Id: Iac02261df9ee0465df479b63235ff216ebbc026a Commit: 4423b53f2482f6c049d63d897980e8b289d76bf1 https://github.com/Checkmk/checkmk/commit/4423b53f2482f6c049d63d897980e8b28… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/controller_site_interactions/test_rename_preserves_registration.py M tests/composition/controller_site_interactions/test_status.py M tests/testlib/agent.py Log Message: ----------- testlib.agent: Assert response in controller_connection_json() Instead of doing generic assertions about the response structure for controller_connection_json in all tests, this change adds such assertions to the helper directly, so only specific field values need to be asserted, not the general response structure. All changes below tests/composition are to reduce code duplication by adapting the existing assertions. Change-Id: Iddc70f2db487444d09b5ba91a940a48cb0f2d5a8 Commit: 15cf01af16ca5b4511035b4a0a4a457f44d1f171 https://github.com/Checkmk/checkmk/commit/15cf01af16ca5b4511035b4a0a4a457f4… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py M tests/scripts/agent_controller_daemon.py M tests/testlib/agent.py Log Message: ----------- testlib.agent: Fix initialisation and teardown Also remove useless "delete-all" calls since registration cleanup is done in the agent controller wrapper script already. Avoid shell mode to ensure proper teardown Change-Id: I633a8934dbbda84d02e1caed4a376f82e4b6887c Commit: a7746a2c6e88130fcfe918ed4f7f02a89c59d77b https://github.com/Checkmk/checkmk/commit/a7746a2c6e88130fcfe918ed4f7f02a89… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/controller_site_interactions/test_register_workflow.py M tests/composition/controller_site_interactions/test_rename_preserves_registration.py M tests/composition/controller_site_interactions/test_status.py Log Message: ----------- composition test: agent_ctl / ctl_path cleanup To avoid confusion, this change renames agent_ctl to ctl_path wherever we do not make use of the fixture but only refer to the controller path. Change-Id: I742afb211046000a9378fc0e027c23f7bb3d1fc8 Commit: a30a0812bb30d3896fcd8d4b0b95da1e221c7782 https://github.com/Checkmk/checkmk/commit/a30a0812bb30d3896fcd8d4b0b95da1e2… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/utils.py Log Message: ----------- composition test: Make bake_agent more reliable The bake_agent helper could only work if the test host it used did not exist already. This change makes sure the test host is dropped and re-created if it exists to make the helper more reliable. Change-Id: Ifce402f6304065a9371bef2254cc10792747855a Commit: 8a115a5da826d2b4cbaa9bc378099642ca97346f https://github.com/Checkmk/checkmk/commit/8a115a5da826d2b4cbaa9bc378099642c… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/controller_site_interactions/test_proxy_register_import_workflow.py Log Message: ----------- composition test: Use sudo=True instead of sudo command Change-Id: I7aec48d3fd522e64e3edb477b9189647e742fedd Commit: 8b7c911dc06c03e77b03b2171e9a883032a54b51 https://github.com/Checkmk/checkmk/commit/8b7c911dc06c03e77b03b2171e9a88303… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-08-23 (Fri, 23 Aug 2024) Changed paths: M tests/composition/test_automatic_host_removal.py Log Message: ----------- xfail test_automatic_host_removal on centos-8 and almalinux-9 CMK-18738 Change-Id: I49ec9d85b5c193e61e80d104644321f3f727c3ed Compare: https://github.com/Checkmk/checkmk/compare/6e7239d1ce32...8b7c911dc06c To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications