[checkmk-commits] [tribe29/checkmk] 9de919: view.py: isolate tests better

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9de919482ecd0d8cac29adbe7c6c8eb7b5c9697c https://github.com/tribe29/checkmk/commit/9de919482ecd0d8cac29adbe7c6c8eb7b… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-12-14 (Mon, 14 Dec 2020) Changed paths: M tests/unit/cmk/gui/test_views.py Log Message: ----------- view.py: isolate tests better Change-Id: I81a7ad3c67045521d3b937640fe1566e1a354a17 Commit: 96c82f8f9ce509dfafa6659bc4d581fbf6bf2363 https://github.com/tribe29/checkmk/commit/96c82f8f9ce509dfafa6659bc4d581fbf… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-14 (Mon, 14 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M cmk/base/checkers/programs.py M cmk/base/checkers/tcp.py M cmk/base/config.py M cmk/utils/type_defs/_misc.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_tcp_data_source.py Log Message: ----------- Agent: Do not magically spawn values from config Relying on side effects from global values is confusing and obscure the real purpose of the functions and classes. For example here, passing `agent_min_version` together with `agent_target_version` explicits an important part of the functionality of a summarizer. Passing a `simulation` flag is also consistent with other helpers where this is used. This further severes artificial dependencies and makes the code testable. Change-Id: Ibd31de872901257aeeb04502b4dd00127a037e2e Compare: https://github.com/tribe29/checkmk/compare/1f0367a44662...96c82f8f9ce5