21 Dec
2022
21 Dec
'22
1:33 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 873beb60701d7ae7360cb5516a83cf970d87ce59
https://github.com/tribe29/checkmk/commit/873beb60701d7ae7360cb5516a83cf970…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2022-12-21 (Wed, 21 Dec 2022)
Changed paths:
M cmk/gui/watolib/search.py
Log Message:
-----------
Typing improvement
Change-Id: I4c2c34d341942df51ef9d27d50c8e98c7c2dda12
Commit: 156bcf1ea389df99812e05a2ed46cb11dcfbe03c
https://github.com/tribe29/checkmk/commit/156bcf1ea389df99812e05a2ed46cb11d…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2022-12-21 (Wed, 21 Dec 2022)
Changed paths:
M cmk/gui/plugins/sidebar/search.py
Log Message:
-----------
Sidebar search: Evaluate search results per topic (iterable) only once
This was not an issue up to now because we used lists internally, which
is about to change for the Setup search however.
CMK-11765
Change-Id: I1fe78f0797837f5ade4851ef9097bacb29de304d
Commit: f3365beb30ebfd2f6d1618910ca74b1801147264
https://github.com/tribe29/checkmk/commit/f3365beb30ebfd2f6d1618910ca74b180…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2022-12-21 (Wed, 21 Dec 2022)
Changed paths:
M cmk/gui/plugins/sidebar/search.py
M cmk/gui/watolib/search.py
M tests/unit/cmk/gui/watolib/test_watolib_search.py
Log Message:
-----------
Setup search: Separate search in Redis from permissions check
Searching in Redis is fast, but checking if the current user is allowed
to see the individual results can be slow (might involve rendering a
full page). Therefore, we separate these two steps and do the
permissions check in a generator function. This way, the code rendering
the results can request as many results as it wants to display only,
thus avoiding the permissions check for all results.
CMK-11765
Change-Id: I87a5643c47583d7b5fe30a14c963496c6199c7ab
Commit: e33c51949d801bda4e1461d37d155b8bc5a53096
https://github.com/tribe29/checkmk/commit/e33c51949d801bda4e1461d37d155b8bc…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2022-12-21 (Wed, 21 Dec 2022)
Changed paths:
A .werks/15043
M cmk/gui/plugins/sidebar/search.py
M web/htdocs/themes/facelift/scss/_mega_menu.scss
Log Message:
-----------
15043 Setup search: Limit number of results per topic to 80
This is consistent with the Quicksearch default settings and might speed
up the Setup search in certain cases. In case more results are
available, a corresponding message is shown to the user.
Note that the Monitor search already has an implicit limit, namely the
limit of the Quicksearch (configurable via global settings). However,
this limit works fundamentally differently (it limits the overall number
of results across all topics). Therefore, in the current state, we do
not know if there are more results available for a given topic. Hence,
we currently cannot display any message concerning more results after
pressing `Show all results` in the Monitor menu.
CMK-11765
Change-Id: I7e44deb4ddd3d0f4ac225c2d0cc1d09e81d74730
Commit: 65f90a2a6567575f248a176c55a24792790fc2a7
https://github.com/tribe29/checkmk/commit/65f90a2a6567575f248a176c55a247927…
Author: Ronny Bruska <ronny.bruska(a)tribe29.com>
Date: 2022-12-21 (Wed, 21 Dec 2022)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Adjust ContactGroupChoice
CMK-9684
Change-Id: I8c3b7922db6b449e1103581a578febfa3b8a677c
Compare: https://github.com/tribe29/checkmk/compare/eddbbfe28476...65f90a2a6567