19 May
2022
19 May
'22
6:43 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: f670f20aa19bc8e66d44bff0db827a7717c4d206
https://github.com/tribe29/checkmk/commit/f670f20aa19bc8e66d44bff0db827a771…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-05-19 (Thu, 19 May 2022)
Changed paths:
M cmk/gui/backup.py
M cmk/gui/key_mgmt.py
M cmk/gui/logwatch.py
M cmk/gui/page_menu.py
M cmk/gui/pagetypes.py
M cmk/gui/plugins/sidebar/wato.py
M cmk/gui/plugins/visuals/filters.py
M cmk/gui/plugins/wato/bi_config.py
M cmk/gui/plugins/wato/utils/html_elements.py
M cmk/gui/plugins/wato/utils/simple_modes.py
M cmk/gui/sidebar/__init__.py
M cmk/gui/sidebar/main_menu.py
M cmk/gui/type_defs.py
M cmk/gui/user_message.py
M cmk/gui/valuespec.py
M cmk/gui/views/availability.py
M cmk/gui/visuals.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/wato/pages/activate_changes.py
M cmk/gui/wato/pages/audit_log.py
M cmk/gui/wato/pages/check_catalog.py
M cmk/gui/wato/pages/custom_attributes.py
M cmk/gui/wato/pages/global_settings.py
M cmk/gui/wato/pages/groups.py
M cmk/gui/wato/pages/icons.py
M cmk/gui/wato/pages/ldap.py
M cmk/gui/wato/pages/notifications.py
M cmk/gui/wato/pages/roles.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/sites.py
M cmk/gui/wato/pages/tags.py
M cmk/gui/wato/pages/timeperiods.py
M cmk/gui/wato/pages/user_profile/two_factor.py
M cmk/gui/wato/pages/users.py
Log Message:
-----------
Simplify CSSSpec, part 1.
A single str is just a shorthand for a singleton list, nuke the former.
Allowing a ton of "convenient" shorthands is a bad design principle when a
single general way of expressing things exists. Trading a few keystrokes
during the initial development for a ton of complexity later (like
incomprehensible types, lots of dispatching code scattered all around, etc.)
is a fundamental misconception about what is "easy" and/or
"convenient".
But the real "fun stuff" is mixing various overlapping Unions into one, see
e.g. HTMLTagAttributeValue. This makes dispatching later basically
impossible or nonsensical (choose one!).
Change-Id: Ib9488dae67848c513a4507c018e37b1591478f12
Commit: cc615eeb05312c9273a16583e8e2507060865fc6
https://github.com/tribe29/checkmk/commit/cc615eeb05312c9273a16583e8e250706…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2022-05-19 (Thu, 19 May 2022)
Changed paths:
M cmk/gui/htmllib/html.py
M cmk/gui/page_state.py
M cmk/gui/table.py
M cmk/gui/type_defs.py
M cmk/gui/valuespec.py
Log Message:
-----------
Simplify CSSSpec, part 2.
None is just a shorthand for an empty list, nuke the former.
Note that we can nuke quite a few of the newly introduced Optionals later
when we use Sequence instead of list, i.e. when we get the variance right.
Change-Id: I6b103c5f51f749c2d37120787c4699dbfc845ee4
Compare: https://github.com/tribe29/checkmk/compare/26c3413e3589...cc615eeb0531