31 Aug
2020
31 Aug
'20
1:32 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: c2bae1a1b94535ad8db2bfadfdb44c996831bdbf
https://github.com/tribe29/checkmk/commit/c2bae1a1b94535ad8db2bfadfdb44c996…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-31 (Mon, 31 Aug 2020)
Changed paths:
M cmk/base/automations/check_mk.py
M cmk/base/data_sources/snmp.py
M cmk/base/modes/check_mk.py
M cmk/fetchers/factory.py
M cmk/fetchers/snmp.py
M cmk/snmplib/type_defs.py
M tests/unit/cmk/fetchers/test_classic_snmp.py
M tests/unit/cmk/lib/test_snmplib_snmp_scan.py
M tests/unit/cmk/lib/test_snmplib_snmp_table.py
Log Message:
-----------
Use logger in SNMP backends
Executing the SNMP fetcher with increased log level resulted in a
terminated fetcher because it produced some output using console.verbose
and console.vverbose which broke the core / fetcher protocol. This
resulted in the following errors in the cmc.log:
===
2020-08-31 10:36:28 [7] [fetcher pool scheduler] unscheduling service
"snmp;Check_MK" at 2020-08-31 10:36:28
2020-08-31 10:36:28 [6] [fetcher pool] [fetcher pool 128944] Execute data source
2020-08-31 10:36:28 [7] [fetcher pool] [fetcher pool 128944] hr_cpu: Fetching data
2020-08-31 10:36:28 [2] [fetcher pool] [fetcher pool 128944] Unsupported protocol in
fetcher header: 'Executing BULKWALK of ".1.3.6.1.'
2020-08-31 10:36:28 [2] [fetcher pool] [fetcher pool 128944] cannot read fetcher header:
Bad message
2020-08-31 10:36:28 [7] [fetcher pool scheduler] scheduling service
"snmp;Check_MK" at 2020-08-31 10:37:28
2020-08-31 10:36:29 [5] [fetcher pool] [fetcher pool 128944] aborting running fetcher:
2020-08-31 10:36:29 [7] [fetcher pool] [fetcher pool 128944] waiting for termination
2020-08-31 10:36:29 [5] [fetcher pool] [fetcher pool 128944] terminated
2020-08-31 10:36:29 [5] [fetcher pool] [fetcher pool 130049] started, commandline:
/omd/sites/heute/bin/fetcher
===
This commit adds loggers to the SNMP backends and changes all output to
use the logger. This makes the fetchers automatically handle the output
correctly.
Change-Id: I86d014e2ca30686bf5f87f98c46ac350f071cfe6