18 Feb
2020
18 Feb
'20
11:31 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 1455087dbb6a90ad9b00e0028376795bd2a4f593
https://github.com/tribe29/checkmk/commit/1455087dbb6a90ad9b00e0028376795bd…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-02-18 (Tue, 18 Feb 2020)
Changed paths:
M cmk/gui/htmllib.py
M tests/unit/cmk/gui/test_htmllib_input_vars.py
Log Message:
-----------
htmllib: Clarify API for getting request parameters 1/2
Previously we used the following methods:
html.request.var
html.get_unicode_input
html.get_ascii_input
html.get_integer_input
These were inconsistent in different ways. E.g. html.get_integer_input
required an argument to be mandatory, while the others did not.
We had a lot of subtle bugs, because the methods could all return
None in case an argument was not set.
A huge number of the call sites were validating the mandatory arguments
individually, often in subtle different ways.
Now we have changed the API to be like this:
html.get_unicode_input
html.get_unicode_input_mandatory
html.get_str_input
html.get_str_input_mandatory
html.get_ascii_input
html.get_ascii_input_mandatory
html.get_integer_input
html.get_integer_input_mandatory
The regular input methods return None or the given deflt value in case
the request variable is not set.
The _mandatory input methods raise an MKUserError exception in case
the request variable is not set.
Once we moved to Python 3, get_unicode_input* and get_str_input* can
be merged.
Change-Id: I24906b3b470fde839b703f92e86d3a25d06c8487
Commit: ad51d8db800dac5ebc242391702fc2760ddb5418
https://github.com/tribe29/checkmk/commit/ad51d8db800dac5ebc242391702fc2760…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-02-18 (Tue, 18 Feb 2020)
Changed paths:
M cmk/gui/dashboard.py
M cmk/gui/htmllib.py
M cmk/gui/plugins/metrics/html_render.py
M cmk/gui/plugins/visuals/utils.py
M cmk/gui/plugins/wato/bi.py
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/valuespec.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/wato/pages/analyze_configuration.py
M cmk/gui/wato/pages/ldap.py
M cmk/gui/wato/pages/notifications.py
M cmk/gui/wato/pages/tags.py
M cmk/gui/werks.py
M tests/unit/cmk/gui/test_htmllib_input_vars.py
M tests/unit/cmk/gui/test_http.py
Log Message:
-----------
htmllib: Clarify API for getting request parameters 2/2
Move get_integer_input to new scheme
Change-Id: I98162e5990d3ea24e553dd9e2e7abc1390fde85a
Compare: https://github.com/tribe29/checkmk/compare/a692f1c828fd...ad51d8db800d