[checkmk-commits] Classified the remaining warnings.

Module: check_mk Branch: master Commit: f645915e8f69fe756031a98487638f61edd4ae2e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f645915e8f69fe… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Jul 27 13:28:39 2018 +0200 Classified the remaining warnings. Change-Id: Iccb49e3358b3d1ddb7da0a66af4180a5ad069fc7 --- tests/pylint/pylintrc | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc index 37bf8c1..afc75db 100644 --- a/tests/pylint/pylintrc +++ b/tests/pylint/pylintrc @@ -12,11 +12,6 @@ extension-pkg-whitelist=rrdtool,_ldap,netifaces,pymssql [MESSAGES CONTROL] disable= - inconsistent-return-statements, - missing-docstring, - no-else-return, - no-self-use, - protected-access, #--------------------------------------------------------------------------- # We should really enable this, there could be some real exceptions waiting # to be thrown. But some work is needed first to sprinkle abc annotations @@ -57,6 +52,14 @@ disable= broad-except, #--------------------------------------------------------------------------- # Enabling this would enhance readability quite a bit and it might even + # uncover bugs. Fixing this is not rocket science, just some work. + inconsistent-return-statements, + #--------------------------------------------------------------------------- + # Enabling this warning would be nice, it is mostly a sign of sloppy + # programming practice. In some cases, they can even hide bugs. + no-else-return, + #--------------------------------------------------------------------------- + # Enabling this would enhance readability quite a bit and it might even # uncover bugs. Fixing this is not rocket science, just some work: Roughly # 400 warnings in about 60 modules, but this can be fixed step by step. redefined-outer-name, @@ -66,6 +69,15 @@ disable= # this. redefined-builtin, #--------------------------------------------------------------------------- + # Enabling this would be nice, but not crucial. Nevertheless, this would + # improve readability and involve some cleanups in our class hierarchy, so + # we should do this some day. + protected-access, + #--------------------------------------------------------------------------- + # Enabling this would be nice, but not crucial. At the moment, we have quite + # a few violations, so we postpone fixing this. + no-self-use, + #--------------------------------------------------------------------------- # Enabling this would be nice, but not crucial. At the moment, we have quite # a few violations (about 220 in roughly 40 modules), so we postpone fixing # this. Note that due to our arcane use of types, we need to be very careful @@ -133,6 +145,9 @@ disable= bad-whitespace, line-too-long, #--------------------------------------------------------------------------- + # We are light years away from enabling this... + missing-docstring, + #--------------------------------------------------------------------------- # Enabling the two spelling-related checks increases pylints runtime from # 11 min to 40 min, so we better keep those disabled for normal runs. # wrong-spelling-in-comment,