[checkmk-commits] [tribe29/checkmk] a366cb: Cleanup tests directory from sys.path

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a366cb3179ed04f42b706a7b3b466f7307c99956 https://github.com/tribe29/checkmk/commit/a366cb3179ed04f42b706a7b3b466f730… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-28 (Wed, 28 Jul 2021) Changed paths: M .pylintrc M scripts/run-mypy A tests/__init__.py M tests/agent-integration/test_plugin_version_compatibility.py M tests/composition/conftest.py M tests/conftest.py M tests/docker/test_docker.py M tests/gui_crawl/test_gui_crawl.py M tests/integration/bin/test_mkbackup.py M tests/integration/cmk/base/test_automations.py M tests/integration/cmk/base/test_check_variables.py M tests/integration/cmk/base/test_discovery_parameters.py M tests/integration/cmk/base/test_modes.py M tests/integration/cmk/base/test_services_prediction.py M tests/integration/cmk/ec/test_mkeventd_status.py M tests/integration/cmk/gui/test_login.py M tests/integration/cmk/gui/test_webapi.py M tests/integration/cmk/lib/snmplib/conftest.py M tests/integration/conftest.py M tests/integration/core/test_active_checks.py M tests/integration/livestatus/test_livestatus.py M tests/integration/notifications/test_simple_rbn.py M tests/integration/notifications/test_unreachable_notifications.py M tests/integration/omd/test_web_access.py M tests/pylint/test_pylint.py M tests/scripts/install-cmk.py M tests/scripts/run-dockerized.py M tests/scripts/run-integration-test.py M tests/testlib/__init__.py M tests/testlib/base.py M tests/testlib/containers.py M tests/testlib/event_console.py M tests/testlib/fixtures.py M tests/testlib/pylint_checker_cmk_module_layers.py M tests/testlib/pylint_cmk.py M tests/testlib/site.py M tests/testlib/utils.py A tests/unit/__init__.py M tests/unit/active_checks/test_ac_check_form_submit.py M tests/unit/active_checks/test_ac_check_mail.py M tests/unit/active_checks/test_ac_check_mail_loop.py M tests/unit/active_checks/test_ac_check_traceroute.py M tests/unit/active_checks/test_ac_check_uniserv.py M tests/unit/active_checks/test_active_check_sql.py M tests/unit/agents/special/test_special_agent_args.py A tests/unit/checks/__init__.py M tests/unit/checks/conftest.py M tests/unit/checks/generictests/__init__.py M tests/unit/checks/generictests/conftest.py M tests/unit/checks/generictests/crashtest.py M tests/unit/checks/generictests/regression.py M tests/unit/checks/generictests/run.py M tests/unit/checks/test_ac_check_dns.py M tests/unit/checks/test_agent_3par.py M tests/unit/checks/test_agent_acme_sbc.py M tests/unit/checks/test_agent_activemq.py M tests/unit/checks/test_agent_allnet_ip_sensoric.py M tests/unit/checks/test_agent_appdynamics.py M tests/unit/checks/test_agent_aws.py M tests/unit/checks/test_agent_azure.py M tests/unit/checks/test_agent_datadog.py M tests/unit/checks/test_agent_ddn_s2a.py M tests/unit/checks/test_agent_emcvnx.py M tests/unit/checks/test_agent_fritzbox.py M tests/unit/checks/test_agent_hivemanager.py M tests/unit/checks/test_agent_hivemanager_ng.py M tests/unit/checks/test_agent_hp_msa.py M tests/unit/checks/test_agent_ibmsvc.py M tests/unit/checks/test_agent_innovaphone.py M tests/unit/checks/test_agent_ipmi_sensors.py M tests/unit/checks/test_agent_jolokia.py M tests/unit/checks/test_agent_kubernetes.py M tests/unit/checks/test_agent_netapp.py M tests/unit/checks/test_agent_prism.py M tests/unit/checks/test_agent_random.py M tests/unit/checks/test_agent_ruckus_spot.py M tests/unit/checks/test_agent_salesforce.py M tests/unit/checks/test_agent_siemens_plc.py M tests/unit/checks/test_agent_storeonce.py M tests/unit/checks/test_agent_tinkerforge.py M tests/unit/checks/test_agent_ucs_bladecenter.py M tests/unit/checks/test_agent_vsphere.py M tests/unit/checks/test_alcatel_cpu.py M tests/unit/checks/test_alcatel_fans.py M tests/unit/checks/test_alcatel_temp.py M tests/unit/checks/test_apc_netbotz_drycontact.py M tests/unit/checks/test_brocade_fcport.py M tests/unit/checks/test_ceph_df.py M tests/unit/checks/test_ceph_octopus.py M tests/unit/checks/test_check_apt.py M tests/unit/checks/test_check_bi_aggr.py M tests/unit/checks/test_check_by_ssh.py M tests/unit/checks/test_check_cmk_inv.py M tests/unit/checks/test_check_disk_smb.py M tests/unit/checks/test_check_dns.py M tests/unit/checks/test_check_elasticsearch_query.py M tests/unit/checks/test_check_form_submit.py M tests/unit/checks/test_check_ftp.py M tests/unit/checks/test_check_http.py M tests/unit/checks/test_check_icmp.py M tests/unit/checks/test_check_ldap.py M tests/unit/checks/test_check_mail.py M tests/unit/checks/test_check_mail_loop.py M tests/unit/checks/test_check_mailboxes.py M tests/unit/checks/test_check_mkevents.py M tests/unit/checks/test_check_notify_count.py M tests/unit/checks/test_check_sftp.py M tests/unit/checks/test_check_smtp.py M tests/unit/checks/test_check_sql.py M tests/unit/checks/test_check_ssh.py M tests/unit/checks/test_check_tcp.py M tests/unit/checks/test_check_temperature.py M tests/unit/checks/test_check_traceroute.py M tests/unit/checks/test_check_uniserv.py M tests/unit/checks/test_compellent_folder.py M tests/unit/checks/test_df_check.py M tests/unit/checks/test_diskstat_include.py M tests/unit/checks/test_docker_container_diskstat.py M tests/unit/checks/test_f5_bigip_conns.py M tests/unit/checks/test_f5_bigip_mem.py M tests/unit/checks/test_f5_bigip_vserver.py M tests/unit/checks/test_fc_port.py M tests/unit/checks/test_fileinfo_check.py M tests/unit/checks/test_fortigate_sslvpn.py M tests/unit/checks/test_generic_datasets.py M tests/unit/checks/test_hp_msa_volume.py M tests/unit/checks/test_hr_ps.py M tests/unit/checks/test_ibm_mq_channels.py M tests/unit/checks/test_ibm_mq_managers.py M tests/unit/checks/test_ibm_mq_plugin.py M tests/unit/checks/test_ibm_mq_queues.py M tests/unit/checks/test_inotify.py M tests/unit/checks/test_jolokia_generic.py M tests/unit/checks/test_k8s_replicas.py M tests/unit/checks/test_lnx_thermal.py M tests/unit/checks/test_mbg_lantime_ng_refclock.py M tests/unit/checks/test_mbg_lantime_ng_state.py M tests/unit/checks/test_mkbackup_check.py M tests/unit/checks/test_mongodb_connections.py M tests/unit/checks/test_mongodb_flushing.py M tests/unit/checks/test_msoffice_serviceplans.py M tests/unit/checks/test_multipath.py M tests/unit/checks/test_netapp_api_cpu.py M tests/unit/checks/test_netstat_parse.py M tests/unit/checks/test_nfsmounts_and_cifsmounts_check.py M tests/unit/checks/test_nimble_latency.py M tests/unit/checks/test_nullmailer_mailq.py M tests/unit/checks/test_oracle_instance.py M tests/unit/checks/test_oracle_jobs.py M tests/unit/checks/test_prism_containers.py M tests/unit/checks/test_ra32e_power_check.py M tests/unit/checks/test_ra32e_sensors_check.py M tests/unit/checks/test_ra32e_switch_check.py M tests/unit/checks/test_sap_hana_ess_migration.py M tests/unit/checks/test_sap_hana_fileinfo.py M tests/unit/checks/test_sophos_disk.py M tests/unit/checks/test_statgrab_cpu_check.py M tests/unit/checks/test_systemd_units.py M tests/unit/checks/test_win_license.py M tests/unit/checks/test_windows_tasks.py M tests/unit/checks/test_wmi_check.py M tests/unit/checks/test_zfsget.py A tests/unit/cmk/__init__.py A tests/unit/cmk/base/__init__.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py M tests/unit/cmk/base/agent_based/test_data_provider_collect_host_sections.py M tests/unit/cmk/base/check_legacy_includes/test_fileinfo_utils.py M tests/unit/cmk/base/conftest.py A tests/unit/cmk/base/plugins/__init__.py A tests/unit/cmk/base/plugins/agent_based/__init__.py M tests/unit/cmk/base/plugins/agent_based/test_aix_diskiod.py M tests/unit/cmk/base/plugins/agent_based/test_cadvisor_if.py M tests/unit/cmk/base/plugins/agent_based/test_check_plugin_properties.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_mem_asa.py M tests/unit/cmk/base/plugins/agent_based/test_diskstat.py M tests/unit/cmk/base/plugins/agent_based/test_docker_container_status.py M tests/unit/cmk/base/plugins/agent_based/test_docker_node_disk_usage.py M tests/unit/cmk/base/plugins/agent_based/test_hitachi_hnas_volume.py M tests/unit/cmk/base/plugins/agent_based/test_hr_mem.py M tests/unit/cmk/base/plugins/agent_based/test_if_brocade_lancom.py M tests/unit/cmk/base/plugins/agent_based/test_inv_esx_vsphere_hostsystem.py M tests/unit/cmk/base/plugins/agent_based/test_inv_if.py M tests/unit/cmk/base/plugins/agent_based/test_inv_solaris_pkginfo.py M tests/unit/cmk/base/plugins/agent_based/test_job.py M tests/unit/cmk/base/plugins/agent_based/test_kaspersky_av_client.py M tests/unit/cmk/base/plugins/agent_based/test_kaspersky_av_kesl_updates.py M tests/unit/cmk/base/plugins/agent_based/test_lnx_if.py M tests/unit/cmk/base/plugins/agent_based/test_local.py M tests/unit/cmk/base/plugins/agent_based/test_netapp_api_vf_stats.py M tests/unit/cmk/base/plugins/agent_based/test_oracle_asm_diskgroup.py M tests/unit/cmk/base/plugins/agent_based/test_proxmox_ve_backup_status.py M tests/unit/cmk/base/plugins/agent_based/test_proxmox_ve_disk_usage.py M tests/unit/cmk/base/plugins/agent_based/test_proxmox_ve_node_info.py M tests/unit/cmk/base/plugins/agent_based/test_proxmox_ve_snapshot_age.py M tests/unit/cmk/base/plugins/agent_based/test_ps_check.py M tests/unit/cmk/base/plugins/agent_based/test_ps_section.py M tests/unit/cmk/base/plugins/agent_based/test_uptime_check.py M tests/unit/cmk/base/plugins/agent_based/test_winperf_if.py M tests/unit/cmk/base/plugins/agent_based/test_winperf_phydisk.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py A tests/unit/cmk/base/sources/__init__.py M tests/unit/cmk/base/sources/test_cmd_caching.py M tests/unit/cmk/base/sources/test_data_sources.py M tests/unit/cmk/base/sources/test_fetcher_configuration.py M tests/unit/cmk/base/sources/test_ipmi_management_board_data_source.py M tests/unit/cmk/base/sources/test_piggy_back_data_source.py M tests/unit/cmk/base/sources/test_program_data_source.py M tests/unit/cmk/base/sources/test_snmp_data_source.py M tests/unit/cmk/base/sources/test_tcp_data_source.py M tests/unit/cmk/base/test_autochecks.py M tests/unit/cmk/base/test_automations_check_mk.py M tests/unit/cmk/base/test_base_crash_reporting.py M tests/unit/cmk/base/test_check_api.py M tests/unit/cmk/base/test_check_table.py M tests/unit/cmk/base/test_checks.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/base/test_core_config.py M tests/unit/cmk/base/test_core_nagios.py M tests/unit/cmk/base/test_ip_lookup.py M tests/unit/cmk/base/test_mgmt_board.py M tests/unit/cmk/base/test_modes_check_mk.py M tests/unit/cmk/base/test_prediction.py M tests/unit/cmk/base/test_unit_automations.py M tests/unit/cmk/core_helpers/test_parsers.py M tests/unit/cmk/ec/test_ec_status.py M tests/unit/cmk/ec/test_event_creator.py A tests/unit/cmk/gui/__init__.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/htmllib/test_foldable_container.py M tests/unit/cmk/gui/htmllib/test_html_cls.py A tests/unit/cmk/gui/plugins/__init__.py M tests/unit/cmk/gui/plugins/metrics/test_artwork.py M tests/unit/cmk/gui/plugins/views/test_availability.py M tests/unit/cmk/gui/plugins/views/test_painters.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py A tests/unit/cmk/gui/plugins/wato/__init__.py A tests/unit/cmk/gui/plugins/wato/utils/__init__.py M tests/unit/cmk/gui/test_background_job.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/test_i18n.py M tests/unit/cmk/gui/test_table.py M tests/unit/cmk/gui/test_userdb.py M tests/unit/cmk/gui/test_valuespec.py M tests/unit/cmk/gui/test_watolib_hosts_and_folders.py M tests/unit/cmk/gui/utils/test_logged_in.py M tests/unit/cmk/gui/watolib/test_activate_changes.py M tests/unit/cmk/gui/watolib/test_changes.py M tests/unit/cmk/gui/watolib/test_config_sync.py M tests/unit/cmk/snmplib/test_snmp_scan.py M tests/unit/cmk/snmplib/test_snmplib_snmp_table.py M tests/unit/cmk/special_agents/test_agent_proxmox_ve.py M tests/unit/cmk/test_update_config.py M tests/unit/cmk/utils/rulesets/test_ruleset_matcher.py M tests/unit/cmk/utils/rulesets/test_tuple_rulesets.py M tests/unit/cmk/utils/structured_data/test_structured_data.py M tests/unit/cmk/utils/test_log.py M tests/unit/cmk/utils/test_man_pages.py M tests/unit/cmk/utils/test_paths.py M tests/unit/cmk/utils/test_store.py M tests/unit/cmk/utils/test_werks.py M tests/unit/conftest.py M tests/unit/test_find_debug_code_web.py M tests/unit/test_find_debug_print.py M tests/unit/test_permissions.py M tests/unit/test_pylint_checker_cmk_module_layers.py Log Message: ----------- Cleanup tests directory from sys.path This change makes the tests directory a python package. The idea of this change is to reduce the individual sys.path entries to a required minimum in the moment our tools (unit tests, pylint, mypy) are executed. If you previously imported testlib, you will now have to reference tests.testlib. Unit test helper modules can now either be imported with their full module name, e.g. tests.unit.checks.checktestlib or with a relative import "from .checktestlib import run". This is also one step towards enabling implicit namespace package support since the tests directory can now not confuse the implicit namespace detection anymore. It also improves our typing coverage reports since mypy can understand the directory hierarchy below tests as single module hierarchy. It is also the recommended test layout setup by pytest https://docs.pytest.org/en/6.2.x/goodpractices.html#tests-outside-applicati…. Change-Id: I261670f674bde2da501879d0c503c83d5f010acd Commit: 67b3bde4b225217eddb7563a164c07664746d2e5 https://github.com/tribe29/checkmk/commit/67b3bde4b225217eddb7563a164c07664… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-28 (Wed, 28 Jul 2021) Changed paths: A agents/wnx/integration/__init__.py M agents/wnx/integration/_test_section_logfiles.py M agents/wnx/integration/conftest.py M agents/wnx/integration/local.py M agents/wnx/integration/test_agent_start_parameters.py M agents/wnx/integration/test_section_check_mk.py M agents/wnx/integration/test_section_df.py M agents/wnx/integration/test_section_dotnet_clrmemory.py M agents/wnx/integration/test_section_eventlog.py M agents/wnx/integration/test_section_fileinfo.py M agents/wnx/integration/test_section_mem.py M agents/wnx/integration/test_section_mrpe.py M agents/wnx/integration/test_section_openhardwaremonitor.py M agents/wnx/integration/test_section_plugin_group.py M agents/wnx/integration/test_section_ps.py M agents/wnx/integration/test_section_services.py M agents/wnx/integration/test_section_spool.py M agents/wnx/integration/test_section_systemtime.py M agents/wnx/integration/test_section_uptime.py M agents/wnx/integration/test_section_winperf.py M agents/wnx/integration/test_section_wmi_cpuload.py M agents/wnx/integration/test_section_wmi_webservices.py Log Message: ----------- Prepare agents/wnx/integration for namespace support When enabling mypy namespace support the module detection slightly changes. To make checking the code possible with and without namespace support, we need to make the directory a package and switch to relative imports. Change-Id: I6a73ea75967cbbafe5f1bfce9270c0c452764948 Compare: https://github.com/tribe29/checkmk/compare/1dbf14031ee9...67b3bde4b225