[checkmk-commits] Check_MK Git: check_mk: #2335 FIX Fixed PNP default template for active checks with arguments

Module: check_mk Branch: master Commit: a3cf62d83d3fd12c344da0462cb536990577e582 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a3cf62d83d3fd1… Author: Lars Michelsen &lt;lm(a)mathias-kettner.de&gt; Date: Wed Jun 3 10:55:35 2015 +0200 #2335 FIX Fixed PNP default template for active checks with arguments The graph popups were not rendered and PNP showed up a message <tt>$def[]</tt> not defined. --- .werks/2335 | 11 +++++++++++ ChangeLog | 1 + pnp-templates/default.php | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/2335 b/.werks/2335 new file mode 100644 index 0000000..c48e411 --- /dev/null +++ b/.werks/2335 @@ -0,0 +1,11 @@ +Title: Fixed PNP default template for active checks with arguments +Level: 1 +Component: multisite +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i2 +Date: 1433321671 + +The graph popups were not rendered and PNP showed up a message <tt>$def[]</tt> +not defined. diff --git a/ChangeLog b/ChangeLog index a62ba9c..d8fee1c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,6 +9,7 @@ * 2324 FIX: Add icon for those checks that cannot be rescheduled... * 2261 FIX: Fixed wrong pnp template cache path in non OMD environments... * 2262 FIX: Fixed deletion of foreign views/dashboards... + * 2335 FIX: Fixed PNP default template for active checks with arguments... Event Console: * 2333 The Event Console log level can now be configured via GUI... diff --git a/pnp-templates/default.php b/pnp-templates/default.php index 384c3f2..067c58f 100644 --- a/pnp-templates/default.php +++ b/pnp-templates/default.php @@ -39,7 +39,7 @@ else # cache file missing or stale: try to fetch live template via HTTP if ($cache_state != "uptodate") { - $fd = @fopen($url . "pnp_template.py?id=" . $id_string, "r"); + $fd = @fopen($url . "pnp_template.py?id=" . urlencode($id_string), "r"); if ($fd) { $data = ""; while (!feof($fd)) {