[checkmk-commits] [tribe29/checkmk] ef05f6: 15278 FIX synology_disk: read disk health status

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ef05f659064690a10a9ba8e112f2fbe5e4829472 https://github.com/tribe29/checkmk/commit/ef05f659064690a10a9ba8e112f2fbe5e… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: A .werks/15278 M cmk/base/plugins/agent_based/synology_disks.py M tests/unit/cmk/base/plugins/agent_based/test_synology_disk.py Log Message: ----------- 15278 FIX synology_disk: read disk health status A Failing disks would report a working file system (as the file system was still readable) but still needs to be replaced. The check was extended to also report disk health status which was introduced with DSM 7.1. Also split the summary, remove duplicated temperature text, and remove text about temperature levels, as no temperature levels can be defined for this service. SUP-13080 Change-Id: Ib683f46806dc0190ea102df5772720974c98941a Commit: 265506e6b1689118d624c8b20addd55bfa841561 https://github.com/tribe29/checkmk/commit/265506e6b1689118d624c8b20addd55bf… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: A .werks/15280 M cmk/base/plugins/agent_based/synology_disks.py M tests/unit/cmk/base/plugins/agent_based/test_synology_disk.py Log Message: ----------- 15280 FIX synology_disk: use diskRole to ignore "not initialized" warning It's okay if a disk is not initialized (this is normally a warning) if the disk is not used at all, a SSD-cache or a hot-spare. Before all disks containing SSD or NVME in the disk model were assumed to be caches. SUP-13080 Change-Id: Ic24e5c0d8f7f00d768c1f9a3d38c6031c0d6969f Commit: afe215b428a4c6668618d9773185e68ceb336be0 https://github.com/tribe29/checkmk/commit/afe215b428a4c6668618d9773185e68ce… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M cmk/gui/plugins/wato/check_parameters/interfaces.py Log Message: ----------- Adapt rule defaults for discards See SUP-13226 for the "why" Change-Id: Ica1e6672110a9e5b5088bbbc2e26f71fd2452e19 JIRA-Ref: SUP-13226 Commit: 6a5b3871b6d4d3de6799ae4a64039e7346523da6 https://github.com/tribe29/checkmk/commit/6a5b3871b6d4d3de6799ae4a64039e734… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M tests/unit/cmk/base/agent_based/discovery/test_discovery.py Log Message: ----------- Use list comprehension in tests Less copy/paste, slightly easier to read and easier to maintain. Change-Id: I1a80fcf574032908dbf572f21fb868ffce2724ef Commit: 188766d07c27a4e498748d461881de34d53a9dd1 https://github.com/tribe29/checkmk/commit/188766d07c27a4e498748d461881de34d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M cmk/base/agent_based/data_provider.py M cmk/base/agent_based/discovery/_host_labels.py M tests/unit/cmk/base/agent_based/test_data_provider_parsed_sections_resolver.py Log Message: ----------- Keep section name explicitly in ResolvedResult Change-Id: Ibdb21186cfc0a9125283d0811f567037b555bddd Commit: f0900c3fb40e8f84c0c829737de725b79062e7f1 https://github.com/tribe29/checkmk/commit/f0900c3fb40e8f84c0c829737de725b79… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M cmk/base/agent_based/data_provider.py M cmk/base/agent_based/discovery/_host_labels.py M tests/unit/cmk/base/agent_based/discovery/test_discovery.py M tests/unit/cmk/base/agent_based/test_data_provider_parsed_sections_broker.py M tests/unit/cmk/base/agent_based/test_data_provider_parsed_sections_resolver.py M tests/unit/cmk/base/agent_based/test_utils.py Log Message: ----------- Keep Mapping[SectionName, SectionPlugin] type Change-Id: Ia90b2c0859ffc60fdb88979368964e98e9ba8ce9 Commit: 34b5a578e672b96a1079df1f8e60bd23cfea6f63 https://github.com/tribe29/checkmk/commit/34b5a578e672b96a1079df1f8e60bd23c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M cmk/base/api/agent_based/checking_classes.py M cmk/base/api/agent_based/type_defs.py M cmk/checkers/__init__.py M cmk/checkers/_api.py Log Message: ----------- Move PluginHostLabel to lower layer This type is used in the check engine, which is in a lower layer than the check API. Therefore, this change fixes a layering violation. Change-Id: I04fffc86be4b1411180b1a9111377143fb8e720c Commit: 8790e6574da164acd20cb1a924dfa6d2d305e9e5 https://github.com/tribe29/checkmk/commit/8790e6574da164acd20cb1a924dfa6d2d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M cmk/base/agent_based/checking/_checking.py M cmk/base/agent_based/data_provider.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/agent_based/discovery/autodiscovery.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/discovery/preview.py M cmk/base/agent_based/inventory/_active.py M cmk/base/agent_based/inventory/_autoinventory.py M cmk/base/agent_based/inventory/_inventory.py M cmk/base/agent_based/inventory/commandline.py M cmk/base/config.py M cmk/checkers/__init__.py M cmk/checkers/_api.py Log Message: ----------- Raise abstraction -> SectionPlugin Change-Id: I61909d7a119172a80a8fe02f3db0199246281997 Compare: https://github.com/tribe29/checkmk/compare/ac07790934b4...8790e6574da1