[checkmk-commits] [Checkmk/checkmk] a4519a: 16523 FIX event_console: site_id only required whe...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: a4519a77f31d6faf8be94494fc7686c6687942ae https://github.com/Checkmk/checkmk/commit/a4519a77f31d6faf8be94494fc7686c66… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A .werks/16523.md M cmk/gui/livestatus_utils/commands/event_console.py M cmk/gui/mkeventd/_openapi/__init__.py M cmk/gui/mkeventd/_openapi/request_schemas.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/openapi/test_event_console.py Log Message: ----------- 16523 FIX event_console: site_id only required when deleting ec events by_id When deleting an ec event via the REST-API, only the 'by_id' option leaves the event selection ambiguous, while the options 'params' or 'query' already have the ability to pinpoint the event requested. Therefore, the site_id should is not required in these cases. CMK-16214 Change-Id: I955e4911a3209f22c2443dad173f3a966eeb11f4 Commit: 395fddcadce89357a8aae2fc3314b2240903cbca https://github.com/Checkmk/checkmk/commit/395fddcadce89357a8aae2fc3314b2240… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A .werks/16522.md M cmk/gui/livestatus_utils/commands/comment.py M cmk/gui/openapi/endpoints/comment/__init__.py M cmk/gui/openapi/endpoints/comment/request_schemas.py M tests/testlib/rest_api_client.py M tests/unit/cmk/gui/openapi/test_service_and_host_comments.py Log Message: ----------- 16522 FIX comment: site_id only required when deleting comments by id When deleting a comment via the REST-API, only the 'by_id' option leaves the comment selection ambiguous, while the options 'params' or 'query' already have the ability to pinpoint the comment requested. Therefore, the site_id should is not required in these cases. CMK-14591 Change-Id: I1046a352d4ce0bfbfeb6cbe74df5458ac14a1135 Compare: https://github.com/Checkmk/checkmk/compare/800c15401ade...395fddcadce8 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications