[checkmk-commits] [Checkmk/checkmk] fb708e: Move root_dir to FolderTree

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: fb708e93c295a7836bd03c871b1158132001b7f3 https://github.com/Checkmk/checkmk/commit/fb708e93c295a7836bd03c871b1158132… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/gui/wato/pages/folders.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulesets.py M tests/unit/cmk/gui/watolib/test_gui_rulesets.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py M tests/unit/cmk/update_config/plugins/actions/test_rulesets.py Log Message: ----------- Move root_dir to FolderTree This feature fits better with the FolderTree class instead of the CREFolder. The CREFolder only needs to be aware of it's path relative to the root provided by the FolderTree. To enable this change the tree needs to be made available to various helpers, like _RedisHelper and FolderMetadata now. This also eliminates some implicit dependencies on global states. Change-Id: I316076e2fdf2a9309f47b858229e0fc6ad88aeef Commit: d41b5164916f66a3c2bcb57455d97f3f01364242 https://github.com/Checkmk/checkmk/commit/d41b5164916f66a3c2bcb57455d97f3f0… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Add main folder predicate Change-Id: I14be2bcfc029a4bc3fede763a1663106c9d8979f Commit: 7fd856460352ac4c7856d049cd02f10806d778cd https://github.com/Checkmk/checkmk/commit/7fd856460352ac4c7856d049cd02f1080… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/gui/plugins/openapi/endpoints/folder_config.py M cmk/gui/wato/pages/bulk_edit.py M cmk/gui/wato/pages/folders.py M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Add type hints to CREFolder.__init__ Change-Id: I9d17368920b7479c1068e8d56126898ce4b6f6be Commit: 697d0d33b6cc56cf74d9c25036a504fd103b1855 https://github.com/Checkmk/checkmk/commit/697d0d33b6cc56cf74d9c25036a504fd1… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/gui/wato/pages/folders.py M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/gui/watolib/test_gui_rulesets.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py M tests/unit/cmk/update_config/plugins/actions/test_rulesets.py Log Message: ----------- Add factories to load and create folders The goal is to extract the alternative construction of new folders and loading of existing folders from the constructor which will then help to reduce the arguments of both variants. This is a first step which keeps the arguments of the constructor. Next step will be to move over the code to the specific places and reduce the arguments to the required minimum. Change-Id: I02aab2b63ba19c965b427583a78580e8c2f7ad04 Commit: 18b6872fad7fe6cb91a8f73015fdbb292fe0fed7 https://github.com/Checkmk/checkmk/commit/18b6872fad7fe6cb91a8f73015fdbb292… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Cleanup two folder test cases The new version still does some monkey patching, but is easier to follow. Change-Id: I09f3fb4eca947447ff52a0bcfe8cb47a348cb009 Commit: ba63e5fa4e58f638029eb4138d65127f72d61bd3 https://github.com/Checkmk/checkmk/commit/ba63e5fa4e58f638029eb4138d65127f7… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Stricter Folder.new() Remove the now unused folder_path and make parent_folder typing stricter. Change-Id: Ie0781b0683c6dfe5fca556a52c88cf1c2ab88d96 Commit: 32d4e6601792ce78870eae9e45f579450210f5df https://github.com/Checkmk/checkmk/commit/32d4e6601792ce78870eae9e45f579450… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: A cmk/utils/mrpe_config.py M cmk/utils/type_defs/__init__.py R cmk/utils/type_defs/mrpe_config.py A tests/unit/cmk/utils/test_mrpe_config.py R tests/unit/cmk/utils/type_defs/test_mrpe.py Log Message: ----------- Move `mrpe_config` from type_defs to utils The module doesn't consist entirely of type definitions. Change-Id: Ieadff4be4fca45c74ea6a37bcbe77afb02a2df54 Commit: d0710cc8935ef0b94b6ec14659de0a417d3ab8c8 https://github.com/Checkmk/checkmk/commit/d0710cc8935ef0b94b6ec14659de0a417… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/base/agent_based/checking/_checking.py M cmk/base/agent_based/discovery/_discovery.py M cmk/base/checkers.py M cmk/checkengine/_api.py M cmk/checkengine/sectionparser.py M cmk/checkengine/summarize.py M cmk/fetchers/_abstract.py M cmk/fetchers/_api.py A cmk/utils/resulttype.py R cmk/utils/type_defs/result.py M omd/packages/omd/omdlib/config_hooks.py M omd/packages/omd/omdlib/main.py M omd/packages/omd/omdlib/type_defs.py M tests/unit/cmk/base/agent_based/test_base_inventory.py M tests/unit/cmk/base/test_automations_check_mk.py M tests/unit/cmk/base/test_modes_check_mk.py M tests/unit/cmk/checkers/test_fetchers.py A tests/unit/cmk/utils/test_resulttype.py R tests/unit/cmk/utils/type_defs/test_type_defs_result.py Log Message: ----------- Move result type to top level It's a very general module without any external dependency. Therefore, it belongs in the top level. In principle, we could even move it to packages. Change-Id: I511f2d7ea3c929e8afffe130c94330da2fe48bc0 Commit: 70468e0ed5fe9ee5cdddd10736a53a957f00b350 https://github.com/Checkmk/checkmk/commit/70468e0ed5fe9ee5cdddd10736a53a957… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M cmk/fetchers/_agentctl.py A cmk/utils/serializertype.py M cmk/utils/type_defs/__init__.py R cmk/utils/type_defs/protocol.py Log Message: ----------- Move general serializer types to "top" level very general types + no external deps = no nesting Change-Id: I1a20e30ca4e142fd04a460078c606f669c6bb483 Compare: https://github.com/Checkmk/checkmk/compare/aeeb0b1144af...70468e0ed5fe