[checkmk-commits] [tribe29/checkmk] b0efb0: add generic typing for _data to FigureBase and its...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b0efb0d33b85e1d450fb9d454c5e995115dedf1b https://github.com/tribe29/checkmk/commit/b0efb0d33b85e1d450fb9d454c5e99511… Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com> Date: 2022-10-20 (Thu, 20 Oct 2022) Changed paths: M web/htdocs/js/modules/figures/cmk_figures.ts M web/htdocs/js/modules/figures/cmk_stats.js M web/htdocs/js/modules/figures/cmk_table.ts Log Message: ----------- add generic typing for _data to FigureBase and its direct subclasses Change-Id: I4a2b3b7dd1ce808099e4037ebf9107a25ad85d91 Commit: e936cfd467b20add6dfb959ed7f544809950dfde https://github.com/tribe29/checkmk/commit/e936cfd467b20add6dfb959ed7f544809… Author: Mazen Alkatlabee <mazen.alkatlabee(a)tribe29.com> Date: 2022-10-20 (Thu, 20 Oct 2022) Changed paths: M web/htdocs/js/modules/figures/cmk_figures.ts Log Message: ----------- make FigureBase class abstract Since FigureBase is never initialized but always its subclasses and we are using getEmptyData to add typing to its data. I changed the class and the method to abstract to force implementing it in the subclasses of FigureBase Change-Id: I04ed624f3a5b736551f20175d267c1d8c26881af Compare: https://github.com/tribe29/checkmk/compare/20537d0c272d...e936cfd467b2