[checkmk-commits] [Checkmk/checkmk] f619b6: generic-package-job.groovy: set's --init for conta...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: f619b66ddc0bea831bd8ab2bcb9055c427bb3e00 https://github.com/Checkmk/checkmk/commit/f619b66ddc0bea831bd8ab2bcb9055c42… Author: Frans Fürst <frans.fuerst(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M buildscripts/scripts/generic-package-job.groovy Log Message: ----------- generic-package-job.groovy: set's --init for container to avoid hanging Bazel see - https://ci.lan.tribe29.com/job/checkmk/job/master/job/builders/job/build-cm… - and https://github.com/bazelbuild/bazel/issues/16907 Change-Id: If97afeef90b1293eb086a006570504cd60d2a7a2 Commit: 8c22cb397974d711ce2b6d445f43200a657e789b https://github.com/Checkmk/checkmk/commit/8c22cb397974d711ce2b6d445f43200a6… Author: Jonas Scharpf <jonas.scharpf(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M buildscripts/scripts/utils/notify.groovy Log Message: ----------- Groovy is great, can't use split in combination with unique ... as split does not really return a list usable by unique() Change-Id: I3469f03143ea888d0523c6db1c81c2bc171aba0c Commit: 6cce8630771c5aef56283e4c43adcb20940b91df https://github.com/Checkmk/checkmk/commit/6cce8630771c5aef56283e4c43adcb209… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/openapi/test_openapi_host_config.py M tests/unit/cmk/gui/watolib/test_scan_parents_background_job.py Log Message: ----------- Prevent agent baking during tests Adding hosts triggers an agent baking job in the background. The fixture `suppress_bake_agents_in_background` is now used to prevent this. It can be used for the following: a) Skip calling the job b) Ensure the job would have been called. Of course, it would be great to do this without mocking, but this is way beyond the scope of hot fixing the current situation in the tests which start background jobs in an unintended way which leads to longer test runs and even flakes in case jobs collide with test clean up logic. CMK-18469 Change-Id: Iad66c08827b4e1518a06efe83228e1f525f04079 Commit: 446325aa32c96f53c4375de53ec9c1990a0954a7 https://github.com/Checkmk/checkmk/commit/446325aa32c96f53c4375de53ec9c1990… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/openapi/test_notification_rules.py M tests/unit/cmk/gui/openapi/test_openapi_host_tag_group.py Log Message: ----------- Prevent API spec computation during tests In production the REST API spec is automatically computed when the tag configuration changes. So far, all tests which changed the tag configuration triggered a background job and recomputed the REST API spec, which is not necessary for the tests. Besides increased and unnecessary load, this also lead to flakes in case the job still ran during the test cleanup. CMK-18469 Change-Id: If5c2a36218dee3dafa608cb07f6df3e992821a36 Commit: 306145f1001b603cbea1229a4a0b38e628052b6b https://github.com/Checkmk/checkmk/commit/306145f1001b603cbea1229a4a0b38e62… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/openapi/test_openapi_activate_changes.py M tests/unit/cmk/gui/openapi/test_openapi_auxtags.py M tests/unit/cmk/gui/openapi/test_openapi_folder_config.py M tests/unit/cmk/gui/openapi/test_openapi_host_config.py M tests/unit/cmk/gui/openapi/test_openapi_parent_scan.py M tests/unit/cmk/gui/openapi/test_openapi_service_discovery.py M tests/unit/cmk/gui/watolib/test_watolib_search.py Log Message: ----------- Suppress or allow background jobs in tests CMK-18469 Change-Id: I3f0356d9f22b2b101d548525c2e2fd744c29a95e Commit: eb1b5567da3871fd20c6c0e2529faa9b3d8a39b6 https://github.com/Checkmk/checkmk/commit/eb1b5567da3871fd20c6c0e2529faa9b3… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Fail all tests which start background jobs without annotation It was just discovered that many tests execute background jobs which run in a totally unsynchronized and unsupervised way. For example a test which created a host, triggered the automatic agent baking in the background. In general this is not the desired and in this example background jobs should not be triggered at all, except the test is specifically about the testing the background job. Tests must not execute logic in background job processes, which continue to run independently of the test case. To prevent that from happening accidentally we now do the following: 1. Fail every test which starts a background job. 2. In case a test uses the fixture `inline_background_jobs`, the execution of the job is allowed. Once annotated with the `inline_background_jobs` fixture, the background job logic run synchronously so that the test code waits for the job to complete. In many cases this is the desired behavior and makes it easier to deal with the jobs in the tests. However, in some cases you actually want to have a backrgound job being executed in the same way as in the production environment. In that case, you need to define a local fixture named "inline_background_jobs" to override the global fixture. CMK-18469 Change-Id: I8c47b82b90581fb2ab31d711dfe88731898ab91b Commit: de3056c577f91a8fdd2cc214c1fcb0b5cd907bd0 https://github.com/Checkmk/checkmk/commit/de3056c577f91a8fdd2cc214c1fcb0b5c… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M tests/unit/cmk/gui/wsgi/test_wsgi_router.py Log Message: ----------- test_cmk_run_cron: Do not execute actual jobs CMK-18469 Change-Id: Ifc9ba547707bd04fadebe0df44e42b27f77ac942 Compare: https://github.com/Checkmk/checkmk/compare/1a0968b452c6...de3056c577f9 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications