[checkmk-commits] [Checkmk/checkmk] cbcf3f: Make parse_secret's type more honest.

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: cbcf3f9922c2a33e8d765b9062fe151f36af71aa https://github.com/Checkmk/checkmk/commit/cbcf3f9922c2a33e8d765b9062fe151f3… Author: Sven Panne <sven.panne(a)checkmk.com> Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M cmk/plugins/cisco/server_side_calls/prime.py M cmk/plugins/elasticsearch/server_side_calls/special_agent.py M cmk/plugins/prism/server_side_calls/special_agent.py M packages/cmk-server-side-calls/cmk/server_side_calls/v1/_utils.py M packages/cmk-server-side-calls/tests/v1/test_utils.py Log Message: ----------- Make parse_secret's type more honest. It *has* more requirements than its previous signature stated, and testing these requirements within that function is an anti-pattern. If we really want more validation for the value part of the secret, that should live in e.g. __post_init__()s of StoredSecret and PlainSecret, but there is not really much point in doing so: If we deem this necessary, we would need *tons* of other validations and should probably switch to pydantic models directly. Fixed a wrong type annotation in the cisco plugin on the way. Change-Id: I550e75e66d13ec9cad47e7531b5a890b1068f44f To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications