14 Sep
2022
14 Sep
'22
8:33 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 9d87315044f1681b1e9966ea18b8ff0ac809ef08
https://github.com/tribe29/checkmk/commit/9d87315044f1681b1e9966ea18b8ff0ac…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2022-09-14 (Wed, 14 Sep 2022)
Changed paths:
M cmk/gui/plugins/openapi/endpoints/rule/__init__.py
M cmk/gui/plugins/openapi/endpoints/ruleset/__init__.py
M cmk/gui/plugins/wato/ac_tests.py
M cmk/gui/plugins/webapi/webapi.py
M cmk/gui/wato/pages/object_parameters.py
M cmk/gui/wato/pages/pattern_editor.py
M cmk/gui/wato/pages/predefined_conditions.py
M cmk/gui/wato/pages/rulesets.py
M cmk/gui/wato/pages/timeperiods.py
M cmk/gui/watolib/groups.py
M cmk/gui/watolib/host_rename.py
M cmk/gui/watolib/rulesets.py
M cmk/gui/watolib/sample_config.py
M cmk/gui/watolib/services.py
M cmk/gui/watolib/tags.py
M cmk/update_config/plugins/actions/autochecks.py
M cmk/update_config/plugins/actions/rulesets.py
M tests/unit/cmk/update_config/plugins/actions/test_rulesets.py
Log Message:
-----------
Flatten RulesetCollection spaghetti
I guess that makes the class hierarchy into linguine, now.
Anyway, the call stack is clearer when it is explicit.
This is one of the many cases where we have an overly complex (and
useless) inheritance hierarchy.
Moreover, the collection now looks a bit more like a container and less
magic Ruleset instantiation happens within it.
We will need that to decouple the bakery from the Ruleset code.
CMK-11212
Change-Id: I4a100a03e2d68c4c5a53e421e1fbcfc8fa45cc6b