[checkmk-commits] [tribe29/checkmk] a4595a: Add missing type hints to dashlets

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a4595acd95737b617b0ec8c2bc25abf55dcfd0b1 https://github.com/tribe29/checkmk/commit/a4595acd95737b617b0ec8c2bc25abf55… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-09-01 (Thu, 01 Sep 2022) Changed paths: M cmk/gui/plugins/dashboard/graph.py M tests/unit/cmk/gui/test_dashboard.py Log Message: ----------- Add missing type hints to dashlets Change-Id: I432a24beb86742c9e76a3b7e0dc95107c37a20bd Commit: 9c91b3a60bf7be2c879bf4ba90dfd6528d8aa52c https://github.com/tribe29/checkmk/commit/9c91b3a60bf7be2c879bf4ba90dfd6528… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-09-01 (Thu, 01 Sep 2022) Changed paths: M cmk/gui/dashboard.py M cmk/gui/plugins/dashboard/custom_url.py M cmk/gui/plugins/dashboard/failed_notifications.py M cmk/gui/plugins/dashboard/graph.py M cmk/gui/plugins/dashboard/logo.py M cmk/gui/plugins/dashboard/overview.py M cmk/gui/plugins/dashboard/snapin.py M cmk/gui/plugins/dashboard/static_text.py M cmk/gui/plugins/dashboard/user_messages.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M tests/unit/cmk/gui/test_dashboard.py Log Message: ----------- Prepare dashlet config for typing With this change we prepare for making DashletConfig a typed dict. We introduce a dashlet type specific dashlet config class which defines the attribute that can be configured for that dashlet while keeping DashletConfig a regular dict. This way we can prepare the code step py step for the final change. Change-Id: I6462076814df63371602a6ad45bc2412ba1db2dc Commit: 906e02adffbd6b7d619b652bd93ef64b0a643a37 https://github.com/tribe29/checkmk/commit/906e02adffbd6b7d619b652bd93ef64b0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-09-01 (Thu, 01 Sep 2022) Changed paths: M cmk/gui/plugins/dashboard/graph.py M cmk/gui/type_defs.py M tests/unit/cmk/gui/test_dashboard.py Log Message: ----------- Clean up graph dashlet hierarchy GraphDashlet was used as concrete class for template graphs and as base class for custom and single timeseries graph dashlets. Separated both into ABCGraphDashlet and TemplateGraphDashlet. Also clarified the DashletConfig and GraphIdentifier types for the different concrete graph dashlets. Change-Id: I8bcf51ecc7024512001b709174712e534cae914c Commit: bd0a39ba5b75a89a060e2b7820b388756f1b0ede https://github.com/tribe29/checkmk/commit/bd0a39ba5b75a89a060e2b7820b388756… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-09-01 (Thu, 01 Sep 2022) Changed paths: M cmk/gui/plugins/dashboard/graph.py Log Message: ----------- Graph dashlets: Cleanup _graph_identification and _graph_title Move the dynamically computed attributes out of the GraphDashlet config and make it regular attributes. Change-Id: Ia4aca5cb4a6565ff3053219fb61ab171e4320470 Compare: https://github.com/tribe29/checkmk/compare/a62b28887943...bd0a39ba5b75