[checkmk-commits] [tribe29/checkmk] c7a025: Fix typo

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c7a025c7d430a0a57bcd569fd7ad6c13e719858b https://github.com/tribe29/checkmk/commit/c7a025c7d430a0a57bcd569fd7ad6c13e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-23 (Thu, 23 Apr 2020) Changed paths: M cmk/base/discovery.py Log Message: ----------- Fix typo Change-Id: I56e7d11c0bc2fa866f38b7dd977965d016482c83 Commit: 92d6e4cbbd84c604722dbaff310db1488cacc9d4 https://github.com/tribe29/checkmk/commit/92d6e4cbbd84c604722dbaff310db1488… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-23 (Thu, 23 Apr 2020) Changed paths: M cmk/base/data_sources/abstract.py Log Message: ----------- Make "may_use_cache_file" handling static Inspection of the call sites shows that the setter is always called on the `abstract.DataSource` class and never on an instance or a derived class. We make this fact explicit in the class itself with static accessors. List of call sites (obtained from ack-grep): cmk/base/modes/check_mk.py:94: data_sources.abstract.DataSource.set_may_use_cache_file() cmk/base/modes/check_mk.py:1279: data_sources.abstract.DataSource.set_may_use_cache_file( cmk/base/modes/check_mk.py:1518: data_sources.abstract.DataSource.set_may_use_cache_file( cmk/base/automations/check_mk.py:216: data_sources.abstract.DataSource.set_may_use_cache_file(use_caches) cmk/base/automations/check_mk.py:1543: data_sources.abstract.DataSource.set_may_use_cache_file( cmk/base/data_sources/__init__.py:247: abstract.DataSource.set_may_use_cache_file() enterprise/cmk/base/cee/keepalive.py:382: data_sources.abstract.DataSource.set_may_use_cache_file(False) enterprise/cmk/base/cee/keepalive.py:596: data_sources.abstract.DataSource.set_may_use_cache_file() CMK-4244 Change-Id: Iaa34e2f4662b9866cc07db431b1e55a995a2ee51 Commit: 8b7180d21ea0cecd0bdbcddf769e9278881dfd81 https://github.com/tribe29/checkmk/commit/8b7180d21ea0cecd0bdbcddf769e92788… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-23 (Thu, 23 Apr 2020) Changed paths: M cmk/base/discovery.py M cmk/base/inventory.py Log Message: ----------- Call classmethod on class where possible This helps clarify the usage of the `_no_cache` flag, apparently, the cache may be disabled globally (on DataSource) or for SNMP only. CMK-4244 Change-Id: I85843605a80f24924753ab865360970255937e50 Compare: https://github.com/tribe29/checkmk/compare/7fb06fc7f918...8b7180d21ea0