[checkmk-commits] [tribe29/checkmk] d9a6fa: Remove thousand_sep for Float and Integer

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d9a6fa87ead1f36b9f03f946d86ea4f31fce879c https://github.com/tribe29/checkmk/commit/d9a6fa87ead1f36b9f03f946d86ea4f31… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-08-31 (Wed, 31 Aug 2022) Changed paths: M cmk/gui/valuespec.py M tests/unit/cmk/gui/valuespecs/test_vs_integer.py Log Message: ----------- Remove thousand_sep for Float and Integer This is a ValueSpec API change. Before this change there was a thousand_sep argument to Float.__init__ and Intger.__init__ which was not used at all. Setting thousand_sep for Float to a value other than None would lead to wrong value: vs.Float(thousand_sep=",", unit="unit").value_to_html(1002003) == "1,002,003,.00 unit" As this is hard to fix, and thousand_sep is not used at all it was removed instead of fixed. Change-Id: I19f75f84a585eb8d2855c0a9a74ee4a82234fc3e Commit: e02f5591da2cc16d352223f340d8eb0b2a2a743a https://github.com/tribe29/checkmk/commit/e02f5591da2cc16d352223f340d8eb0b2… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-08-31 (Wed, 31 Aug 2022) Changed paths: A tests/unit/cmk/gui/valuespecs/test_vs_float.py Log Message: ----------- Add test for valuespec.Float Change-Id: Ia17729751a09aeae2caea53c616e21b731fc4c1b Commit: 47f2106486a535036d3cb6e15e0c632ed068aa78 https://github.com/tribe29/checkmk/commit/47f2106486a535036d3cb6e15e0c632ed… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2022-08-31 (Wed, 31 Aug 2022) Changed paths: M cmk/gui/valuespec.py A tests/unit/cmk/gui/valuespecs/test_vs_fixedvalue.py Log Message: ----------- Add tests for valuespec.FixedValue Change-Id: I9f5f27c6f5efea398c595eca6eefb64533d7fe50 Compare: https://github.com/tribe29/checkmk/compare/c158c78e0b6c...47f2106486a5