[checkmk-commits] Check_MK Git: check_mk: FIX stulz_humidity, apc_humidity: Fixed bug while processing check params

Module: check_mk Branch: master Commit: 8a08919caf07cc8564e57be5222f63fdeee6a21d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8a08919caf07cc… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Jan 17 10:35:39 2014 +0100 FIX stulz_humidity, apc_humidity: Fixed bug while processing check params The two checks interpreted warnlow as warncrit. --- .werks/120 | 9 +++++++++ ChangeLog | 1 + checks/apc_humidity | 2 +- checks/stulz_humidity | 2 +- 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.werks/120 b/.werks/120 new file mode 100644 index 0000000..be65516 --- /dev/null +++ b/.werks/120 @@ -0,0 +1,9 @@ +Title: stulz_humidity, apc_humidity: Fixed bug while processing check params +Level: 1 +Component: checks +Class: fix +State: unknown +Version: 1.2.5i1 +Date: 1389950905 + +The two checks interpreted warnlow as warncrit. diff --git a/ChangeLog b/ChangeLog index e8ec71a..c7f14ec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -111,6 +111,7 @@ * 0447 FIX: fortigate_memory: Fix inventory, do not add check if no info available... * 0567 FIX: apc_symmetra: transformation from old tuple to new dict format fixed and improved * 0432 FIX: stulz_humidity: Fixed syntax error... + * 0120 FIX: stulz_humidity, apc_humidity: Fixed bug while processing check params... Multisite: * 0371 Added log class filter to hostsvcevents view diff --git a/checks/apc_humidity b/checks/apc_humidity index bfccca9..8b2f7fb 100644 --- a/checks/apc_humidity +++ b/checks/apc_humidity @@ -35,7 +35,7 @@ def check_apc_humidity(item, params, info): for line in info: if line[0] == item: humidity = saveint(line[1]) - warnlow, critlow, warnhigh, crithigh = params + critlow, warnlow, warnhigh, crithigh = params infotext = "%s%% (warn/crit below %.1f/%.1f or above %.1f/%.1f %%)" % \ ( humidity, critlow, warnlow, warnhigh, crithigh) perfdata = [ ( "humidity", humidity, critlow, warnlow, warnhigh, crithigh ) ] diff --git a/checks/stulz_humidity b/checks/stulz_humidity index 3787ffe..d6b67c9 100644 --- a/checks/stulz_humidity +++ b/checks/stulz_humidity @@ -32,7 +32,7 @@ def inventory_stulz_humidity(info): def check_stulz_humidity(item, params, info): for line in info: if line[0] == item: - warnlow, critlow, warnhigh, crithigh = params + critlow, warnlow, warnhigh, crithigh = params humidity = savefloat(line[1])/10 infotext = "%s%% (warn/crit below %.1f/%.1f or above %.1f/%.1f %%)" % \ ( humidity, critlow, warnlow, warnhigh, crithigh)