2 Sep
2022
2 Sep
'22
7:53 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 0658200361a4fb3c15bf043452368e0d62d98fc4
https://github.com/tribe29/checkmk/commit/0658200361a4fb3c15bf043452368e0d6…
Author: Max Linke <max.linke(a)tribe29.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M cmk/gui/fields/__init__.py
M cmk/gui/fields/definitions.py
M cmk/gui/plugins/openapi/restful_objects/request_schemas.py
M cmk/gui/plugins/openapi/restful_objects/response_schemas.py
Log Message:
-----------
refactor REST API CustomAttributes
Those are specific to Host Attributes. So let the name reflect that.
Change-Id: Ifaa755498cd1d358d5a13ebdd5f11a28b5b93bbc
Commit: b130d6adbbc81548b76ca31742f1dd4ef5771bf6
https://github.com/tribe29/checkmk/commit/b130d6adbbc81548b76ca31742f1dd4ef…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M cmk/gui/livestatus_utils/testing.py
M tests/unit/conftest.py
Log Message:
-----------
Simplify mock_livestatus
* Extract request and application context from mock_livestatus
* Remove now useless with_context and with_html arguments
* Extract OMD_ROOT and OMD_SITE environment mocks to separate context
manager
Change-Id: I036cbedb63d78fab9380ea7ed07b3e5f561b9361
Commit: 4e647315f21769d8c3050eadcbc9a825858bc37c
https://github.com/tribe29/checkmk/commit/4e647315f21769d8c3050eadcbc9a8258…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M cmk/gui/livestatus_utils/commands/acknowledgments.py
M cmk/gui/livestatus_utils/commands/comment.py
M cmk/gui/livestatus_utils/commands/downtimes.py
M cmk/gui/livestatus_utils/commands/force_schedule.py
M cmk/gui/livestatus_utils/testing.py
M cmk/utils/livestatus_helpers/queries.py
M cmk/utils/livestatus_helpers/testing.py
Log Message:
-----------
Cleanup layer violation caused by livestatus mock
The mock_livestatus functionality provided by cmk.gui.livestatus_utils.testing was mixed
the mocking of two layers (cmk.gui.sites and livestatus). This
was also visible in doctests of cmk.utils.livestatus_helpers.queries.
They imported the cmk.gui module which is not allowed.
The functionality has now been separated:
cmk.gui.livestatus_utils.testing - Mocks cmk.gui and livestatus
cmk.utils.livestatus_helpers.testing - Mocks livestatus only
We are still with a questionable amount of doc tests in this area, but
for now I'll leave them in place for a later cleanup.
Change-Id: I5fadfa0f6d4f3b65d8d79f8afaaa4b7858371c55
Commit: 43b1097df0b17121fd39e2cc60cc9bb398d0ea37
https://github.com/tribe29/checkmk/commit/43b1097df0b17121fd39e2cc60cc9bb39…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
M tests/unit/cmk/gui/conftest.py
A tests/unit/cmk/gui/livestatus_utils/test_downtime_commands.py
A tests/unit/cmk/gui/livestatus_utils/test_testing.py
R tests/unit/cmk/utils/livestatus_helpers/conftest.py
R tests/unit/cmk/utils/livestatus_helpers/test_downtime_commands.py
M tests/unit/cmk/utils/livestatus_helpers/test_local_connection.py
M tests/unit/conftest.py
Log Message:
-----------
Separate mock_livestatus in unit tests
We now have two mock_livestatus fixtures:
a) The global fixture which is able to deal with LocalConnection (like
needed by all non-GUI tests) defined in the top level conftest.py.
b) The GUI specific mock_livestatus which cares about the GUI specific
cmk.gui.sites functionality.
This change also moves the test_downtime_commands to the correct test
tests/unit/cmk/gui path since the tests are testing GUI code. This move
cleans up a layer violation and makes several GUI initialization hacks
obsolete that are now automatically covered by the GUI test environment.
Change-Id: I435b6ba74b5b7ed666d4d955bfe39aa699cbb0f3
Commit: 07ea0431990509193efacb917e1d2776f5dfdc87
https://github.com/tribe29/checkmk/commit/07ea0431990509193efacb917e1d2776f…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2022-09-02 (Fri, 02 Sep 2022)
Changed paths:
A tests/testlib/plugin_registry.py
M tests/unit/cmk/gui/conftest.py
M tests/unit/conftest.py
Log Message:
-----------
Separate registry cleanups
Previously component specific registry cleanups of dcd and cmk.gui were
done by an autouse fixture for all unit tests which is way too generic.
The registries are all component specific and should therefore also only
be handled by component specific fixtures.
This change cleans up multiple cmk.gui imports from top level conftest
and also slightly improves the performance of non related unit tests.
Change-Id: I602568f3815a956290d7a4d6a08f50435b362304
Compare: https://github.com/tribe29/checkmk/compare/fbfe619eb2e7...07ea04319905