[checkmk-commits] [tribe29/checkmk] 3eddf9: Templatize DynamicRRDColumn, reducing tons of copy...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3eddf98c6cd30d273d2658cc13085bc3b3843fdd https://github.com/tribe29/checkmk/commit/3eddf98c6cd30d273d2658cc13085bc3b… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: R livestatus/src/DynamicHostRRDColumn.cc R livestatus/src/DynamicHostRRDColumn.h M livestatus/src/DynamicRRDColumn.h R livestatus/src/DynamicServiceRRDColumn.cc R livestatus/src/DynamicServiceRRDColumn.h M livestatus/src/Makefile.am M livestatus/src/TableHosts.cc M livestatus/src/TableServices.cc Log Message: ----------- Templatize DynamicRRDColumn, reducing tons of copy-n-paste. Change-Id: I67ef096d3a39f15de6d71f6fec90c64730790849 Commit: b6f327c622d9e1dc2b0e9bd7094ea13968f0f2cf https://github.com/tribe29/checkmk/commit/b6f327c622d9e1dc2b0e9bd7094ea1396… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/dashboard.py M cmk/gui/htmllib.py M cmk/gui/mobile.py M cmk/gui/pagetypes.py M cmk/gui/plugins/views/utils.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_views.py M tests/unit/cmk/gui/test_visuals.py A web/htdocs/themes/facelift/images/icon_download_json.png A web/htdocs/themes/facelift/images/icon_view_columns.png A web/htdocs/themes/facelift/images/icon_view_refresh.png Log Message: ----------- Introduce view page menu Basically replacing view._show_context_links with a page menu (view.GUIViewRenderer._page_menu). Start there when reviewing this change. To make this first step somehow usable this had to be done: * Move some of the remaining status icons to the view page menu * Untangle checkbox enable, enforce attributes and make them View properties * Transform "Add this visual to other visuals" popup to base on the page menu objects * Move refresh / number of columns options to other display options for more consistency. This also allows to drop a lot of special code (in the next steps)] Currently there are some things broken. This will be added in the next commits. Change-Id: I92d50b71f06ef106e0cb89d8e3a1d780cd78111f Commit: 9e7fefa08987be11be0064dbee34d02f889c4c66 https://github.com/tribe29/checkmk/commit/9e7fefa08987be11be0064dbee34d02f8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/views.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/views.js Log Message: ----------- Cleanup the now superfluous optiondial artifacts Change-Id: Ic99a095129b7363f62ed26e3604beb5c51ad7261 Commit: 580235119b6348f418fd896f77f97b86863ef1bd https://github.com/tribe29/checkmk/commit/580235119b6348f418fd896f77f97b868… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/page_menu.py Log Message: ----------- Page menu: Do not display empty topics Change-Id: If745ff3d86a5a0470f832cf88d2a7f22cf4b8de0 Commit: 6c57d6ef549e8c7df4aa2e92f9154ce296e7a60e https://github.com/tribe29/checkmk/commit/6c57d6ef549e8c7df4aa2e92f9154ce29… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/mobile.py M cmk/gui/plugins/views/utils.py M cmk/gui/views.py Log Message: ----------- Make view commands work again Also split up the command forms into separate menu entries. Change-Id: If0144f6caa7bf69ddddd573c34399cfe11d7d5ce Commit: 71a0ed45e0244b6eb3f8db3e6f3ee18c2853528d https://github.com/tribe29/checkmk/commit/71a0ed45e0244b6eb3f8db3e6f3ee18c2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/mobile.py M cmk/gui/node_visualization.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- Make filter form work again (The styling is totally broken for the moment) Change-Id: I7bb0ed5a3e2887ad88477babfb774e0e2ecac2d0 Commit: bbbea8ab2eddcb84d4aaeaa78bfadf1c0cb42e6d https://github.com/tribe29/checkmk/commit/bbbea8ab2eddcb84d4aaeaa78bfadf1c0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/plugins/views/builtin.py Log Message: ----------- Filter popup: Reduce previous standard filters of allhosts view Change-Id: Ic0a38dea5f39536a7c20d877b8970eeacbaa191e Commit: 6dc3d2d928927e9ca9b5e9e2cd05357a59171ae7 https://github.com/tribe29/checkmk/commit/6dc3d2d928927e9ca9b5e9e2cd05357a5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/htmllib.py Log Message: ----------- Dropdown choices can now be grouped Change-Id: I9e4a55ccba6271a0300baa043337d780743806a5 Commit: 7f00953139c9af77f1310bd817d90e54673d3971 https://github.com/tribe29/checkmk/commit/7f00953139c9af77f1310bd817d90e546… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/valuespec.py M cmk/gui/visuals.py M cmk/gui/wato/pages/users.py Log Message: ----------- Filter popup: Filter selection dropdown choices are now grouped by info Change-Id: I1a14d17f4943ce6efd488672108d26f8a0a19067 Commit: cda8e712eca1ec2c40a755c4f8cfb54360c47963 https://github.com/tribe29/checkmk/commit/cda8e712eca1ec2c40a755c4f8cfb5436… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/visuals.py Log Message: ----------- Fix AJAX page ajax_visual_filter_list_get_choice The AJAX page now accounts for the previously introduced grouping by "info" and does not return a result code of "1" anymore. Change-Id: I0f02ba7c08b6f369df722c7557e4f904648f8636 Commit: 9f60da1f2719c6e8cb70bd4fffd671f9736b4d82 https://github.com/tribe29/checkmk/commit/9f60da1f2719c6e8cb70bd4fffd671f97… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/node_visualization.py M cmk/gui/valuespec.py M cmk/gui/views.py M web/htdocs/js/modules/page_menu.js M web/htdocs/js/modules/utils.js M web/htdocs/js/modules/valuespecs.js M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_pages.scss Log Message: ----------- Add new filter form rendering Plus: * Unhackify a lot of CSS definitions * Remove several unused CSS definitions Change-Id: Id4db2dd2909ba325af047dc5eeafb8ac1128e846 Commit: f00cf107e562a688730d69cbfbe03aea58dec2e7 https://github.com/tribe29/checkmk/commit/f00cf107e562a688730d69cbfbe03aea5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M web/htdocs/js/modules/page_menu.js Log Message: ----------- Page menu: Fix closing of previously active popups Change-Id: I2125fef64cd6a64f7f89bc11966ac26fa1a082cf Commit: 5d76d7f589a26a8a7bb446c0f57570768e8d41a7 https://github.com/tribe29/checkmk/commit/5d76d7f589a26a8a7bb446c0f57570768… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/page_menu.py M cmk/gui/views.py M web/htdocs/js/modules/page_menu.js Log Message: ----------- Make filter form reachable via shortcut Change-Id: I73b7436c83bc07e861ff9ae9f1e09f5bef06a080 Commit: 20846e05510588238bf007222137a50aae069cc1 https://github.com/tribe29/checkmk/commit/20846e05510588238bf007222137a50aa… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/plugins/visuals/utils.py M cmk/gui/views.py Log Message: ----------- Filters can now be marked to be advanced elements Change-Id: Ie6201e9c4e9abcbcc068163804d5a379501aad4a Commit: c21cd012f8606a8df7b6e026d1a165cdb6ff882c https://github.com/tribe29/checkmk/commit/c21cd012f8606a8df7b6e026d1a165cdb… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/views.py Log Message: ----------- Unquote type hints Change-Id: Ic03db1ca84e1536677fc877ae646423b7d8f7560 Commit: 89af5f4c03da194053b3fdd251f049612bbe3923 https://github.com/tribe29/checkmk/commit/89af5f4c03da194053b3fdd251f049612… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/mobile.py M cmk/gui/views.py Log Message: ----------- Make collect_context_links procude PageMenuEntry Add type hints on the way Change-Id: I25ec56b20155c22597a30e70060e8548e8e8110f Commit: ededc7bf005207c8d13e76a4e84e057bd7bb5974 https://github.com/tribe29/checkmk/commit/ededc7bf005207c8d13e76a4e84e057bd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/views.py Log Message: ----------- Simplify conditionals Change-Id: Ie66438321fc090ab2f521387b27a6e5f0e407caa Commit: 30f162d6c5a0b153c84e34aa214f156bd8c3e8d6 https://github.com/tribe29/checkmk/commit/30f162d6c5a0b153c84e34aa214f156bd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-04 (Tue, 04 Aug 2020) Changed paths: M cmk/gui/views.py Log Message: ----------- Cleanup context link collection Separate the visual selection from the page menu entry rendering. Change-Id: Ibbc304c25ff6ca423faad65765d46536fef225fa Compare: https://github.com/tribe29/checkmk/compare/3ee7af9e24e1...30f162d6c5a0