[checkmk-commits] Additional rulespec logic cleanups

Module: check_mk Branch: master Commit: 294afb4605006857105ede65a2aad0366791a5ac URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=294afb46050068… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 23 16:55:10 2019 +0100 Additional rulespec logic cleanups * Moved get_by_group() from Rulespecs() to rulespec_registry * Removed get_rulespecs() method and replaced call sites with keys iteration * Removed get_rulespecs() method and replaced call sites with item access * Removed get() method and replaced calls with direct item access * Register rulespecs to rulespec_registry * Fixed compatibility to legacy registration * Finally removed g_rulespecs and Rulespecs class * Made Rulespec() a ABC for all future rulespec declarations CMK-1572 Change-Id: I8f6c72d15785a344d2b9562fb37e249fa3a90514 --- cmk/gui/wato/pages/check_catalog.py | 48 +++--- cmk/gui/wato/pages/object_parameters.py | 19 ++- cmk/gui/wato/pages/rulesets.py | 9 +- cmk/gui/wato/pages/services.py | 49 +++--- cmk/gui/watolib/__init__.py | 2 - cmk/gui/watolib/rulesets.py | 10 +- cmk/gui/watolib/rulespecs.py | 222 ++++++++++++++++----------- tests/unit/cmk/gui/watolib/test_rulespecs.py | 125 +++++++-------- 8 files changed, 265 insertions(+), 219 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=294afb4605…