[checkmk-commits] [tribe29/checkmk] f1aa7c: Fix minor typing issues

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f1aa7cde4bb51d899783352e8df6b692a7bc7a1c https://github.com/tribe29/checkmk/commit/f1aa7cde4bb51d899783352e8df6b692a… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/controller.py M tests/unit/cmk/fetchers/test_controller.py Log Message: ----------- Fix minor typing issues - Define `__add__()` and `__radd__()` to make the headers even more byte-like and remove some explicit conversion in callers. - Pass `FetcherMessage`s to `make_payload_answer()` to make the protocol layering finally explicit. - Misc small fixes. This is preparatory work for the next features. CMK-5472 Change-Id: Iab8925e9ce063f858d2373750156629b82cc1b45 Commit: 9dcbf1b2114ea9a5059676676617f2a1413eb8df https://github.com/tribe29/checkmk/commit/9dcbf1b2114ea9a5059676676617f2a14… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/controller.py M cmk/utils/type_defs.py Log Message: ----------- Generalize `Protocol` type This reduces code duplication and clarifies the code. Also, we need to have one more such class to serialize the errors and this reduces the number of methods we need to implement. CMK-5472 Change-Id: If47df4d7a63766dc84323c7c01b7ad52573cfa32 Commit: b4209123c465b50230b53e9a01f5b433259ec4b7 https://github.com/tribe29/checkmk/commit/b4209123c465b50230b53e9a01f5b4332… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/controller.py M tests/unit/cmk/fetchers/test_controller.py Log Message: ----------- Group error serialization/deserialization Putting serialization and deserialization close to each other makes understanding and maintaining the code simpler. This also decouples the representation from the business logic. We still need to special case our internal errors. CMK-5472 Change-Id: Ie7ad677a5fdbffbe85d7bb9dfc627d67fe0f4205 Commit: 1b55b312285e1e7d0ed2898f74c6224b7303c61e https://github.com/tribe29/checkmk/commit/1b55b312285e1e7d0ed2898f74c6224b7… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/controller.py M tests/unit/cmk/fetchers/test_controller.py Log Message: ----------- Privatize FetcherMessage._payload It does *not* do what you want. Change-Id: I5b4c7bd96b2a78c5be4fa7498adf0f865ddfc59d Compare: https://github.com/tribe29/checkmk/compare/3f59756c097f...1b55b312285e