[checkmk-commits] [tribe29/checkmk] 812625: Refactor failed notification to base on Page class

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8126256fec2366b05f815ade82d1617088f37630 https://github.com/tribe29/checkmk/commit/8126256fec2366b05f815ade82d161708… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/notifications.py Log Message: ----------- Refactor failed notification to base on Page class Also make some module local helpers private. Change-Id: I6435f6daa9e1ed34ceb6e9e68b901dc5b9e08e96 Commit: bc32469c357d87373688f56b2d72548717acc678 https://github.com/tribe29/checkmk/commit/bc32469c357d87373688f56b2d7254871… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/notifications.py M cmk/gui/plugins/dashboard/failed_notifications.py M cmk/gui/plugins/sidebar/tactical_overview.py Log Message: ----------- Add type hints And also separate number of failed notification computation from gathering the list of failed notifications to be able to get better return types. Change-Id: Icff306b1156f644b011b3fef0e8903587faba91d Commit: fb88a3a86d1f341fb23dc41c4f994e409811af6b https://github.com/tribe29/checkmk/commit/fb88a3a86d1f341fb23dc41c4f994e409… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-07-26 (Mon, 26 Jul 2021) Changed paths: M cmk/gui/notifications.py Log Message: ----------- Failed notifications: Cleanup module global state * Move the cached states to request globals * Storing the failed notification times per user is not necessary anymore, since we don't have a state that is kept for multiple users anymore. * The acknowledgement timestamp of the user and it's modification time belong together. Grouping them together in a single data structure. Change-Id: I9fb94e93c1700c95100e86d0de0a7f70c8e454bb Compare: https://github.com/tribe29/checkmk/compare/3f2a1ba5f6a4...fb88a3a86d1f