[checkmk-commits] [Checkmk/checkmk] 7f1603: Remove non-registration-related usage of GraphTemp...

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 7f16030837de33ab462805c5de6695fbe4b15396 https://github.com/Checkmk/checkmk/commit/7f16030837de33ab462805c5de6695fbe… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-07-17 (Mon, 17 Jul 2023) Changed paths: M cmk/gui/plugins/metrics/utils.py Log Message: ----------- Remove non-registration-related usage of GraphTemplate I GraphTemplate has LazyStrings, which we want to localize as early as possible, st. they don't cause problems in our pydantic models later on. We will achieve this in two steps: 1) Eliminate any non-registration-related instantiations of GraphTemplate (ie., call sites which do *not* register a graph template). 2) Wrap access to graph_info dictionary (aka graph template registry) into a function which does the localization and which converts from GraphTemplate to an internal representation. CMK-13986 Change-Id: Id8cc970184b81dec2a132909dbe49f71f0193d6f Commit: 05199699a0704b33f909cd98542fed417421220c https://github.com/Checkmk/checkmk/commit/05199699a0704b33f909cd98542fed417… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-07-17 (Mon, 17 Jul 2023) Changed paths: M cmk/gui/autocompleters.py M cmk/gui/dashboard/dashlet/dashlets/graph.py M cmk/gui/metrics.py M cmk/gui/plugins/metrics/graph_templates.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/type_defs.py M tests/unit/cmk/gui/plugins/metrics/test_graph_templates.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_graph_template.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py Log Message: ----------- Wrap access to graph_info (graph template registry) Internally, we now use a frozen dataclass to represent graph templates. All LazyStrings are localized when accessing the registry via the wrapper. Note that this is only an intermediate solution which has performance drawbacks. However, this will be resolved when introducing a proper registration mechanism for graph templates, which will absorb this functionality. CMK-13986 Change-Id: Ia15e4e82d59a286691a0e130e1d254400d3f7e24 Commit: dddcd94c6a8d78bd510728a4a43fa7c4bd746ad6 https://github.com/Checkmk/checkmk/commit/dddcd94c6a8d78bd510728a4a43fa7c4b… Author: Joerg Herbel <joerg.herbel(a)checkmk.com> Date: 2023-07-17 (Mon, 17 Jul 2023) Changed paths: M cmk/gui/plugins/metrics/artwork.py M cmk/gui/plugins/metrics/graph_pdf.py M cmk/gui/plugins/metrics/html_render.py Log Message: ----------- Pydantify GraphArtwork CMK-13986 Change-Id: Iceec012f3a56bc2e7b15c36001d5374ab67ea817 Compare: https://github.com/Checkmk/checkmk/compare/98481b93cf98...dddcd94c6a8d