[checkmk-commits] [tribe29/checkmk] 17e96d: Migrate Systemd units check plugin

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 17e96d63778d653b45a8a13b90a3e7e9bbb10919 https://github.com/tribe29/checkmk/commit/17e96d63778d653b45a8a13b90a3e7e9b… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: R checks/systemd_units A cmk/base/plugins/agent_based/systemd_units.py M tests/unit/checks/test_generic_legacy_conversion.py R tests/unit/checks/test_systemd_units.py A tests/unit/cmk/base/plugins/agent_based/test_systemd_units.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_plugin_vs_wato.py Log Message: ----------- Migrate Systemd units check plugin Change-Id: I2e6a0c6a44a82f584233a5c1a6b97133275a6bea Commit: f0d05822cb2fdc56f8c80e79c96121d8f75dbfdf https://github.com/tribe29/checkmk/commit/f0d05822cb2fdc56f8c80e79c96121d8f… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/systemd_units.py M tests/unit/cmk/base/plugins/agent_based/test_systemd_units.py Log Message: ----------- small refactorings Change-Id: I59ece1c32d2aac0ca7ba4f8e93082faddd7b4c1e Commit: 0d0045370ec026a301486a23488b888238732c4d https://github.com/tribe29/checkmk/commit/0d0045370ec026a301486a23488b88823… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/systemd_units.py Log Message: ----------- user f strings in systemd units checkplugin Change-Id: I83340716680abde574f63fd5781ee1decd4b5575 Commit: 2582e1f5cf7b1bc5159c4df13677951b289e34b2 https://github.com/tribe29/checkmk/commit/2582e1f5cf7b1bc5159c4df13677951b2… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/systemd_units.py Log Message: ----------- add typing hints Change-Id: I62a56bee17f23b20b6c0333b52aedde8c0d2383b Commit: f68b1daf8f179cd68a24b749fe4ae86d2c561eba https://github.com/tribe29/checkmk/commit/f68b1daf8f179cd68a24b749fe4ae86d2… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/systemd_units.py M tests/unit/cmk/base/plugins/agent_based/test_systemd_units.py Log Message: ----------- refactor systemd parsing algorithm prefer to use early returns Change-Id: I0d3fc533c6119b056f4f36692e034ec59721a21b Commit: 209fedc74a1874cbcb03c824170c21b86a94e858 https://github.com/tribe29/checkmk/commit/209fedc74a1874cbcb03c824170c21b86… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/systemd_units.py Log Message: ----------- refactor parsing function split into two separate functions. Make it clearer if to understand if we add a third section for status parsing. Change-Id: I60048ffa96299cf947fbbc08c4f00eeb03ea04cd Commit: 631f75a6e10c320fe08da134f75e7c4900e4594e https://github.com/tribe29/checkmk/commit/631f75a6e10c320fe08da134f75e7c490… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M agents/check_mk_agent.linux M cmk/base/plugins/agent_based/systemd_units.py M tests/unit/cmk/base/plugins/agent_based/test_systemd_units.py Log Message: ----------- Add explicit status parsing to systemd checks The 'systemctl status' command gives exact details how long a service has been in a given state. This is more precise than guessing ourselves from past observed states. Change-Id: Id06b88c50b7bd09617be54d3b3ff8ee04e7875f1 Commit: 9acbff98b34e1cfd2d380de90b45ac45e6494930 https://github.com/tribe29/checkmk/commit/9acbff98b34e1cfd2d380de90b45ac45e… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-25 (Mon, 25 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/systemd_units.py Log Message: ----------- Fix systemd services discovery the new api always adds an empty dict at the end of the params. An empty dict is equivalent to no filter for systemd service discovery. Replace the empty dict and be specific we do not want to filter anything. Change-Id: I97d0382140518d7f20005c487ee93c51ee23ffb2 Compare: https://github.com/tribe29/checkmk/compare/a2be7e59ac5c...9acbff98b34e