Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
65243 discussions

Check_MK Git: check_mk: apc_symmetra: handle empty SNMP variables and treat as 0

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 5960c0292581525420bcc60c6b6075b7ba10aaa5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5960c029258152… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Jan 12 15:16:28 2011 +0100 apc_symmetra: handle empty SNMP variables and treat as 0 --- ChangeLog | 3 +++ checks/apc_symmetra | 2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 52000ee..83b376f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,6 +10,9 @@ Livestatus: * Check for buffer overflows (replace strcat with strncat, etc.) + Checks & Agents: + * apc_symmetra: handle empty SNMP variables and treat as 0. + 1.1.9i3: INCOMPATIBLE CHANGES: * You need a current version of Livestatus for Multisite to work! diff --git a/checks/apc_symmetra b/checks/apc_symmetra index 221065d..f64d443 100644 --- a/checks/apc_symmetra +++ b/checks/apc_symmetra @@ -41,7 +41,7 @@ apc_default_levels = ( 95, 40, 1, 220 ) def check_apc(item, params, info): BasicBatteryStatus, BasicOutputStatus, AdvBatteryCapacity, \ AdvBatteryTemperature, AdvBatteryCurrent, AdvOutputVoltage, \ - AdvOutputCurrent = [int(x) for x in info[0][:7]] + AdvOutputCurrent = [ saveint(x) for x in info[0][:7] ] RunTimeRemaining = info[0][7] crit_capacity, crit_batt_temp, crit_batt_curr, crit_voltage = params

13 years, 9 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 01fa19b637aacac35301111d78a103d736bbe529 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=01fa19b637aaca… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Jan 12 08:10:46 2011 +0100 Updated bug entries --- .bugs/95 | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/.bugs/95 b/.bugs/95 new file mode 100644 index 0000000..3c436fa --- /dev/null +++ b/.bugs/95 @@ -0,0 +1,12 @@ +Title: Improve output of relative timestamps (since, ago, in) +Component: multisite +Benefit: 1 +State: open +Cost: 1 +Date: 2011-01-12 08:09:36 +Class: feature + +Sometimes it is not clear whether the time is in past or future, +for example on "last check" and "next scheduled check". The latter +one can happen to be in past. We might need to add 'in', 'since' +or 'ago'

13 years, 9 months

Check_MK Git: check_mk: bg: new option -v for gb grep

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3ebeabab9846259d1d5098c5d3a8f84b08dee38d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3ebeabab984625… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Jan 12 07:59:33 2011 +0100 bg: new option -v for gb grep --- gb | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/gb b/gb index 9e562f8..e6a1ff9 100755 --- a/gb +++ b/gb @@ -153,7 +153,7 @@ where COMMAND is one of: show [# #..] - show several bugs (or all open) resolve ID - change a bugs state delete #.. - delete bug(s) - grep WHAT... - grep in titles and descriptions + grep [-v] WHAT... - grep in titles and descriptions (-v: verbose) edit [#] - open bug # in editor (or newest bug) commit - commit all changed and new bugs @@ -377,8 +377,15 @@ def grep(line, kw): def main_grep(args): + if '-v' in args: + verbose = True + args = [ a for a in args if a != '-v' ] + else: + verbose = False + if len(args) == 0: usage() + for bug in g_bugs.values(): didmatch = False for kw in args: @@ -395,7 +402,8 @@ def main_grep(args): didmatch = True if didmatch: list_bug(bug) - sys.stdout.write(bodylines) + if verbose: + sys.stdout.write(bodylines) def main_edit(args): if len(args) == 0:

13 years, 9 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 5aed77a5dfd50bd120c5cbd641f4ae24207a4d01 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5aed77a5dfd50b… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Jan 12 08:03:24 2011 +0100 Updated bug entries --- .bugs/94 | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/.bugs/94 b/.bugs/94 new file mode 100644 index 0000000..eb8aa6c --- /dev/null +++ b/.bugs/94 @@ -0,0 +1,19 @@ +Title: View-Filter: der 1:1 Livestatus-Filter erzeugt +Component: multisite +Benefit: 3 +State: open +Cost: 2 +Date: 2011-01-12 07:59:58 +Class: feature + +Damit man beliebig komplexe Filterausdrücke machen kann, wäre es toll, wenn es +einen allgemeinen Filter gäbe, mit dem man beliebige Livestatus-Filter setzen +kann. Also einfach eine Textarea, in die man direkt Filter:, And: und Or: eingeben +kann. Aus Sicherheitsgründen muss man hier allerdings etwas parsen. Zum +einen dürfen Zeilen nur mit Filter:, And: und Or: beginnen. Zum anderen sollte +man noch soweit möglich die Syntax von Livestatus abfangen. Oder man könnte +mit Hilfe einer Testanfrage prüfen, ob der Filter syntaktisch in Ordnung ist. +Blöd ist halt, wenn im Nagioslog Fehlermeldungen auftauchen oder wenn eine +persistente Livestatusverbindung kaputtgeht. Das Parsen sollte also so sauber +wie möglich gehen. Der Test auf das Vorhandensein von bestimmten Spalten wäre +auch möglich, aber natürlich aufwändiger (z.B. über die Tabelle columns).

13 years, 9 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: b64b5ff81744775e78e40ecd817e654682e9aea0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b64b5ff8174477… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Jan 10 12:18:16 2011 +0100 Updated bug entries --- .bugs/93 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/93 b/.bugs/93 new file mode 100644 index 0000000..6898722 --- /dev/null +++ b/.bugs/93 @@ -0,0 +1,10 @@ +Title: Change PNPGraph and check man page in host/service detail +Component: multisite +Benefit: 1 +State: open +Cost: 1 +Date: 2011-01-10 12:17:15 +Class: feature + +The PNP graph should be listed before the man page, since it shows +run time information.

13 years, 9 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: cf526b3a4f15f11489b9aac55508ae4253fd20fa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cf526b3a4f15f1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Jan 9 16:30:51 2011 +0100 Updated bug entries --- .bugs/92 | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/.bugs/92 b/.bugs/92 new file mode 100644 index 0000000..b317a13 --- /dev/null +++ b/.bugs/92 @@ -0,0 +1,15 @@ +Title: Make snmp command configurable +Component: core +Benefit: 2 +State: open +Cost: 2 +Date: 2011-01-09 16:28:27 +Class: feature + +This could be like datasource_programs: snmpwalk_programs. It could +enable you to call snmpwalk via SSH and thus close a gap. Or it +could be a very flexible way for using custom SNMP parameters (such +as special port numbers). We need to introduce a few extra place +holders, like <OID> <COMMUNITY> or <AUTH> (which contains -c .... +or SNMPv3 stuff) <SNMPWALK> (which is either snmpwalk or snmpbulkwalk) +<SNMPCMD> (the complete command including all options) and so on...

13 years, 10 months

Check_MK Git: check_mk: Livestatus: fix the fix: pnpgraph detection

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d9922d6cdca367a4e4e0ad5da1bc80e5288edfb9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d9922d6cdca367… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 7 21:11:08 2011 +0100 Livestatus: fix the fix: pnpgraph detection the patch recently applied that replace strcat with strncat was broken and damaged the pnp path detection. I have done and alternative implemention. --- livestatus/src/pnp4nagios.cc | 16 +++++++++++----- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/livestatus/src/pnp4nagios.cc b/livestatus/src/pnp4nagios.cc index 20fd289..e8e72eb 100644 --- a/livestatus/src/pnp4nagios.cc +++ b/livestatus/src/pnp4nagios.cc @@ -44,19 +44,25 @@ int pnpgraph_present(char *host, char *service) return -1; char path[4096]; - strncpy(path, g_pnp_path, sizeof(path) - 1); + int needed_size = strlen(g_pnp_path) + strlen(host) + 16; + if (service) + needed_size += strlen(service); + if (needed_size > sizeof(path)) + return -1; + + strcpy(path, g_pnp_path); char *end = path + strlen(path); - strncpy(end, host, sizeof(end) - 1); + strcpy(end, host); cleanup_pnpname(end); - strncat(end, "/", sizeof(end) - strlen(end) - 1); + strcat(end, "/"); end = end + strlen(end); if (service) { - strncat(end, service, sizeof(end) - strlen(end) - 1); + strcat(end, service); cleanup_pnpname(end); strcat(end, ".xml"); } else - strncat(end, "_HOST_.xml", sizeof(end) - strlen(end) - 1); + strcat(end, "_HOST_.xml"); if (0 == access(path, R_OK)) return 1;

13 years, 10 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d5d48982e60bb9aa34304a186cad726100eab105 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d5d48982e60bb9… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sat Jan 8 16:53:12 2011 +0100 Updated bug entries --- .bugs/90 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/90 b/.bugs/90 new file mode 100644 index 0000000..8ab264b --- /dev/null +++ b/.bugs/90 @@ -0,0 +1,10 @@ +Title: Make topics in views snapin foldable +Component: multisite +Benefit: 3 +State: open +Cost: 2 +Date: 2011-01-08 16:50:52 +Class: feature + +Make the topics foldable like in the custom links snapin. The +folding state should be persistet on a per user basis.

13 years, 10 months

Check_MK Git: check_mk: Multisite: fix PNP icon url for multi sites

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 1fae71c9de291e06bf48a765cdce9d4778e360cd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1fae71c9de291e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 7 21:12:05 2011 +0100 Multisite: fix PNP icon url for multi sites --- web/plugins/views/painters.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index 6031e20..9e13488 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -128,7 +128,7 @@ def pnp_url(row, what = 'graph'): url = site["url_prefix"] + ("pnp4nagios/index.php/%s?host=%s&srv=%s" % \ (what, htmllib.urlencode(host), htmllib.urlencode(svc))) if what == 'graph': - url += "&theme=multisite&baseurl=%scheck_mk/" % htmllib.urlencode(defaults.url_prefix) + url += "&theme=multisite&baseurl=%scheck_mk/" % htmllib.urlencode(site["url_prefix"]) return url def pnp_popup_url(row):

13 years, 10 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d0dde4c580ba934d5ce58f74a2547e7ca4641df4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d0dde4c580ba93… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sat Jan 8 11:23:46 2011 +0100 Updated bug entries --- .bugs/89 | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/.bugs/89 b/.bugs/89 new file mode 100644 index 0000000..d829eb5 --- /dev/null +++ b/.bugs/89 @@ -0,0 +1,12 @@ +Title: bulletlink in sidebarsnapin: broken layout +Component: multisite +Benefit: 1 +State: open +Cost: 1 +Date: 2011-01-08 11:22:25 +Class: bug + +Since shortly the small blue bullets lefts to links +like in "Site status" are indented too much left (on +Firefox). This could be the effect of fixing this for +IE and Chrome.

13 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits