Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
65300 discussions

Check_MK Git: check_mk: Solaris agent: unset LANG, like in Linux agent

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 7b326bd31e3731cf8cc04510fc820a83909d3dbe URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7b326bd31e3731… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 22:52:48 2011 +0200 Solaris agent: unset LANG, like in Linux agent --- ChangeLog | 1 + agents/check_mk_agent.solaris | 4 ++++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 348678d..d2da9ee 100644 --- a/ChangeLog +++ b/ChangeLog @@ -25,6 +25,7 @@ * FIX: cisco_temp_perf: add critical level to performance data * FIX: windows agent: hopefully fix case with quotes in directory name * FIX: printer_supply: fixed logic of Perf-O-Meter (mixed up crit with ok) + * FIX: Solaris agent: reset localization to C, fixes problems with statgrab * snmp_uptime, snmp_info: added scan functions. These checks will now always be added. Please use ingored_checktypes to disable, if non needed. * brocade_port: check for Brocade FC ports has been rewritten with diff --git a/agents/check_mk_agent.solaris b/agents/check_mk_agent.solaris index 544842b..f1e04c7 100755 --- a/agents/check_mk_agent.solaris +++ b/agents/check_mk_agent.solaris @@ -23,6 +23,10 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. +# Remove locale settings to eliminate localized outputs where possible +export LC_ALL=C +unset LANG + MK_LIBDIR="/to/be/changed" MK_CONFDIR="/to/be/changed" export MK_LIBDIR MK_CONFDIR

13 years, 2 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 75691d6e197b36588823edfd8bc27b4e59ae6d4d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=75691d6e197b36… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 12:55:04 2011 +0200 Updated bug entries --- .bugs/231 | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/.bugs/231 b/.bugs/231 index 5af710c..e7f443a 100644 --- a/.bugs/231 +++ b/.bugs/231 @@ -1,4 +1,4 @@ -Title: do_rrd_update inkompatibel mit perfdata +Title: remove do_rrd_update completely Component: core Benefit: 1 State: open @@ -6,7 +6,17 @@ Cost: 3 Date: 2011-04-11 16:37:13 Class: nastiness -ich hatte sehr lange gesucht, warum bei mir die perfdata fuer nagvis und perf-o-meter kaputt war. es gab keine fehlermeldungen, an denen es nachvollziehbar war. ursache war do_rrd_update, nach entfernen der einstellung ging es sofort. -ich weiss leider nicht mehr, in welchem kontext ich die aktiviert hatte. -vermutlich ist die funktion aelter als das nagvis livestatus-be und die -perf-o-meter und das problem tritt so nur in alten installationen auf? +ich hatte sehr lange gesucht, warum bei mir die perfdata fuer nagvis und perf-o-meter kaputt +war. Es gab keine fehlermeldungen, an denen es nachvollziehbar war. ursache war do_rrd_update, +nach entfernen der einstellung ging es sofort. ich weiss leider nicht mehr, in welchem kontext +ich die aktiviert hatte. vermutlich ist die funktion aelter als das nagvis livestatus-be und +die perf-o-meter und das problem tritt so nur in alten installationen auf? + +Wenn do_rrd_update aktiv ist, kommen keine Perf-Daten beim Nagios mehr an. Dann geht +auch das Perf-O-Meter nicht. + + +=> do_rrd_update ganz rausschmeißen. Ist in Zeiten von rrdcached eh nicht mehr notwendig. + +=> Auch in den Migration-Notes vermerken und in der Doku anpassen. +

13 years, 2 months

Check_MK Git: check_mk: Cleaned bugs and documentation

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 33c4f6b025c59962a89788386fdd3b5fcf7e3ee7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=33c4f6b025c599… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 12:52:43 2011 +0200 Cleaned bugs and documentation --- .bugs/220 | 10 +++++++--- .bugs/311 | 13 +++++++++---- agents/check_mk_agent.linux | 5 +++-- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/.bugs/220 b/.bugs/220 index ad0547b..69b6536 100644 --- a/.bugs/220 +++ b/.bugs/220 @@ -1,10 +1,11 @@ Title: BI does not detect infinite recursions correctly Component: core +State: wontfix +Class: bug +Date: 2011-02-28 15:48:05 Benefit: 1 -State: open Cost: 1 -Date: 2011-02-28 15:48:05 -Class: bug +Fun: 0 At the moment BI does not catch direct loops (an object pointing to itselfs) or indirect loops (some childs object points back to a parent object). @@ -12,3 +13,6 @@ At the moment BI does not catch direct loops (an object pointing to itselfs) or In the first case the python error message is OK but in the second case the python error message is not very clear. + +2011-08-15 12:45:47: changed state open -> wontfix +Same as bug #204 diff --git a/.bugs/311 b/.bugs/311 index e7faede..c18822b 100644 --- a/.bugs/311 +++ b/.bugs/311 @@ -6,9 +6,14 @@ Cost: 4 Date: 2011-07-18 15:42:34 Class: nastiness -there is a very nasty issue with the IPMI agent code - we -kills the initial build of the SDR cache there will be no point in re-doing the scan and IPMI will be disabled forever. -The problem is that many IPMI modules are not able to handle concurrent requests. If building the SDR cache takes longer than 55+ seconds then we gh chance that a new check_mk_agent call happens via inetd. This second call will cause an IPMI issue which will cause the SDR cache scan to fail. +there is a very nasty issue with the IPMI agent code - if we kill the initial build of the SDR +cache there will be no point in re-doing the scan and IPMI will be disabled forever. The problem +is that many IPMI modules are not able to handle concurrent requests. If building the SDR cache +takes longer than 55+ seconds then there is a chance that a new check_mk_agent call happens via +inetd. This second call will cause an IPMI issue which will cause the SDR cache scan to fail. From that time on, IPMI will be disabled / broken. -Very ugly issue, maybe xinetd can disable multiple runs of the same service (but this would mean staleness issues will stop the agent forever) +Very ugly issue, maybe xinetd can disable multiple runs of the same service (but this would +mean staleness issues will stop the agent forever) + +Or we implement a caching feature similar to that of <<<ipmitool>>>. diff --git a/agents/check_mk_agent.linux b/agents/check_mk_agent.linux index d11c237..e3bd113 100755 --- a/agents/check_mk_agent.linux +++ b/agents/check_mk_agent.linux @@ -187,10 +187,11 @@ if which ipmitool >/dev/null then echo '<<<ipmi>>>' IPMI_FILE=$MK_CONFDIR/ipmitool_sensors.cache - # Use cache file after 20 minutes + + # Do not use cache file after 20 minutes IPMI_MAXAGE=1200 - # Check if file exists and recent enough + # Check if file exists and is recent enough if [ -s $IPMI_FILE ] then NOW=$(date +%s)

13 years, 2 months

Check_MK Git: check_mk: FIX: debug mode of windows agent working again

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: b6503c94042db48fe4a16f55414f217755d2e167 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b6503c94042db4… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 12:44:45 2011 +0200 FIX: debug mode of windows agent working again --- .bugs/187 | 10 +++++++--- agents/windows/check_mk_agent.cc | 9 ++++----- agents/windows/check_mk_agent.exe | Bin 96768 -> 96768 bytes 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/.bugs/187 b/.bugs/187 index 627f71a..996dd24 100644 --- a/.bugs/187 +++ b/.bugs/187 @@ -1,11 +1,15 @@ Title: Windows Agent Debug Modus funktiert nicht Component: core +State: done +Class: bug +Date: 2011-06-30 11:46:51 Benefit: 1 -State: open Cost: 3 -Date: 2011-06-30 11:46:51 -Class: bug +Fun: 0 Auf einem Windows 2000 SP4 System getestet: Der Debug-Modus liefert keine Ausgabe. + +2011-08-15 12:44:27: changed state open -> done +Geht jetzt wieder. diff --git a/agents/windows/check_mk_agent.cc b/agents/windows/check_mk_agent.cc index ecef22c..a8ccabc 100755 --- a/agents/windows/check_mk_agent.cc +++ b/agents/windows/check_mk_agent.cc @@ -1263,7 +1263,7 @@ void listen_tcp_loop() SOCKET connection; // Loop for ever. - debug("Die Schleife gestartet."); + debug("Starting main loop."); while (!should_terminate) { // Das Dreckswindows kann nicht vernuenftig gleichzeitig auf @@ -1488,11 +1488,10 @@ void do_debug() { verbose_mode = true; do_tcp = false; - logwatch_send_initial_entries = true; - logwatch_suppress_info = false; + // logwatch_send_initial_entries = true; + // logwatch_suppress_info = false; SOCKET dummy; - find_eventlogs(dummy); - //section_eventlog(dummy); + output_data(dummy); } void do_adhoc() diff --git a/agents/windows/check_mk_agent.exe b/agents/windows/check_mk_agent.exe index fff041c..edf623a 100755 Binary files a/agents/windows/check_mk_agent.exe and b/agents/windows/check_mk_agent.exe differ

13 years, 2 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: e99e9ec17985b30e048a0692063cb6131f461c26 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e99e9ec17985b3… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 11:17:17 2011 +0200 Updated bug entries --- .bugs/323 | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.bugs/323 b/.bugs/323 index e9ba1f0..7a24b35 100644 --- a/.bugs/323 +++ b/.bugs/323 @@ -1,11 +1,15 @@ Title: Service with Non-Ascii-Characters do not work Component: bi +State: done +Class: bug +Date: 2011-08-14 16:17:13 Benefit: 1 -State: open Cost: 1 -Date: 2011-08-14 16:17:13 -Class: bug +Fun: 0 Problems are (maybe not only) - Link to Service details - Assumption button not working + +2011-08-15 11:17:13: changed state open -> done +Use var_utf8() in filter instead of var()

13 years, 2 months

Check_MK Git: check_mk: FIX: filter aggr_service was not being displayed

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 512c77fb19f044c1117af901fcb1cb332897ef3a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=512c77fb19f044… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 11:13:34 2011 +0200 FIX: filter aggr_service was not being displayed --- web/plugins/views/bi.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/plugins/views/bi.py b/web/plugins/views/bi.py index 7a98af3..8705dae 100644 --- a/web/plugins/views/bi.py +++ b/web/plugins/views/bi.py @@ -476,7 +476,7 @@ declare_filter(130, BIHostFilter(), _("Filter for all aggregations that base on class BIServiceFilter(Filter): def __init__(self): - Filter.__init__(self, "aggr_service", _("Affected by service"), "host", ["site", "host", "service"], []) + Filter.__init__(self, "aggr_service", _("Affected by service"), "aggr", ["site", "host", "service"], []) def display(self): html.write(_("Host") + ": ")

13 years, 2 months

Check_MK Git: check_mk: BI: fix aggr_service filter for non-ASCII services

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 8efce75a988b71e998666e7d41e62ff23897537e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8efce75a988b71… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 11:16:48 2011 +0200 BI: fix aggr_service filter for non-ASCII services --- web/htdocs/bi.py | 1 + web/plugins/views/bi.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/web/htdocs/bi.py b/web/htdocs/bi.py index dc8b211..83d2c4b 100644 --- a/web/htdocs/bi.py +++ b/web/htdocs/bi.py @@ -227,6 +227,7 @@ def compile_forest(user): g_cache[user] = cache + # Execute an aggregation rule, but prepare arguments # and iterate FOREACH first def compile_rule_node(calllist, lvl): diff --git a/web/plugins/views/bi.py b/web/plugins/views/bi.py index 8705dae..dcab308 100644 --- a/web/plugins/views/bi.py +++ b/web/plugins/views/bi.py @@ -485,10 +485,10 @@ class BIServiceFilter(Filter): html.text_input("service") def heading_info(self, infoname): - return html.var("host") + " / " + html.var("service") + return html.var_utf8("host") + " / " + html.var_utf8("service") def service_spec(self): - return html.var("site"), html.var("host"), html.var("service") + return html.var_utf8("site"), html.var_utf8("host"), html.var_utf8("service") # Used for linking def variable_settings(self, row):

13 years, 2 months

Check_MK Git: check_mk: Fixed inline comment

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 884c166c82a24bd01f0ec2a2fdf6d84a35faf04d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=884c166c82a24b… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 10:37:21 2011 +0200 Fixed inline comment --- web/htdocs/js/check_mk.js | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/web/htdocs/js/check_mk.js b/web/htdocs/js/check_mk.js index dae749a..6ea8f72 100644 --- a/web/htdocs/js/check_mk.js +++ b/web/htdocs/js/check_mk.js @@ -655,7 +655,6 @@ function toggle_assumption(oImg, site, host, service) else current = parseInt(current) + 1; - // TODO: This needs to be URL-encoded. Also test for non-Ascii-Characters! var url = "bi_set_assumption.py?site=" + encodeURIComponent(site) + '&host=' + encodeURIComponent(host); if (service) {

13 years, 2 months

Check_MK Git: check_mk: FIX: fixed display of filters in Edit view

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 33b23c99fec6cd21c5c8c8ebf14671c0f260fa03 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=33b23c99fec6cd… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Aug 15 11:05:50 2011 +0200 FIX: fixed display of filters in Edit view --- web/htdocs/js/check_mk.js | 4 ++++ web/htdocs/views.py | 4 +++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/web/htdocs/js/check_mk.js b/web/htdocs/js/check_mk.js index 6ea8f72..75f330d 100644 --- a/web/htdocs/js/check_mk.js +++ b/web/htdocs/js/check_mk.js @@ -158,6 +158,10 @@ function pageWidth() { function filter_activation(oid) { var selectobject = document.getElementById(oid); + if (!selectobject) { + alert("Could not find element " + oid + "!"); + return; + } var usage = selectobject.value; var oTd = selectobject.parentNode.parentNode.childNodes[2]; var pTd = selectobject.parentNode; diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 4539e10..ee3306e 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -615,9 +615,11 @@ function toggle_section(nr, oImg) { html.write("</tt></td>") html.write("</tr>\n") html.write("</table>\n") + # Set all filters into the proper display state html.write("<script language=\"javascript\">\n") for fname, filt in allowed_filters.items(): - html.write("filter_activation(\"filter_%s\");\n" % fname) + if fname not in ubiquitary_filters: + html.write("filter_activation(\"filter_%s\");\n" % fname) html.write("</script>\n") section_footer(sid)

13 years, 2 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 535d20aef45823ee3af1f8c8d6e56035d86382be URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=535d20aef45823… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Aug 14 16:07:49 2011 +0200 Updated bug entries --- .bugs/184 | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.bugs/184 b/.bugs/184 index f2a25db..38c2ece 100644 --- a/.bugs/184 +++ b/.bugs/184 @@ -1,10 +1,11 @@ Title: if/if64 problem when using description as item when having duplicate descr Component: checks +State: done +Class: bug +Date: 2011-03-25 09:39:07 Benefit: 2 -State: open Cost: 2 -Date: 2011-03-25 09:39:07 -Class: bug +Fun: 0 Der if/if64 Check unterschlägt doppelte Interfaces, wenn ein Host mehrere Interfaces mit dem gleichen Namen hat, sobald man die Description als Item benutzt. @@ -16,3 +17,7 @@ später eine re-Inventur macht mit aktivierten Descriptions. Eventuell muss man das in der Inventur erkennen und dann die Interfaces selbs durchnummerieren. LM: Ich habe einen Dump von einem Beispiel-System. + +2011-08-14 16:07:42: changed state open -> done +Das sollte inzwischen gehen. Wenn die Inventur gleiche Namen findet, +hängt sich automatisch die SNMP End-OID hinten dran.

13 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits