Module: check_mk
Branch: master
Commit: d52c3ade2babf64c02b1c6115ac24a810e5cf901
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d52c3ade2babf6…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Fri Feb 25 15:51:23 2011 +0100
Added perf-o-meter for h3c_lanswitch_cpu
---
README.writing_checks | 4 +++-
web/plugins/perfometer/check_mk.py | 15 +++++++++++++++
2 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/README.writing_checks b/README.writing_checks
index 0e22d34..21771b0 100644
--- a/README.writing_checks
+++ b/README.writing_checks
@@ -134,7 +134,9 @@ Performance data:
graph in its current (and maybe future) forms. Those are in pnp-rraconf.
Use a symlink here.
-* pnp rra configuration
+* Each check that outputs performance data should have a perf-o-meter.
+ For checks part of Check_MK this must be done in web/plugins/perfometer/check_mk.py.
+ For third party checks this should be done in a separate file in web/plugins/perfometer.
SNMP based checks:
* Only use numeric OIDs in your checks. Name based OIDs rely on MIB files
diff --git a/web/plugins/perfometer/check_mk.py b/web/plugins/perfometer/check_mk.py
index 28deb9c..8f6e0cd 100644
--- a/web/plugins/perfometer/check_mk.py
+++ b/web/plugins/perfometer/check_mk.py
@@ -241,3 +241,18 @@ def perfometer_oracle_sessions(row, check_command, perf_data):
perfometers["check_mk-oracle_sessions"] = perfometer_oracle_sessions
perfometers["check_mk-oracle_logswitches"] = perfometer_oracle_sessions
+def perfometer_h3c_lanswitch_cpu(row, check_command, perf_data):
+ util = float(perf_data[0][1]) # is already percentage
+ warn = float(perf_data[0][3])
+ crit = float(perf_data[0][4])
+ if util < warn:
+ color = "#6f2"
+ elif util < crit:
+ color = "#9f2"
+ else:
+ color = "#cf2"
+
+ return "%.0f%%" % util, perfometer_linear(util, color)
+
+#perfometer_linear(perc, color)
+perfometers["check_mk-h3c_lanswitch_cpu"] = perfometer_h3c_lanswitch_cpu
Module: check_mk
Branch: master
Commit: 1d83f6081d2676961c4c004f11e57693b2816758
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1d83f6081d2676…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Fri Feb 25 15:51:51 2011 +0100
Added perf-o-meter for h3c_lanswitch_cpu
---
README.writing_checks | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/README.writing_checks b/README.writing_checks
index 21771b0..b473704 100644
--- a/README.writing_checks
+++ b/README.writing_checks
@@ -59,8 +59,9 @@ Coding style
must return None as parameter and the check function must name
the parameter argument _no_params.
-* The name of the inventory and check function must be prefixed with the name of the check type, for example inventory_h3c_lanswitch_cpu
- for 'h3c_lanswitch'
+* The name of the inventory and check function must be
+ prefixed with the name of the check type, for example
+ inventory_h3c_lanswitch_cpu for 'h3c_lanswitch'
* Order of implementation:
Module: check_mk
Branch: master
Commit: 48583b397f622707e663d3991e117367a02841a5
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=48583b397f6227…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Feb 25 15:48:18 2011 +0100
Updated bug entries
---
.bugs/111 | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/.bugs/111 b/.bugs/111
index 117e19c..fa23cc2 100644
--- a/.bugs/111
+++ b/.bugs/111
@@ -1,11 +1,15 @@
Title: View editor does not save tool tips (in group header)
Component: multisite
+State: done
+Class: bug
+Date: 2011-01-27 17:02:58
Benefit: 2
-State: open
Cost: 1
-Date: 2011-01-27 17:02:58
-Class: bug
+Fun: 0
When you add tooltips to a group column in the view editor,
the tooltip is not saved. This might appear at normal columns
also, but is not tested.
+
+2011-02-25 15:48:13: changed state open -> done
+The tooltips work now in group headers
Module: check_mk
Branch: master
Commit: 91b8d5925e0d04b7c1caf60515c8f47e2d765050
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=91b8d5925e0d04…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Feb 25 15:47:02 2011 +0100
Multisite: Tooltips work in group headers now
---
ChangeLog | 1 +
web/htdocs/views.py | 11 ++++++-----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 4b37776..38a100e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -38,6 +38,7 @@
* FIX: Customlinks snapin persists folding states again
* FIX: PNP timerange painter option field takes selected value as default now
* FIX: Fixed perfometer styling in single dataset layouts
+ * FIX: Tooltips work in group headers now
WATO:
* FIX: fix problem with vanishing services on Windows. Affected were services
diff --git a/web/htdocs/views.py b/web/htdocs/views.py
index 88f30e7..e8c9498 100644
--- a/web/htdocs/views.py
+++ b/web/htdocs/views.py
@@ -868,10 +868,11 @@ def create_view():
for n in range(1, 500):
pname = html.var("group_%d" % n)
viewname = html.var("group_link_%d" % n)
+ tooltip = html.var("group_tooltip_%d" % n)
if pname:
if viewname not in html.available_views:
viewname = None
- group_painternames.append((pname, viewname))
+ group_painternames.append((pname, viewname, tooltip))
painternames = []
# User can set more than max_display_columns. We cannot easily know
@@ -1902,7 +1903,7 @@ def prepare_paint(p, row):
content = link_to_view(content, row, linkview)
# Tooltip
- if tooltip:
+ if content != '' and tooltip:
cla, txt = multisite_painters[tooltip]["paint"](row)
tooltiptext = htmllib.strip_tags(txt)
content = '<span title="%s">%s</span>' % (tooltiptext, content)
@@ -1957,12 +1958,12 @@ def register_events(row):
# two rows are in the same group or not
def group_value(row, group_painters):
group = []
- for p, l in group_painters:
- groupvalfunc = p.get("groupby")
+ for p in group_painters:
+ groupvalfunc = p[0].get("groupby")
if groupvalfunc:
group.append(groupvalfunc(row))
else:
- for c in p["columns"]:
+ for c in p[0]["columns"]:
group.append(row[c])
return group
Module: check_mk
Branch: master
Commit: 99d47425d8e7c539bc77d12721d144a91ea5726d
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=99d47425d8e7c5…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Feb 25 14:54:16 2011 +0100
Updated bug entries
---
.bugs/150 | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/.bugs/150 b/.bugs/150
index e0d0cff..86ecc51 100644
--- a/.bugs/150
+++ b/.bugs/150
@@ -1,13 +1,17 @@
Title: Display options show wrong value at start
Component: multisite
+State: done
+Class: bug
+Date: 2011-02-18 09:44:34
Benefit: 1
-State: open
Cost: 1
-Date: 2011-02-18 09:44:34
-Class: bug
+Fun: 0
When you enter a view where the display options for the PNP timerange
had been set to 4 hours (which is persistet), then the graphs are
showing 4 hours. Good. But when you open the tab "Display Options",
the dropdown is preset to 25h (which is the default), rather then
to 4h (which is the current setting).
+
+2011-02-25 14:54:12: changed state open -> done
+Fixed. Using get_painter_option function now to retrieve the configured value