Module: check_mk
Branch: master
Commit: 04b537e9d01d3540dd8e831e82c1ac840a7e9366
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=04b537e9d01d35…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Tue Aug 23 15:34:25 2011 +0200
View editor: warn if no column has been added
---
.bugs/49 | 10 +++++++---
web/htdocs/views.py | 5 ++++-
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/.bugs/49 b/.bugs/49
index ab4e084..3f75c85 100644
--- a/.bugs/49
+++ b/.bugs/49
@@ -1,11 +1,15 @@
Title: View editor: Warnung, wenn keine Spalten ausgewählt
Component: multisite
+State: done
+Class: nastiness
+Date: 2010-12-21 21:31:11
Benefit: 1
-State: open
Cost: 1
-Date: 2010-12-21 21:31:11
-Class: nastiness
+Fun: 0
Wenn der Benutzer keine einzige Spalte ausgewält hat, darf
er die View nicht speichern können. Es gab schon User, die sich
gewundert haben, dass sie nix sehen.
+
+2011-08-23 15:33:19: changed state open -> done
+Jetzt gibts eine Fehlermeldung, wenn man keine Spalte hat.
diff --git a/web/htdocs/views.py b/web/htdocs/views.py
index 74be45a..1c4f392 100644
--- a/web/htdocs/views.py
+++ b/web/htdocs/views.py
@@ -496,7 +496,7 @@ def page_edit_view():
if oldname and oldname != view["name"] and (html.req.user, oldname) in html.multisite_views:
del html.multisite_views[(html.req.user, oldname)]
save_views(html.req.user)
- return page_message_and_forward("Your view has been saved.", "edit_views.py",
+ return page_message_and_forward(_("Your view has been saved."), "edit_views.py",
"<script type='text/javascript'>top.frames[0].location.reload();</script>\n")
except MKUserError, e:
@@ -965,6 +965,9 @@ def create_view():
else:
painternames.append((pname, viewname, tooltip))
+ if len(painternames) == 0:
+ raise MKUserError("col_1", _("Please add at least one column to your view."))
+
return {
"name" : name,
"owner" : html.req.user,
Module: check_mk
Branch: master
Commit: 97c583a3c81e63bb72cc68687489db479476e039
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=97c583a3c81e63…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Tue Aug 23 00:05:26 2011 +0200
Updated bug entries
---
.bugs/112 | 7 ++++---
.bugs/183 | 13 ++++++++++---
.bugs/208 | 5 +++++
.bugs/28 | 2 +-
4 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/.bugs/112 b/.bugs/112
index dc0ba39..ca50fe4 100644
--- a/.bugs/112
+++ b/.bugs/112
@@ -1,10 +1,11 @@
Title: PNP-Links in Perf-O-Meter should be intelligent
Component: multisite
-Benefit: 1
State: open
-Cost: 1
-Date: 2011-01-28 09:34:33
Class: cleanup
+Date: 2011-01-28 09:34:33
+Benefit: 1
+Cost: 1
+Fun: 0
If there is no PNP database the perfometer should not contain a hlink
to PNP. We can use the same logic as in the intelligent PNP icon.
diff --git a/.bugs/183 b/.bugs/183
index 6647e82..eed8e9a 100644
--- a/.bugs/183
+++ b/.bugs/183
@@ -1,10 +1,10 @@
-Title: bluecoat_sensors pnp links/hover menus are broken
+Title: Services with + in their names break PNP links
Component: multisite
Benefit: 2
-State: open
+State: wontfix
Cost: 3
Date: 2011-03-22 15:25:58
-Class: cleanup
+Class: bug
The bluecoat sensors check creates checks with plus signs in the name, eg +12V bus voltage.
This seems to break the links/hovers to pnp. This might also be a problem in pnp.
@@ -12,3 +12,10 @@ This seems to break the links/hovers to pnp. This might also be a problem in pnp
The rrd files are named '+12V_bus_voltage.rrd'.
Need to be analyzed.
+
+2011-08-22 16:44:03: changed state open -> wontfix
+This seems to be a bug in PNP. Even in the PNP native
+GUI services with a + in the name do not work. I've
+contacted Jörg Linge...
+~
+
diff --git a/.bugs/208 b/.bugs/208
index 6b31dae..21a3a46 100644
--- a/.bugs/208
+++ b/.bugs/208
@@ -8,3 +8,8 @@ Class: cleanup
The article about filesystems should contain all information about
trends. Also hints to the various filesystem checks.
+
+Read also bug #208. And please check out, why the Demoserver
+show so nasty steps in the trend graphs...
+~
+
diff --git a/.bugs/28 b/.bugs/28
index 2049666..b783d48 100644
--- a/.bugs/28
+++ b/.bugs/28
@@ -4,7 +4,7 @@ Benefit: 2
State: open
Cost: 4
Date: 2010-12-21 16:41:20
-Class: feature
+Class: nastiness
Dazu müsste man aber erstmal rausfinden, wie man bei Windows
dies anstellt. Es hängt ja von der Landeseinstellung ab. Vielleicht