Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64160 discussions

Check_MK Git: check_mk: Top buttons recognizing search filter now

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: bef81a57d7bf4e94108eb3e4d4134c2a788fd0c3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bef81a57d7bf4e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 13:04:03 2011 +0200 Top buttons recognizing search filter now --- web/htdocs/wato.py | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 2fef9db..09342b9 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -655,7 +655,8 @@ def mode_file(phase): # a folder information but not yet moved to that folder). If at least # one host has a target folder, then we show an additional bulk action. at_least_one_imported = False - for hostname in hostnames: + more_than_ten_items = False + for num, hostname in enumerate(hostnames): if search_text and (search_text.lower() not in hostname.lower()): continue @@ -665,9 +666,12 @@ def mode_file(phase): if effective.get("imported_folder"): at_least_one_imported = True + if num == 11: + more_than_ten_items = True + # Add the bulk action buttons also to the top of the table when this # list shows more than 10 rows - if len(hostnames) > 10: + if more_than_ten_items: bulk_actions(at_least_one_imported) for hostname in hostnames:

13 years

Check_MK Git: check_mk: Changed row selection in WATO to new row selection mechanism

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 8f18f6296452d459a23c7f631fc8a0a70239ce21 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8f18f6296452d4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 12:46:35 2011 +0200 Changed row selection in WATO to new row selection mechanism --- ChangeLog | 1 + web/htdocs/htmllib.py | 10 ++++++++++ web/htdocs/js/check_mk.js | 13 ++++++++++--- web/htdocs/wato.py | 29 ++++++++++++++--------------- web/plugins/views/layouts.py | 12 ++---------- 5 files changed, 37 insertions(+), 28 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0398110..b3ab8c9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -16,6 +16,7 @@ * Added missing sorters for "service nth service perfdata" painters * Implemented row selection in views to select only a subset of shown data for actions + * Changed row selection in WATO to new row selection mechanism 1.1.11i3: Core, Setup, etc.: diff --git a/web/htdocs/htmllib.py b/web/htdocs/htmllib.py index c9cbc4d..9de3262 100644 --- a/web/htdocs/htmllib.py +++ b/web/htdocs/htmllib.py @@ -790,3 +790,13 @@ class html: def end_foldable_container(self): self.write("</ul>") + + def init_rowselect(self): + selected = [] + if self.has_var('selected_rows'): + selected_rows = self.var('selected_rows', '') + if selected_rows or ',' in selected_rows: + selected = selected_rows.split(',') + + self.javascript('g_selected_rows = %s;\n' + 'init_rowselect();' % repr(selected)) diff --git a/web/htdocs/js/check_mk.js b/web/htdocs/js/check_mk.js index 18272db..a19595c 100644 --- a/web/htdocs/js/check_mk.js +++ b/web/htdocs/js/check_mk.js @@ -915,7 +915,10 @@ function real_style(obj, attr) { // If elem is a TD and has no background find the backround of the parent // e.g. the TR and then set this color as background for the TD - if(obj.tagName == 'TD' && (st == 'transparent' || st == 'rgba(0, 0, 0, 0)')) + // But only do this when the TR is not in the highlight scope + if(obj.tagName == 'TD' + && obj.parentNode.row_num === undefined + && (st == 'transparent' || st == 'rgba(0, 0, 0, 0)')) st = real_style(obj.parentNode, attr); return st; @@ -1046,7 +1049,9 @@ function toggle_all_rows() { var all_selected = true; for(var i = 0; i < elems.length && all_selected == true; i++) { - if(elems[i].tagName != 'TD' && elems[i].tagName != 'DIV') + if(elems[i].tagName != 'TD' + && elems[i].tagName != 'TR' + && elems[i].tagName != 'DIV') continue; if(g_selected_rows.indexOf(elems[i].row_num) === -1) @@ -1075,7 +1080,9 @@ function table_init_rowselect(oTable) { var childs = document.getElementsByClassName('dr'); for(var i = 0; i < childs.length; i++) { - if(childs[i].tagName != 'TD' && childs[i].tagName != 'DIV') + if(childs[i].tagName != 'TD' + && childs[i].tagName != 'TR' + && childs[i].tagName != 'DIV') continue; var elem = childs[i]; diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index cd13efa..6f10be4 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -621,10 +621,10 @@ def mode_file(phase): # Show table of hosts in this file colspan = 5 - html.begin_form("hosts", None, "POST") + html.begin_form("hosts", None, "POST", onsubmit = 'add_row_selections(this);') html.write("<table class=data>\n") - html.write("<tr><th class=left></th><th></th><th>" + _("Hostname") + "</th>") - + html.write("<tr><th class=left></th><th>" + _("Hostname") + "</th>") + for attr, topic in host_attributes: if attr.show_in_table(): html.write("<th>%s</th>" % attr.title()) @@ -635,7 +635,6 @@ def mode_file(phase): odd = "odd" search_text = html.var("search") - selected_hosts = get_hostnames_from_checkboxes() at_least_one_imported = False for hostname in hostnames: if search_text and (search_text.lower() not in hostname.lower()): @@ -645,15 +644,9 @@ def mode_file(phase): effective = effective_attributes(host, g_file) # Rows with alternating odd/even styles - html.write('<tr class="data %s0">' % odd) + html.write('<tr class="dr_%s dr data %s0">' % (hostname, odd)) odd = odd == "odd" and "even" or "odd" - # Check box (if none is checked, then the default is to check all) - def_value = selected_hosts == [] - html.write("<td class=select>") - html.checkbox("sel_%s" % hostname, def_value, 'wato_select') - html.write("</td>") - # Column with actions (buttons) edit_url = make_link([("mode", "edithost"), ("host", hostname)]) services_url = make_link([("mode", "inventory"), ("host", hostname)]) @@ -697,9 +690,9 @@ def mode_file(phase): # bulk actions - html.write('<tr class="data %s0"><td class=select>' % odd) - html.jsbutton('_markall', 'X', 'javascript:wato_check_all(\'wato_select\');') - html.write("</td><td colspan=%d>" % colspan) + html.write('<tr class="data %s0">' % odd) + html.write("<td colspan=%d>" % colspan) + html.jsbutton('_markall', 'X', 'javascript:toggle_all_rows();') html.write(_("On all selected hosts:\n")) html.button("_bulk_delete", _("Delete")) html.button("_bulk_edit", _("Edit")) @@ -721,16 +714,22 @@ def mode_file(phase): html.hidden_fields() html.end_form() + html.init_rowselect() # Create list of all hosts that are select with checkboxes in the current file def get_hostnames_from_checkboxes(): hostnames = g_hosts.keys() hostnames.sort() + + selected = [] + if html.var('selected_rows', '') != '': + selected = html.var('selected_rows', '').split(',') + selected_hosts = [] search_text = html.var("search") for name in hostnames: if (not search_text or (search_text.lower() in name.lower())) \ - and html.var("sel_" + name): + and name in selected: selected_hosts.append(name) return selected_hosts diff --git a/web/plugins/views/layouts.py b/web/plugins/views/layouts.py index 6f17cc5..104f6b4 100644 --- a/web/plugins/views/layouts.py +++ b/web/plugins/views/layouts.py @@ -28,15 +28,7 @@ def init_rowselect(): # Don't make rows selectable when no commands can be fired if not 'C' in html.display_options or not config.may("act"): return - - row_nums = [] - if html.has_var('selected_rows'): - selected_rows = html.var('selected_rows', '') - if selected_rows or ',' in selected_rows: - row_nums = selected_rows.split(',') - - html.javascript('g_selected_rows = %s;\n' - 'init_rowselect();' % repr(row_nums)) + html.init_rowselect() # ------------------------------------------------------------------------- # ____ _ _ @@ -253,7 +245,7 @@ def render_tiled(rows, view, group_painters, painters, _ignore_num_columns): if not group_open: html.write("<tr><td class=tiles>") group_open = True - html.write('<div class="dr_%d dr tile %s"><table>' % (row_id(view, row), sclass)) + html.write('<div class="dr_%s dr tile %s"><table>' % (row_id(view, row), sclass)) # We need at least five painters. empty_painter = { "paint" : (lambda row: ("", "")) }

13 years

Check_MK Git: check_mk: Bulk action buttons are shown at the top of hostlists too when the lists have more than 10 list items

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 566a862ed99219d3ef36033c4133e306aea99077 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=566a862ed99219… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 12:55:55 2011 +0200 Bulk action buttons are shown at the top of hostlists too when the lists have more than 10 list items --- ChangeLog | 4 +++ web/htdocs/wato.py | 56 ++++++++++++++++++++++++++++++++------------------- 2 files changed, 39 insertions(+), 21 deletions(-) diff --git a/ChangeLog b/ChangeLog index b3ab8c9..c121dcb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -16,7 +16,11 @@ * Added missing sorters for "service nth service perfdata" painters * Implemented row selection in views to select only a subset of shown data for actions + + WATO: * Changed row selection in WATO to new row selection mechanism + * Bulk action buttons are shown at the top of hostlists too when the lists + have more than 10 list items 1.1.11i3: Core, Setup, etc.: diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 6f10be4..2fef9db 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -634,7 +634,26 @@ def mode_file(phase): html.write("</tr>\n") odd = "odd" + def bulk_actions(at_least_one_imported): + # bulk actions + html.write('<tr class="data %s0">' % odd) + html.write("<td colspan=%d>" % colspan) + html.jsbutton('_markall', 'X', 'javascript:toggle_all_rows();') + html.write(' ' + _("On all selected hosts:\n")) + html.button("_bulk_delete", _("Delete")) + html.button("_bulk_edit", _("Edit")) + html.button("_bulk_cleanup", _("Cleanup")) + html.button("_bulk_inventory", _("Inventory")) + host_move_combo(None) + if at_least_one_imported: + html.button("_bulk_movetotarget", _("Move to Target Folders")) + html.write("</td></tr>\n") + search_text = html.var("search") + + # Remember if that host has a target folder (i.e. was imported with + # a folder information but not yet moved to that folder). If at least + # one host has a target folder, then we show an additional bulk action. at_least_one_imported = False for hostname in hostnames: if search_text and (search_text.lower() not in hostname.lower()): @@ -643,6 +662,21 @@ def mode_file(phase): host = g_hosts[hostname] effective = effective_attributes(host, g_file) + if effective.get("imported_folder"): + at_least_one_imported = True + + # Add the bulk action buttons also to the top of the table when this + # list shows more than 10 rows + if len(hostnames) > 10: + bulk_actions(at_least_one_imported) + + for hostname in hostnames: + if search_text and (search_text.lower() not in hostname.lower()): + continue + + host = g_hosts[hostname] + effective = effective_attributes(host, g_file) + # Rows with alternating odd/even styles html.write('<tr class="dr_%s dr data %s0">' % (hostname, odd)) odd = odd == "odd" and "even" or "odd" @@ -682,27 +716,7 @@ def mode_file(phase): html.write("</td>") html.write("</tr>\n") - # Remember if that host has a target folder (i.e. was imported with - # a folder information but not yet moved to that folder). If at least - # one host has a target folder, then we show an additional bulk action. - if effective.get("imported_folder"): - at_least_one_imported = True - - - # bulk actions - html.write('<tr class="data %s0">' % odd) - html.write("<td colspan=%d>" % colspan) - html.jsbutton('_markall', 'X', 'javascript:toggle_all_rows();') - html.write(_("On all selected hosts:\n")) - html.button("_bulk_delete", _("Delete")) - html.button("_bulk_edit", _("Edit")) - html.button("_bulk_cleanup", _("Cleanup")) - html.button("_bulk_inventory", _("Inventory")) - host_move_combo(None) - if at_least_one_imported: - html.button("_bulk_movetotarget", _("Move to Target Folders")) - html.write("</td></tr>\n") - + bulk_actions(at_least_one_imported) html.write("</table>\n") # Important: remove selected hosts from the hidden fields. Otherwise

13 years

Check_MK Git: check_mk: Creating pending log entry for changed file/ folder titles

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: b1aa4b86b5e7beeee2e882fc821d93c2e2084711 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b1aa4b86b5e7be… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 12:06:34 2011 +0200 Creating pending log entry for changed file/folder titles --- web/htdocs/wato.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index ec33a70..cd13efa 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -379,12 +379,16 @@ def mode_editfolder(phase, what, new): else: new_thing["num_hosts"] = 0 g_files[newpath] = new_thing - + g_folder["." + what + "s"][name] = new_thing log_audit(new_thing, "new-" + what, _("Created new %s %s") % (the_what, title)) call_hook_file_or_folder_created(what, new_thing) else: + if the_thing["title"] != title: + log_pending(the_thing, "edit-" + what, _("Changed title of %s from \"%s\" to \"%s\"") % + (the_what, the_thing["title"], title)) + the_thing["title"] = title the_thing["roles"] = roles the_thing["attributes"] = attributes

13 years

Check_MK Git: check_mk: Added uniq key generator for indentifying the data rows (e.g. used in row selection)

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 0fa2a7215d4f83385585442c50d7bec127ace7e4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0fa2a7215d4f83… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 11:26:32 2011 +0200 Added uniq key generator for indentifying the data rows (e.g. used in row selection) --- web/htdocs/js/check_mk.js | 5 +++-- web/htdocs/views.py | 36 ++++++++++++++++++++++++------------ web/plugins/views/datasources.py | 32 ++++++++++++++++++++++++-------- web/plugins/views/layouts.py | 12 ++++++------ 4 files changed, 57 insertions(+), 28 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=0fa2a7215d…

13 years

Check_MK Git: check_mk: Dont make rows selectable when no commands can be fired

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: f4a91624fd6bcba64dc214b9058cfabba3464541 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f4a91624fd6bcb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 10:17:46 2011 +0200 Dont make rows selectable when no commands can be fired --- web/plugins/views/layouts.py | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/web/plugins/views/layouts.py b/web/plugins/views/layouts.py index 5c8a98b..09c710a 100644 --- a/web/plugins/views/layouts.py +++ b/web/plugins/views/layouts.py @@ -25,6 +25,10 @@ # Boston, MA 02110-1301 USA. def init_rowselect(): + # Don't make rows selectable when no commands can be fired + if not 'C' in html.display_options or not config.may("act"): + return + row_nums = [] if html.has_var('selected_rows'): selected_rows = html.var('selected_rows', '')

13 years

Check_MK Git: check_mk: Added select/deselect all button ("x") to view action row

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: ac51262fba3cc16143061e0d1e0cfb999508e6d5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ac51262fba3cc1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 5 10:07:15 2011 +0200 Added select/deselect all button ("x") to view action row --- web/htdocs/js/check_mk.js | 31 ++++++++++++++++++++++++++++++- web/htdocs/views.py | 14 +++++++++++--- 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/web/htdocs/js/check_mk.js b/web/htdocs/js/check_mk.js index c1b0321..588b105 100644 --- a/web/htdocs/js/check_mk.js +++ b/web/htdocs/js/check_mk.js @@ -961,9 +961,17 @@ function highlight_elem(elem, on, ty) { highlight_elem(childs[i], on, ty); } +function select_all_rows(elems) { + for(var i = 0; i < elems.length; i++) { + highlight_elem(elems[i], true, 'click'); + if(g_selected_rows.indexOf(elems[i].row_num) === -1) + g_selected_rows.push(elems[i].row_num); + } +} + function remove_selected_rows(row_num) { for(var i = g_selected_rows.length - 1; i >= 0; i--) { - if(g_selected_rows[i] != row_num) { + if(g_selected_rows[i] !== row_num) { highlight_row(g_selected_rows[i], false, 'click'); highlight_row(g_selected_rows[i], false, 'hover'); g_selected_rows.splice(i, 1); @@ -1031,6 +1039,27 @@ function disable_selection(e) { return false; } +// Is used to select/deselect all rows in the current view +function toggle_all_rows() { + var elems = document.getElementsByClassName('dr'); + + var all_selected = true; + for(var i = 0; i < elems.length && all_selected == true; i++) { + if(elems[i].tagName != 'TD' && elems[i].tagName != 'DIV') + continue; + + if(g_selected_rows.indexOf(elems[i].row_num) === -1) + all_selected = false; + } + + // Now set the new state + if(all_selected) { + remove_selected_rows(''); + } else { + select_all_rows(elems); + } +} + function get_row_num(elem) { // FIXME: Maybe performance problem. Would be better to have a // dedicated attribute for the data row number diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 845d6c0..c6a16db 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -1275,6 +1275,12 @@ def show_view(view, show_heading = False, show_buttons = True, show_footer = Tru # Buttons for view options if 'O' in display_options: + # Link for selecting/deselecting all rows + if 'C' in display_options and len(rows) > 0 and config.may("act") and not html.do_actions(): + html.write('<td class="left w30"><a href="javascript:toggle_all_rows()" ' + 'title="%s">%s</a></td>\n' % (_('Toggle all row selections'), _('x'))) + html.write("<td class=minigap></td>\n") + if config.user_may(config.user, "view_option_columns"): for col in config.view_option_columns: uri = html.makeuri([("num_columns", col)]) @@ -1282,7 +1288,8 @@ def show_view(view, show_heading = False, show_buttons = True, show_footer = Tru addclass = " selected" else: addclass = "" - html.write('<td class="left w30%s"><a href="%s">%s</a></td>\n' % (addclass, uri, col)) + html.write('<td class="left w30%s"><a href="%s" title="%s">%s</a></td>\n' % + (addclass, uri, _('%d column layout') % col, col)) html.write("<td class=minigap></td>\n") if 'R' in display_options and config.user_may(config.user, "view_option_refresh"): @@ -1296,8 +1303,9 @@ def show_view(view, show_heading = False, show_buttons = True, show_footer = Tru reftext = "%d s" % ref else: reftext = "∞" - html.write('<td class="left w40%s" id="button-refresh-%s"><a href="%s">%s</a></td>\n' % - (addclass, ref, uri, reftext)) + html.write('<td class="left w40%s" id="button-refresh-%s">' + '<a href="%s" title="%s">%s</a></td>\n' % + (addclass, ref, uri, _('refresh every %d seconds') % ref, reftext)) html.write("<td class=minigap></td>\n") html.write("<td class=gap> </td>\n")

13 years

Check_MK Git: check_mk: Added missing localization string

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: eee9d96b27a266ab97d1ca5dee2b4e031f0df5de URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eee9d96b27a266… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Sat Sep 3 16:18:08 2011 +0200 Added missing localization string --- .bugs/58 | 10 +++++++--- web/htdocs/views.py | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.bugs/58 b/.bugs/58 index 1ed3d43..fdd7735 100644 --- a/.bugs/58 +++ b/.bugs/58 @@ -1,11 +1,15 @@ Title: Views per Ajax refreshen, Reload der Seite verhindern Component: multisite +State: done +Class: feature +Date: 2010-12-21 22:16:00 Benefit: 1 -State: open Cost: 3 -Date: 2010-12-21 22:16:00 -Class: feature +Fun: 0 orschlag von Bastian: Bei den Views könnte man den Datenbereich (Tabelle) per Ajax refreshen und müsste nicht die ganze Seite neu aufbauen. Damit wird ein Bildschirmflimmern vermieden. + +2011-09-03 16:11:01: changed state open -> done +Has been fixed. diff --git a/web/htdocs/views.py b/web/htdocs/views.py index eda637b..845d6c0 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -1270,7 +1270,7 @@ def show_view(view, show_heading = False, show_buttons = True, show_footer = Tru # Painter-Options if 'D' in display_options and len(painter_options) > 0 and config.may("painter_options"): - toggle_button("painter_options", False, "Display") + toggle_button("painter_options", False, _("Display")) html.write("<td class=minigap></td>\n") # Buttons for view options

13 years

Check_MK Git: check_mk: Added missing i18n strings in command form and list of views

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: cc6ebf11f363ad8b8c8f8427eefd52c9773450e6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cc6ebf11f363ad… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 2 16:42:24 2011 +0200 Added missing i18n strings in command form and list of views --- ChangeLog | 1 + web/htdocs/views.py | 118 ++++++++++++++++---------------- web/plugins/views/painters.py | 6 +- web/plugins/wato/builtin_attributes.py | 4 +- 4 files changed, 67 insertions(+), 62 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=cc6ebf11f3…

13 years

Check_MK Git: check_mk: Implemented row selection in views

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 021fe461031073681c83c195eb2e0742e7a21869 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=021fe461031073… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Sep 2 15:50:03 2011 +0200 Implemented row selection in views Implemented row selection in views to select only a subset of shown data for actions. Implementation notes: Momentan verfügen die Views nicht über die Möglichkeit einzelne Datensätze zu selektieren und dann nur auf diese ein Command auszuführen. Dies ist in MS4 gefordert und soll wie folgt direkt im Multisite Code umgesetzt werden: - Standard-Verhalten bleibt bestehen: Wenn kein Datensatz explizit ausgewählt wurde, dann werden die Aktionen auf alle angezeigten Datensätze ausgeführt. - Beim Mouseover über eine Row wird diese durch Ändern der Hintergrundfarbe hervorgehoben. Man muss dafür nicht neue Farben definieren, es sollte reichen für jede Zelle, wo ein Hintergrund gesetzt ist, die Farbe etwas heller/dunkler zu machen. - Der Nutzer kann mit der Maus auf eine beliebige Stelle in der Tabelle Klicken. Daraufhin wird die Row selektiert. Bei nochmaligem Klicken wird die Seletion aufgehoben. - Die aktuellen Selektionen müssen auf der aktuellen Seite den Reload überleben. Allerdings werden die nicht persistiert. Also ganz genau wie die sorter. Dazu müssen die aktuellen Selektionen des Nutzers nach dem regulären Reload der Seite neu gesetzt werden. Alternativ müssen die Selektionen als URL Parameter durchgeschleift werden und dazu führen, dass die Rows beim Laden der Seite selektiert sind. - Wie werden die Rows identifiziert? Die Rows müssten immer in der Reihenfolge angezeigt werden, in der auch die Datensätze im Check_MK vorliegen. Wenn das so ist, dann kann man die Rows einfach durchnummerieren. Die Alternative sähe schon komplizierter aus. Da müsste man für jede Row einen eindeutigen Schlüssel finden, der sich je nach angezeigten Daten aus verschiedenen Infos zusammensetzen kann. z.B. site,host,service oder ... Eine Row bedeutet hier nicht (!) ein html TR Element, denn die verschiedenen Layouts sind nicht unbendingt einfache Tabellen. Versuch: Die Row Elemente werden via CSS-Klasse identifiziert. Das hat den Grund, dass man mit getElementsByClassName() relativ komfortablen alle Objekte bekommt. Es gibt eine CSS-Klasse "dr" für alle "data row" Elemente und "dr_#" durchnummeriert für alle Elemente eine "data row". - views.py vor dem Verarbeiten von do_actions() müssen die Rows gefiltert werden. Allerdings dürfen diese nur für die Aktionen gefiltert werden. Bei der Anzeige muss wieder alles gezeigt werden. - Alle Layouts inkl. verschiedene Datasources testen --- ChangeLog | 2 + web/htdocs/htmllib.py | 10 +- web/htdocs/js/check_mk.js | 308 ++++++++++++++++++++++++++++++++++++++++++ web/htdocs/js/sidebar.js | 4 - web/htdocs/views.py | 27 +++- web/plugins/views/layouts.py | 29 +++- 6 files changed, 358 insertions(+), 22 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=021fe46103…

13 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits