Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64160 discussions

Check_MK Git: check_mk: Add new bug entry

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 0100cb570c6bcd36bef6663a527b95737c68c9be URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0100cb570c6bcd… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Wed Sep 7 19:11:18 2011 +0200 Add new bug entry --- .bugs/317 | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/.bugs/317 b/.bugs/317 new file mode 100644 index 0000000..8c179d2 --- /dev/null +++ b/.bugs/317 @@ -0,0 +1,14 @@ +Title: md raid check reports wrong number of disks +Component: checks +Benefit: 2 +State: open +Cost: 2 +Date: 2011-09-07 19:09:23 +Class: bug + +the infotext seems to mix up numbers +this is from a 4-disk raid10 with one "missing" member +CRIT - disk state is [4/3] [UUU_] (expected 3 disks to be up) +... there was 2 or 3 disks during inventory actually, since i created it with +"sda missing sdb missing". but the message sounds like the numbers are just +twisted

13 years

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: bdf7415b8f9851ab74debfc3170031de18daec06 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bdf7415b8f9851… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 7 17:42:24 2011 +0200 Updated bug entries --- .bugs/365 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/365 b/.bugs/365 new file mode 100644 index 0000000..fbf7f04 --- /dev/null +++ b/.bugs/365 @@ -0,0 +1,10 @@ +Title: Windows agent: make sections disableable by config +Component: checks +Benefit: 1 +State: open +Cost: 1 +Date: 2011-09-07 17:35:51 +Class: feature + +It would be nice if the configuration of the windows agent would allow +to disable certain sections, e.g. logwatch.

13 years

Check_MK Git: check_mk: scan-parents: tag found parents with ping

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d132299be100d879a21e2807bd7a1106a4f95ecd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d132299be100d8… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 7 17:43:34 2011 +0200 scan-parents: tag found parents with ping --- ChangeLog | 2 ++ modules/check_mk.py | 2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index c3ef015..2ea7ba4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,8 @@ Core, Setup, etc.: * FIX: use hostgroups instead of host_groups in Nagios configuration. This fixes a problem with Shinken + * --scan-parents: detected parent hosts are now tagged with 'ping', so + that no agent will be contacted on those hosts Checks & Agents: * Added 4 new checks dell_powerconnect_* by Chris Bowlby diff --git a/modules/check_mk.py b/modules/check_mk.py index 899458c..d69efe2 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -3624,7 +3624,7 @@ def do_scan_parents(hosts): gateway = "gw-%s" % (gateway_ip.replace(".", "-")) if gateway not in gateway_hosts: gateway_hosts.add(gateway) - parent_hosts.append("%s|parent" % gateway) + parent_hosts.append("%s|parent|ping" % gateway) parent_ips[gateway] = gateway_ip parent_rules.append( (monitoring_host, [gateway]) ) # make Nagios a parent of gw parent_rules.append( (gateway, [host]) )

13 years

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: f49ea7a0cc57cae547b54113532b4b874dab5952 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f49ea7a0cc57ca… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 7 17:14:19 2011 +0200 Updated bug entries --- .bugs/363 | 9 +++++++++ .bugs/364 | 11 +++++++++++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/.bugs/363 b/.bugs/363 new file mode 100644 index 0000000..505def1 --- /dev/null +++ b/.bugs/363 @@ -0,0 +1,9 @@ +Title: NagStaMon: Dokumentation how to setup +Component: doku +Benefit: 1 +State: open +Cost: 2 +Date: 2011-09-07 17:04:21 +Class: todo + +Document how to configure NagStaMon with Check_MK Multisite. diff --git a/.bugs/364 b/.bugs/364 new file mode 100644 index 0000000..24005da --- /dev/null +++ b/.bugs/364 @@ -0,0 +1,11 @@ +Title: Make links targets controllable via URL parameter +Component: multisite +Benefit: 2 +State: open +Cost: 3 +Date: 2011-09-07 17:13:09 +Class: feature + +We could add URL parameters that control the target-tag in links, +such that either internal, external or both links can be directed +to certain frames (e.g. external links to _parent).

13 years

Check_MK Git: check_mk: Fix hook missing bug

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 67a82bdfde6b782168cff48ee767b7974667704c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=67a82bdfde6b78… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 7 17:04:16 2011 +0200 Fix hook missing bug --- web/htdocs/views.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/htdocs/views.py b/web/htdocs/views.py index 61fbb50..f7ca622 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -2244,7 +2244,7 @@ def register_hook(hook, func): view_hooks[hook].append(func) def execute_hooks(hook): - for hook_func in view_hooks[hook]: + for hook_func in view_hooks.get(hook, []): try: hook_func() except:

13 years

Check_MK Git: check_mk: Fixed Python/JSON webservice after checkbox change

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: f66dbf7ef7f58caab93b32cfc16979a43111d06c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f66dbf7ef7f58c… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 7 17:01:42 2011 +0200 Fixed Python/JSON webservice after checkbox change --- web/plugins/views/webservice.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/web/plugins/views/webservice.py b/web/plugins/views/webservice.py index 7305e1c..a0391b6 100644 --- a/web/plugins/views/webservice.py +++ b/web/plugins/views/webservice.py @@ -24,7 +24,7 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. -def render_python_raw(data, view, group_painters, painters, num_columns): +def render_python_raw(data, view, group_painters, painters, num_columns, show_checkboxes): html.write(repr(data)) multisite_layouts["python-raw"] = { @@ -34,7 +34,7 @@ multisite_layouts["python-raw"] = { "hide" : True, } -def render_python(rows, view, group_painters, painters, num_columns): +def render_python(rows, view, group_painters, painters, num_columns, show_checkboxes): html.write("[\n") html.write(repr([p[0]["name"] for p in painters])) html.write(",\n") @@ -63,7 +63,7 @@ def encode_string_json(s): return '"' + json_escape.sub(lambda m: json_encoding_table[m.group(0)], s) + '"' -def render_json(rows, view, group_painters, painters, num_columns): +def render_json(rows, view, group_painters, painters, num_columns, show_checkboxes): html.write("[\n") html.write(repr([p[0]["name"] for p in painters])) for row in rows:

13 years

Check_MK Git: check_mk: ipmi_sensors: correctly handle further positive status texts

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 10de26645d10d7d6b7e72d48a1a798cd8a4e8292 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=10de26645d10d7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 7 16:16:41 2011 +0200 ipmi_sensors: correctly handle further positive status texts --- ChangeLog | 2 ++ checks/ipmi_sensors | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index e005ba8..c3ef015 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,8 @@ Checks & Agents: * Added 4 new checks dell_powerconnect_* by Chris Bowlby + * ipmi_sensors: correctly handle further positive status texts + (thanks to Sebastian Talmon) Multisite: * FIX: WATO filtered status GUIs did not update the title after changing diff --git a/checks/ipmi_sensors b/checks/ipmi_sensors index c468ed8..42e7b20 100644 --- a/checks/ipmi_sensors +++ b/checks/ipmi_sensors @@ -108,8 +108,12 @@ def check_freeipmi(item, _no_params, info): perfdata = [] else: perfdata = [ ("value", current, None, crit) ] - infotext = "Current value %.1f%s%s" % (current, unit, levelstext) - if status == "OK" or status.startswith("Fully_Redundant"): + infotext = "Current value %.1f%s%s" % (current, unit, levelstext) + if status == "OK" \ + or status == "Entity_Present" \ + or status.endswith("is_connected") \ + or status.endswith("Presence_detected") \ + or status.startswith("Fully_Redundant"): return (0, "OK - " + infotext, perfdata) else: return (2, "CRIT - " + infotext, perfdata)

13 years

Check_MK Git: check_mk: Updated hook api to draw custom link buttons in views

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: e1c841b6ae6d0aa69ca09befbec324d14fc416db URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e1c841b6ae6d0a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 7 15:42:55 2011 +0200 Updated hook api to draw custom link buttons in views --- ChangeLog | 2 +- web/htdocs/views.py | 47 ++++++++++++++++++++++------------------------- 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/ChangeLog b/ChangeLog index 50e7586..e005ba8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -29,7 +29,7 @@ * Sort titles in views can be enabled by clicking on the whole cells now * Submitting the view editor via ENTER key saves the view now instead of try mode * Host comments have red backgrounded rows when host is down - * Implemented extra_custom_links to be used in views to register custom context links + * Implemented hook api to draw custom link buttons in views WATO: * Changed row selection in WATO to new row selection mechanism diff --git a/web/htdocs/views.py b/web/htdocs/views.py index fc9052b..61fbb50 100644 --- a/web/htdocs/views.py +++ b/web/htdocs/views.py @@ -25,7 +25,7 @@ # Boston, MA 02110-1301 USA. import config, defaults, livestatus, htmllib, time, os, re, pprint, time, copy -import weblib +import weblib, traceback from lib import * from pagefunctions import * @@ -49,7 +49,7 @@ multisite_sorters = {} multisite_builtin_views = {} multisite_painter_options = {} ubiquitary_filters = [] # Always show this filters -extra_context_links = [] +view_hooks = {} # Load all view plugins def load_plugins(): @@ -1567,6 +1567,7 @@ def show_context_links(thisview, active_filters): # Show button to WATO, if permissions allow this if config.may("use_wato"): html.begin_context_buttons() + execute_hooks('buttons-begin') first = False host = html.var("host") if host: @@ -1621,32 +1622,11 @@ def show_context_links(thisview, active_filters): if first: first = False html.begin_context_buttons() + execute_hooks('buttons-begin') vars_values = [ (var, html.var(var)) for var in set(used_contextvars) ] html.context_button(view_linktitle(view), html.makeuri_contextless(vars_values + [("view_name", name)]), view.get("icon")) - # Add the plugin registered context links when the var requirements can be met - # custom context links can be registered in view plugins like this: - # - # def get_my_link_url(view): - # (...) - # return '/url/to/link/to' - # - # extra_context_links = [ - # ([], 'The Title', get_my_link_url, 'map'), - # ] - # - # The first element is a list of required var names to show this button - # The fourth element it the name of the icon (icon_<name>.png) - # - # The url render function needs to return the target URL as string but can - # also return None to disable this link for the current view - for needed_vars, title, url_func, icon in extra_context_links: - miss = [ v for v in needed_vars if v not in active_filter_vars ] - if miss: - break - url = url_func(view) - if url is not None: - html.context_button(title, url, icon) + execute_hooks('buttons-end') if not first: html.end_context_buttons() @@ -2257,6 +2237,23 @@ def page_message_and_forward(message, default_url, addhtml=""): # |_| |_|\__,_|\__, |_|_| |_| |_| |_|\___|_| .__/ \___|_| |___/ # |___/ |_| +def register_hook(hook, func): + if not hook in view_hooks: + view_hooks[hook] = [func] + else: + view_hooks[hook].append(func) + +def execute_hooks(hook): + for hook_func in view_hooks[hook]: + try: + hook_func() + except: + if config.debug: + raise MKGeneralException(_('Problem while executing hook function %s in hook %s: %s') + % (hook_func.__name__, hook, traceback.format_exc())) + else: + pass + def prepare_paint(p, row): painter = p[0] linkview = p[1]

13 years

Check_MK Git: check_mk: Merge branch 'master' of ssh://git.mathias-kettner. de/var/www/80/git.mathias-kettner.de/check_mk

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: e6d7d709133e02790819ec6c0ec347e1b3f201e4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e6d7d709133e02… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 7 15:38:25 2011 +0200 Merge branch 'master' of ssh://git.mathias-kettner.de/var/www/80/git.mathias-kettner.de/check_mk ---

13 years

Check_MK Git: check_mk: Fixed group row select on views without groupings

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: f801c875ee9bd35d93b21a44cd23279dc0e6afc8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f801c875ee9bd3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 7 15:38:18 2011 +0200 Fixed group row select on views without groupings --- web/htdocs/js/check_mk.js | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/web/htdocs/js/check_mk.js b/web/htdocs/js/check_mk.js index 41ea146..76d2fb6 100644 --- a/web/htdocs/js/check_mk.js +++ b/web/htdocs/js/check_mk.js @@ -1169,7 +1169,7 @@ function toggle_group_rows(checkbox) { } if(group_start === null) - return; + group_start = 0; if(group_end === null) group_end = rows.length - 1; @@ -1190,7 +1190,7 @@ function toggle_group_rows(checkbox) { // container are highlighted. // It is also possible to give an array of DOM elements as parameter to toggle // all checkboxes below these objects. -function toggle_all_rows(obj, force_status) { +function toggle_all_rows(obj) { var checkboxes = get_all_checkboxes(obj || document); var all_selected = true; @@ -1199,7 +1199,7 @@ function toggle_all_rows(obj, force_status) { all_selected = false; // Toggle the state - if((typeof(force_status) !== 'undefined' && force_status) || all_selected) { + if(all_selected) { remove_selected_rows(checkboxes); } else { select_all_rows(checkboxes);

13 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits